public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Shashi Mallela <shashi.mallela@linaro.org>
Cc: ard.biesheuvel@arm.com, graeme@nuviainc.com, devel@edk2.groups.io
Subject: Re: [PATCH v1-resend 1/1] Silicon/Qemu/Sbsa: sbsa-wdt interrupt id update
Date: Tue, 15 Dec 2020 11:57:35 +0000	[thread overview]
Message-ID: <20201215115735.GW1664@vanye> (raw)
In-Reply-To: <20201214174512.12919-2-shashi.mallela@linaro.org>

On Mon, Dec 14, 2020 at 12:45:12 -0500, Shashi Mallela wrote:
> The previous value of interrupt id used was not in sync
> with the interrupt id being used in qemu sbsa-ref platform
> due to a conflict before merging and was missed in last review.
> This was preventing the watchdog interrupt from getting
> identified.Updated SBSA-wdt interrupt id in Gtdt table
> to rectify the issue.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 406d37e36414.

Thanks!
/
    Leif

> ---
>  Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> index a010b908c434..14733a37183d 100644
> --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
> @@ -36,7 +36,7 @@
>  
>  #define SBSAQEMU_WDT_REFRESH_FRAME_BASE      0x50010000
>  #define SBSAQEMU_WDT_CONTROL_FRAME_BASE      0x50011000
> -#define SBSAQEMU_WDT_IRQ                     44
> +#define SBSAQEMU_WDT_IRQ                     48
>  
>  #define GTDT_WDTIMER_EDGE_TRIGGERED   EFI_ACPI_6_3_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE
>  #define GTDT_WDTIMER_LEVEL_TRIGGERED  0
> -- 
> 2.27.0
> 

      reply	other threads:[~2020-12-15 11:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 17:45 [PATCH v1-resend 0/1] sbsa-wdt interrupt id update Shashi Mallela
2020-12-14 17:45 ` [PATCH v1-resend 1/1] Silicon/Qemu/Sbsa: " Shashi Mallela
2020-12-15 11:57   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201215115735.GW1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox