From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web08.1612.1608055615070668701 for ; Tue, 15 Dec 2020 10:06:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=W0+TpJbN; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id a6so92784wmc.2 for ; Tue, 15 Dec 2020 10:06:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hlOhS4B0fOwS5rk9ojGwYd9LftU9o6GC7ejDhM0LPvM=; b=W0+TpJbNGuzrctw8pud+rQV1L5c9vKujrUTbSs21ah0xQP826bcTefEYeTr5VNfzGy DC7C/kMxq1S7mDKYlNf2GsbqTYTUd+Pbvkh6JlFvrLDWd8W9CorobZK5NrCHZjMsW60y wfkiQzLRAcmUtOr1+w3GUe5iCHPBv8nlpW23+7l0VNevsaNwOU+Q/pdXWzfNfFA+8MEC HGZWV3QNJM2upJkfVlzDkCKSBnJ4aLFnxBqHp+J3uB6L9MlZ6Iq6EZyFvzGzDDe06PK/ FDIiSsPjSPb6df96moQVETyaw+jdWV3g78NUr/ekN2Zm2d7DHkGC6UpPY1bHu/+4ZeOV VxVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hlOhS4B0fOwS5rk9ojGwYd9LftU9o6GC7ejDhM0LPvM=; b=SxeJv4RsRuFldO9zeIXtjJN7dr0gJ8E92CA57y2t3uDrcC0nE8RVxBd3s5h22fYK1f FEf+q2TdjnIjlvyphBVBQUrkmGDvAva+ME+PWj2dYlqEhnK6p2VKW68moMnM8vf+ifRn lcORSae1orBDGsgbedZKboi0//W4RaLKiJPE6j9srGC7ONg9q3M9u7N6sQ1Pru0Zxhii haz4BfVrP976DM2kMvaOk7oGPiKOyqrw8hQmSIcCaL1eDV/me5JhCTpAU/dIY4MY2kZy QMsA6eFZJ2tYdzSlOWdFBOHf7vxe7wgwGIZVvnSeVs4GIYMD8Lv6Yiwqn86ijLzd861V GddQ== X-Gm-Message-State: AOAM532qPnT7nTNjC60/4lVHBFTimnhJ9GnvKpwDl3Fx7891cJrTl0pz k5meWYxySfI3lkqIqgu1fka44w== X-Google-Smtp-Source: ABdhPJwJ1e1cVoKF5jOUEP9gNdsf6fsnoQFggrlEvkxLaNYmSxLq248t66KnA6Ts7AT07/O2w4ei+Q== X-Received: by 2002:a1c:1dd4:: with SMTP id d203mr106519wmd.118.1608055613609; Tue, 15 Dec 2020 10:06:53 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id m4sm36792563wmi.41.2020.12.15.10.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 10:06:53 -0800 (PST) Date: Tue, 15 Dec 2020 18:06:51 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Michael D Kinney , Liming Gao , Zhiguang Liu , Ard Biesheuvel Subject: Re: [PATCH v4 01/10] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h Message-ID: <20201215180651.GA1664@vanye> References: <20201207175427.28712-1-rebecca@nuviainc.com> <20201207175427.28712-2-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20201207175427.28712-2-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 07, 2020 at 10:54:18 -0700, Rebecca Cran wrote: > The ARM SMC Architecture functions were missing from ArmStdSmc.h. > Add them, based on the SMC Calling Convention version 1.2 specification. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm > --- > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > index 3509eb680f18..13f2245f37f5 100644 > --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > @@ -1,5 +1,6 @@ > /** @file > * > +* Copyright (c) 2020, NUVIA Inc. All rights reserved.
> * Copyright (c) 2012-2017, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -52,6 +53,18 @@ > #define ARM_SMC_MM_RET_DENIED -3 > #define ARM_SMC_MM_RET_NO_MEMORY -4 > > +// ARM Architecture Calls > +#define SMCCC_VERSION 0x80000000 > +#define SMCCC_ARCH_FEATURES 0x80000001 > +#define SMCCC_ARCH_SOC_ID 0x80000002 > +#define SMCCC_ARCH_WORKAROUND_1 0x80008000 > +#define SMCCC_ARCH_WORKAROUND_2 0x80007FFF > + > +#define SMC_ARCH_CALL_SUCCESS 0 > +#define SMC_ARCH_CALL_NOT_SUPPORTED -1 > +#define SMC_ARCH_CALL_NOT_REQUIRED -2 > +#define SMC_ARCH_CALL_INVALID_PARAMETER -3 > + > /* > * Power State Coordination Interface (PSCI) calls cover a subset of the > * Standard Service Call range. > -- > 2.26.2 >