public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "James Bottomley" <jejb@linux.ibm.com>
To: devel@edk2.groups.io
Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com,
	ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com,
	david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com,
	jejb@linux.ibm.com, frankeh@us.ibm.com,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: [PATCH 1/2] OvmfPkg: Change SEV Launch Secret API to be UINT64 for base and size
Date: Tue, 15 Dec 2020 17:41:45 -0800	[thread overview]
Message-ID: <20201216014146.2229-2-jejb@linux.ibm.com> (raw)
In-Reply-To: <20201216014146.2229-1-jejb@linux.ibm.com>

Although the SEV secret location must always be below 4GB, the same is
not necessarily true for Intel TDX, so change the configuration table
to contain a pair of UINT64 parameters instead of UINT32 so that any X64
location can be represented.

Signed-off-by: James Bottomley <jejb@linux.ibm.com>

---

This represents an ABI change, so it is essential to get this in
before the next stable tag
---
 OvmfPkg/Include/Guid/SevLaunchSecret.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/OvmfPkg/Include/Guid/SevLaunchSecret.h b/OvmfPkg/Include/Guid/SevLaunchSecret.h
index fa5f3830bc2b..dfd89646651b 100644
--- a/OvmfPkg/Include/Guid/SevLaunchSecret.h
+++ b/OvmfPkg/Include/Guid/SevLaunchSecret.h
@@ -19,8 +19,8 @@
   }
 
 typedef struct {
-  UINT32 Base;
-  UINT32 Size;
+  UINT64 Base;
+  UINT64 Size;
 } SEV_LAUNCH_SECRET_LOCATION;
 
 extern EFI_GUID gSevLaunchSecretGuid;
-- 
2.26.2


  reply	other threads:[~2020-12-16  1:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16  1:41 [PATCH 0/2] Update SevSecret API to work for TDX James Bottomley
2020-12-16  1:41 ` James Bottomley [this message]
2020-12-16  1:41 ` [PATCH 2/2] OvmfPkg/AmdSev/SecretDxe: make secret location naming generic James Bottomley
2020-12-16  8:27   ` Dov Murik
2020-12-16 16:53     ` James Bottomley
2020-12-17  0:25       ` Yao, Jiewen
2020-12-16  1:55 ` [PATCH 0/2] Update SevSecret API to work for TDX Yao, Jiewen
2020-12-17 18:43 ` [edk2-devel] " Laszlo Ersek
2020-12-17 19:23   ` Laszlo Ersek
2020-12-17 20:00     ` Laszlo Ersek
2020-12-18 10:49 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216014146.2229-2-jejb@linux.ibm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox