From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.113]) by mx.groups.io with SMTP id smtpd.web08.7290.1608125169909680217 for ; Wed, 16 Dec 2020 05:26:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b=bCBINr55; spf=pass (domain: os.amperecomputing.com, ip: 40.107.220.113, mailfrom: quan@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QuoMRkHmlVXe/Hsgxh6ASMQ5H+2djD7zVK4r/3B+rXNgdpizTp6QnJmrHLJjQV+R8Me/FUT/UF67C7k38QNz8IQIl6wGxrNgSiYNUeaGfY1IsI6GY0GrM1SXQ7SvZFNqAMEXuZUpDWn+QUi7qAAXp8Y+x4cOQhzg4d+sqIZImqe2mEzB7GY0xfYI+O8N1nguUKD9RtHdXWVIhmnbrk59/fSv54l5ZSaqeSO6NVzTll55YWrPVOKTMTQhxzg39S5STnQEwvYq/YSs8GBCz+1jp4gCh5glTEg/21uYRtMImEhlulYkBJHBH+v5rxSCtq4GAB9y4MZG2CqJ1CQ8VkEXtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f3T2Gyr1075rYrxSqxYH8vuW2L15y68Lz1RT6m2WyyM=; b=AmP0zIcabbEAncgjtgESZeg0qWqsN/6x1Fn29Vvh3LYPCQ7MbD5s0zxLtoXt7v19i4WUgJMtb4LduEfEjZKylkMrG2lNSPnDQNt2RAG+JOGtUrCsyyySnzrWVKBseS1ERE722oVZQhFTJoDi28SLsvcINIVN7G63y8jDcPxzP4quWJLDtdSkZnKI1rvLujF2/G36rh7haK7ONmgplQaIBqyQiMpzWaWR/nQWHFRTWAtwQKgeyoJpT2aAaRfQPlZg6xD14BLwfukbx0b2heQgBSjHU3bdler5b0nvAT1AqLdJ+qdfe66p4F9nFPnBeO/ljj7loqUodvvsFpkQt01CVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f3T2Gyr1075rYrxSqxYH8vuW2L15y68Lz1RT6m2WyyM=; b=bCBINr55dCpkNhT9RALNnBZ9DpK6HXcGOemcSLiPazDss6wtd9c1KcCGv2oVKFb0SagGQ1285zm6txJGMiRTQaobLDqaCL78sxqa1rGodvvMGcsdrZmVenLFL543hxW2hAL2gb/sMp+tseW6n6U+X+OM7Vf9q/OyJKqwsSybH08= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=os.amperecomputing.com; Received: from MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) by MW4PR01MB6321.prod.exchangelabs.com (2603:10b6:303:7b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.24; Wed, 16 Dec 2020 13:26:09 +0000 Received: from MW2PR0102MB3482.prod.exchangelabs.com ([fe80::e903:700a:f17:7a17]) by MW2PR0102MB3482.prod.exchangelabs.com ([fe80::e903:700a:f17:7a17%7]) with mapi id 15.20.3654.020; Wed, 16 Dec 2020 13:26:09 +0000 From: "Quan Nguyen" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Victor Gallardo , Open Source Submission , Quan Nguyen Subject: [PATCH v2 2/2] ArmPkg/ArmGicV3Dxe: Use ArmGicSetInterruptPriority() to set priority Date: Wed, 16 Dec 2020 20:25:21 +0700 Message-Id: <20201216132521.5915-3-quan@os.amperecomputing.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201216132521.5915-1-quan@os.amperecomputing.com> References: <20201216132521.5915-1-quan@os.amperecomputing.com> X-Originating-IP: [118.69.219.201] X-ClientProxiedBy: HK2PR02CA0140.apcprd02.prod.outlook.com (2603:1096:202:16::24) To MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) Return-Path: quan@os.amperecomputing.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hcm-sw-17.amperecomputing.com (118.69.219.201) by HK2PR02CA0140.apcprd02.prod.outlook.com (2603:1096:202:16::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 16 Dec 2020 13:26:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 025c0975-08f9-4596-0eee-08d8a1c62645 X-MS-TrafficTypeDiagnostic: MW4PR01MB6321: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HihzQXVm9yzeTFai8pNI5gGl7u+2tSdp+iia7NC2qiQLq74IRfJcWOtN/bbeGCN3C4SBX0r+a+RTSDC+3oGGdjGePj00G9tkk2e9suzurNwsUshqkxQW636nAma1E1BOKc1Dbdndt8Ito5h5kxgRq23Dbf7I9vcv8oUIgDojD9si9Jsndv52dc7DCsX9Olb0pwD94awEY0/T6qlsSlpWWT/kE01BHJVsF8nj3VSbMn8H5RRnL5rKtqUnLGNt++2AICf68DjUWGf4aBH13ojQbPY71+RXiV7gk0OwTb+6S5M8eXfZ/ycE7xY6FTyBX6Qy86P19rf0LgPVujZbo/wG5Y35O404XQVqepimTS1/wfBdrmvCzJOhl843X4Jj2/+E X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR0102MB3482.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(136003)(376002)(396003)(39850400004)(8676002)(83380400001)(6486002)(2616005)(316002)(86362001)(5660300002)(2906002)(478600001)(66946007)(6512007)(54906003)(19627235002)(956004)(8936002)(6506007)(16526019)(6666004)(66556008)(107886003)(52116002)(66476007)(26005)(1076003)(4326008)(6916009)(186003)(213903007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?bVnn8TwmntF8mlhs4H8DQaBHQmG0H2a49sFaykYRdCX4jiqIsoMCsQfBbU0i?= =?us-ascii?Q?cPp8wte2gOigKLPAjBHsqjviNS/dtyPaUwhICt+C8LdpfZIe68ZT5UuNK0+Z?= =?us-ascii?Q?CCP0SAjNhl0x1nxAdtgN8Q/2Ve1BrOkT6ALPmPMwShVTQxRHF+glnmYcAW6e?= =?us-ascii?Q?gjt1A2UOw+271o6ox6MNMz1cTTUzPmo5lQAw6Gcu/D+nesKZZpJfl1WioPpK?= =?us-ascii?Q?OhhmgBClS/W9KcLXZMfNXOrP8rmjUhoq7UTvMy2kQ+tsii8hoElv7SbAkQHG?= =?us-ascii?Q?HTtw3BhOafsaTNFIsQZgp4kwr3LsUjbg7TStSql8QgmKE/Ll3e88VL4OkpGo?= =?us-ascii?Q?E3gV5BRaqsz0FQiXWYsACOR4m7eKr8sj/v7j6KzdZkjOMw6cFamXpgZbDhlW?= =?us-ascii?Q?QUd+hrt6v3Uuey++oPdIPipf7/Q1DLVXyTcc+yergijZCm+a2vdaVn6h1hEc?= =?us-ascii?Q?tnvz90BhU+Kf7vBECcQUle2CUIaNRUngHc3NUYKD5gk+3ScmmzEt57n/EiYF?= =?us-ascii?Q?UoANhsmS5fnne8mwE3rZESpQxJX8LKIvvuC62nqys3GkNmRRkSb5SNE5LTWG?= =?us-ascii?Q?llz6rbCuIPo5nxciE2tsqDg/Raq6ZRt2mgCvKfJ2ze3inW8nHjVXAToNwwXR?= =?us-ascii?Q?hiNuxjEcF9DfplOEKEIRqJZaoJxrNeHFg/xVZnAM5uMkwZ4G/ndPoRlK1bdb?= =?us-ascii?Q?cCUdT74TKFKxfKOtwt72FHaBZY16k861QNNxwkd0PefZFh4YZablYBaddtuY?= =?us-ascii?Q?uSiyz8k/Uos1HHgfc+g4Hddpa3RF4tjfqUgqGr7iu+3MKoHkbGYLmh5MItol?= =?us-ascii?Q?y5FoUVsLE2+28M3JmMy+wVEbZx2+1o5jZ4Zf7ENqlNJd/DInJAsoslkbG3SK?= =?us-ascii?Q?CMFY/cV9ugbWQjiWzDw8Uope58lwtZoxczMpBBHgKZY60ub4a5MKNxHV2NGY?= =?us-ascii?Q?snZaEQ0BjUYbjzQE++w4dUxIcmNZDh07nO5oFPrHFoLMn0i4/18LJJvNLdXz?= =?us-ascii?Q?HCYQ?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-AuthSource: MW2PR0102MB3482.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2020 13:26:08.9422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-Network-Message-Id: 025c0975-08f9-4596-0eee-08d8a1c62645 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RaIwp0RQkWhwdojouDmlKl3BAtUjF+UsXMXkklmUDFWPDg2rGEpxYHtejVESLz5Ofw/KsDRW7Nbvq3xvRsF1CclpnHT/j3wFodRNZtw6EMA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR01MB6321 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain When Affinity Routing enabled, the GICR_IPRIORITYR is used to set priority for SGIs and PPIs instead of GICD_IPRIORITYR. This patch calls ArmGicSetInterruptPriority() helper function when setting priority to handle the difference. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Victor Gallardo Signed-off-by: Quan Nguyen --- ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c b/ArmPkg/Drivers/Arm= Gic/GicV3/ArmGicV3Dxe.c index d7da1f198d9e..16bccbff413b 100644 --- a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c +++ b/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c @@ -374,8 +374,6 @@ GicV3DxeInitialize ( {=0D EFI_STATUS Status;=0D UINTN Index;=0D - UINT32 RegOffset;=0D - UINTN RegShift;=0D UINT64 CpuTarget;=0D UINT64 MpId;=0D =0D @@ -397,12 +395,11 @@ GicV3DxeInitialize ( GicV3DisableInterruptSource (&gHardwareInterruptV3Protocol, Index);=0D =0D // Set Priority=0D - RegOffset =3D Index / 4;=0D - RegShift =3D (Index % 4) * 8;=0D - MmioAndThenOr32 (=0D - mGicDistributorBase + ARM_GIC_ICDIPR + (4 * RegOffset),=0D - ~(0xff << RegShift),=0D - ARM_GIC_DEFAULT_PRIORITY << RegShift=0D + ArmGicSetInterruptPriority (=0D + mGicDistributorBase,=0D + mGicRedistributorsBase,=0D + Index,=0D + ARM_GIC_DEFAULT_PRIORITY=0D );=0D }=0D =0D --=20 2.28.0