From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.55.1608139356488111410 for ; Wed, 16 Dec 2020 09:22:36 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30BC11FB; Wed, 16 Dec 2020 09:22:36 -0800 (PST) Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0EA153F66E; Wed, 16 Dec 2020 09:22:34 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [PATCH v1 10/25] ArmPkg: Fix Ecc error 3001 in SemihostFs Date: Wed, 16 Dec 2020 17:21:45 +0000 Message-Id: <20201216172200.25846-11-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> From: Pierre Gondois This patch fixes the following Ecc reported error: Boolean values and variable type BOOLEAN should not use explicit comparisons to TRUE or FALSE Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_Ecc_ArmPkg_v1 ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c index 3b07d979182f..c03c1a462285 100644 --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c @@ -764,7 +764,7 @@ GetFileInfo ( UINTN ResultSize; UINTN Index; - if (Fcb->IsRoot == TRUE) { + if (Fcb->IsRoot) { ResultSize = SIZE_OF_EFI_FILE_INFO + sizeof(CHAR16); } else { NameSize = AsciiStrLen (Fcb->FileName) + 1; @@ -784,7 +784,7 @@ GetFileInfo ( // Fill in the structure Info->Size = ResultSize; - if (Fcb->IsRoot == TRUE) { + if (Fcb->IsRoot) { Info->FileName[0] = L'\0'; } else { for (Index = 0; Index < NameSize; Index++) { -- 2.17.1