From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.50.1608139365965543724 for ; Wed, 16 Dec 2020 09:22:46 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF2771FB; Wed, 16 Dec 2020 09:22:45 -0800 (PST) Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DA5C43F66E; Wed, 16 Dec 2020 09:22:44 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [PATCH v1 17/25] ArmPkg: Fix Ecc error 5007 in SemihostFs Date: Wed, 16 Dec 2020 17:21:52 +0000 Message-Id: <20201216172200.25846-18-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_Ecc_ArmPkg_v1 ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c index c03c1a462285..0468d242f7e4 100644 --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c @@ -90,8 +90,9 @@ AllocateFCB ( VOID ) { - SEMIHOST_FCB *Fcb = AllocateZeroPool (sizeof (SEMIHOST_FCB)); + SEMIHOST_FCB *Fcb; + Fcb = AllocateZeroPool (sizeof (SEMIHOST_FCB)); if (Fcb != NULL) { CopyMem (&Fcb->File, &gSemihostFsFile, sizeof (gSemihostFsFile)); Fcb->Signature = SEMIHOST_FCB_SIGNATURE; @@ -122,7 +123,7 @@ VolumeOpen ( OUT EFI_FILE **Root ) { - SEMIHOST_FCB *RootFcb = NULL; + SEMIHOST_FCB *RootFcb; if (Root == NULL) { return EFI_INVALID_PARAMETER; @@ -759,12 +760,13 @@ GetFileInfo ( OUT VOID *Buffer ) { - EFI_FILE_INFO *Info = NULL; - UINTN NameSize = 0; + EFI_FILE_INFO *Info; + UINTN NameSize; UINTN ResultSize; UINTN Index; if (Fcb->IsRoot) { + NameSize = 0; ResultSize = SIZE_OF_EFI_FILE_INFO + sizeof(CHAR16); } else { NameSize = AsciiStrLen (Fcb->FileName) + 1; -- 2.17.1