From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.70.1608139368532961739 for ; Wed, 16 Dec 2020 09:22:48 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 451E4D6E; Wed, 16 Dec 2020 09:22:48 -0800 (PST) Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 54CCE3F66E; Wed, 16 Dec 2020 09:22:47 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [PATCH v1 19/25] ArmPkg: Fix Ecc error 5007 in ArmDisassemblerLib Date: Wed, 16 Dec 2020 17:21:54 +0000 Message-Id: <20201216172200.25846-20-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_Ecc_ArmPkg_v1 ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c b/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c index 04b6c2cd21e0..1882163522d9 100644 --- a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c +++ b/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c @@ -158,7 +158,7 @@ DisassembleArmInstruction ( IN BOOLEAN Extended ) { - UINT32 OpCode = **OpCodePtr; + UINT32 OpCode; CHAR8 *Type, *Root; BOOLEAN I, P, U, B, W, L, S, H; UINT32 Rn, Rd, Rm; @@ -166,6 +166,8 @@ DisassembleArmInstruction ( UINT32 Index; UINT32 shift_imm, shift; + OpCode = = **OpCodePtr; + I = (OpCode & BIT25) == BIT25; P = (OpCode & BIT24) == BIT24; U = (OpCode & BIT23) == BIT23; -- 2.17.1