public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com
Cc: sami.mujawar@arm.com
Subject: [PATCH v1 25/25] ArmPkg: Fix Ecc error 5007 in DefaultExceptionHandlerLib
Date: Wed, 16 Dec 2020 17:22:00 +0000	[thread overview]
Message-ID: <20201216172200.25846-26-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com>

From: Pierre Gondois <Pierre.Gondois@arm.com>

This patch fixes the following Ecc reported error:
There should be no initialization of a variable as
part of its declaration

Fixing this error implies extracting the CpsrChar
array from CpsrString and making it a static variable.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_Ecc_ArmPkg_v1

 .../Arm/DefaultExceptionHandler.c             | 41 ++++++++++---------
 1 file changed, 22 insertions(+), 19 deletions(-)

diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
index fa9af8c410b9..ad205a5a1ebf 100644
--- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
+++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
@@ -2,7 +2,7 @@
   Default exception handler

   Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.<BR>
-  Copyright (c) 2012, ARM Ltd. All rights reserved.<BR>
+  Copyright (c) 2012 - 2020, Arm Ltd. All rights reserved.<BR>

   SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -34,6 +34,20 @@ typedef struct {
   CHAR8   Char;
 } CPSR_CHAR;

+STATIC CONST CPSR_CHAR mCpsrChar[] = {
+  { 31, 'n' },
+  { 30, 'z' },
+  { 29, 'c' },
+  { 28, 'v' },
+
+  { 9,  'e' },
+  { 8,  'a' },
+  { 7,  'i' },
+  { 6,  'f' },
+  { 5,  't' },
+  { 0,  '?' }
+};
+
 CHAR8 *
 GetImageName (
   IN  UINTN  FaultAddress,
@@ -45,7 +59,7 @@ GetImageName (
   Convert the Current Program Status Register (CPSR) to a string. The string is
   a defacto standard in the ARM world.

-  It is possible to add extra bits by adding them to CpsrChar array.
+  It is possible to add extra bits by adding them to mCpsrChar array.

   @param  Cpsr         ARM CPSR register value
   @param  ReturnStr    CPSR_STRING_SIZE byte string that contains string
@@ -61,25 +75,12 @@ CpsrString (
   UINTN     Index;
   CHAR8*    Str;
   CHAR8*    ModeStr;
-  CPSR_CHAR CpsrChar[] = {
-    { 31, 'n' },
-    { 30, 'z' },
-    { 29, 'c' },
-    { 28, 'v' },
-
-    { 9,  'e' },
-    { 8,  'a' },
-    { 7,  'i' },
-    { 6,  'f' },
-    { 5,  't' },
-    { 0,  '?' }
-  };

   Str = ReturnStr;

-  for (Index = 0; CpsrChar[Index].BIT != 0; Index++, Str++) {
-    *Str = CpsrChar[Index].Char;
-    if ((Cpsr & (1 << CpsrChar[Index].BIT)) != 0) {
+  for (Index = 0; mCpsrChar[Index].BIT != 0; Index++, Str++) {
+    *Str = mCpsrChar[Index].Char;
+    if ((Cpsr & (1 << mCpsrChar[Index].BIT)) != 0) {
       // Concert to upper case if bit is set
       *Str &= ~0x20;
     }
@@ -186,7 +187,9 @@ DefaultExceptionHandler (
   UINT32    DfsrStatus;
   UINT32    IfsrStatus;
   BOOLEAN   DfsrWrite;
-  UINT32    PcAdjust = 0;
+  UINT32    PcAdjust;
+
+  PcAdjust = 0;

   CharCount = AsciiSPrint (Buffer,sizeof (Buffer),"\n%a Exception PC at 0x%08x  CPSR 0x%08x ",
          gExceptionTypeString[ExceptionType], SystemContext.SystemContextArm->PC, SystemContext.SystemContextArm->CPSR);
--
2.17.1


  parent reply	other threads:[~2020-12-16 17:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 17:21 [PATCH v1 00/25] Fix Ecc reported errors in ArmPkg PierreGondois
2020-12-16 17:21 ` [PATCH v1 01/25] ArmPkg: Format header to fix Ecc crash in ArmMmuLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 02/25] ArmPkg: Fix Ecc error 3002 in CompilerIntrinsicsLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 03/25] ArmPkg: Fix Ecc error 3002 in OpteeLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 04/25] ArmPkg: Fix Ecc error 3002 in ArmMmuLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 05/25] ArmPkg: Fix Ecc error 3002 in TimerDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 06/25] ArmPkg: Fix Ecc error 3002 in MmCommunicationDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 07/25] ArmPkg: Fix Ecc error 3002 in CpuDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 08/25] ArmPkg: Fix Ecc error 3002 in SemihostFs PierreGondois
2020-12-16 17:21 ` [PATCH v1 09/25] ArmPkg: Fix Ecc error 3002 in ArmDisassemblerLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 10/25] ArmPkg: Fix Ecc error 3001 in SemihostFs PierreGondois
2020-12-16 17:21 ` [PATCH v1 11/25] ArmPkg: Fix Ecc error 5005 in CpuDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 12/25] ArmPkg: Fix Ecc error 5005 in ArmExceptionLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 13/25] ArmPkg: Fix Ecc error 5007 in CompilerIntrinsicsLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 14/25] ArmPkg: Fix Ecc error 5007 in ArmScmiDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 15/25] ArmPkg: Fix Ecc error 5007 in CpuDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 16/25] ArmPkg: Fix Ecc error 5007 in TimerDxe PierreGondois
2020-12-16 17:21 ` [PATCH v1 17/25] ArmPkg: Fix Ecc error 5007 in SemihostFs PierreGondois
2020-12-16 17:21 ` [PATCH v1 18/25] ArmPkg: Fix Ecc error 5007 in ArmCacheMaintenanceLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 19/25] ArmPkg: Fix Ecc error 5007 in ArmDisassemblerLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 20/25] ArmPkg: Fix Ecc error 5007 in ArmLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 21/25] ArmPkg: Fix Ecc error 5007 in ArmMmuLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 22/25] ArmPkg: Fix Ecc error 5007 in SemiHostingSerialPortLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 23/25] ArmPkg: Fix Ecc error 5007 in SemihostLib PierreGondois
2020-12-16 17:21 ` [PATCH v1 24/25] ArmPkg: Fix Ecc error 5007 in StandaloneMmMmuLib PierreGondois
2020-12-16 17:22 ` PierreGondois [this message]
2020-12-18 18:31 ` [edk2-devel] [PATCH v1 00/25] Fix Ecc reported errors in ArmPkg Sami Mujawar
2021-01-06 16:23 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216172200.25846-26-Pierre.Gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox