* [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH
@ 2020-12-16 6:29 Enze Zhu
0 siblings, 0 replies; 4+ messages in thread
From: Enze Zhu @ 2020-12-16 6:29 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao, Yuwei Chen
We had a build fail due to the hard coded MAX_LONG_FILE_PATH value.
We should use PATH_MAX if it is available.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---
BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Common/CommonLib.h
index e1cce985f7..0f05d88db2 100644
--- a/BaseTools/Source/C/Common/CommonLib.h
+++ b/BaseTools/Source/C/Common/CommonLib.h
@@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Common/UefiBaseTypes.h>
#include <Common/BuildVersion.h>
#include <assert.h>
+#ifndef _WIN32
+#include <limits.h>
+#endif
+
#define PRINTED_GUID_BUFFER_SIZE 37 // including null-termination
+#ifdef PATH_MAX
+#define MAX_LONG_FILE_PATH PATH_MAX
+#else
#define MAX_LONG_FILE_PATH 500
+#endif
#define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL)
#define MAX_UINT32 ((UINT32)0xFFFFFFFF)
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH
@ 2020-12-17 2:19 Enze Zhu
2020-12-18 11:09 ` Bob Feng
[not found] ` <1651CB07AB6014B1.25767@groups.io>
0 siblings, 2 replies; 4+ messages in thread
From: Enze Zhu @ 2020-12-17 2:19 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao, Yuwei Chen
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3032
We had a build fail due to the hard coded MAX_LONG_FILE_PATH value.
We should use PATH_MAX if it is available.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
---
BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Common/CommonLib.h
index e1cce985f7..0f05d88db2 100644
--- a/BaseTools/Source/C/Common/CommonLib.h
+++ b/BaseTools/Source/C/Common/CommonLib.h
@@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Common/UefiBaseTypes.h>
#include <Common/BuildVersion.h>
#include <assert.h>
+#ifndef _WIN32
+#include <limits.h>
+#endif
+
#define PRINTED_GUID_BUFFER_SIZE 37 // including null-termination
+#ifdef PATH_MAX
+#define MAX_LONG_FILE_PATH PATH_MAX
+#else
#define MAX_LONG_FILE_PATH 500
+#endif
#define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL)
#define MAX_UINT32 ((UINT32)0xFFFFFFFF)
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH
2020-12-17 2:19 [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH Enze Zhu
@ 2020-12-18 11:09 ` Bob Feng
[not found] ` <1651CB07AB6014B1.25767@groups.io>
1 sibling, 0 replies; 4+ messages in thread
From: Bob Feng @ 2020-12-18 11:09 UTC (permalink / raw)
To: Enze Zhu, devel@edk2.groups.io; +Cc: Liming Gao, Chen, Christine
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Enze Zhu <zhuenze@byosoft.com.cn>
Sent: Thursday, December 17, 2020 10:20 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3032
We had a build fail due to the hard coded MAX_LONG_FILE_PATH value.
We should use PATH_MAX if it is available.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
---
BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Common/CommonLib.h
index e1cce985f7..0f05d88db2 100644
--- a/BaseTools/Source/C/Common/CommonLib.h
+++ b/BaseTools/Source/C/Common/CommonLib.h
@@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include <Common/UefiBaseTypes.h> #include <Common/BuildVersion.h> #include <assert.h>
+#ifndef _WIN32
+#include <limits.h>
+#endif
+
#define PRINTED_GUID_BUFFER_SIZE 37 // including null-termination
+#ifdef PATH_MAX
+#define MAX_LONG_FILE_PATH PATH_MAX
+#else
#define MAX_LONG_FILE_PATH 500
+#endif
#define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL) #define MAX_UINT32 ((UINT32)0xFFFFFFFF)
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH
[not found] ` <1651CB07AB6014B1.25767@groups.io>
@ 2021-01-06 3:07 ` Bob Feng
0 siblings, 0 replies; 4+ messages in thread
From: Bob Feng @ 2021-01-06 3:07 UTC (permalink / raw)
To: devel@edk2.groups.io, Feng, Bob C, Enze Zhu; +Cc: Liming Gao, Chen, Christine
Created a PR: https://github.com/tianocore/edk2/pull/1299
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Friday, December 18, 2020 7:10 PM
To: Enze Zhu <zhuenze@byosoft.com.cn>; devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Enze Zhu <zhuenze@byosoft.com.cn>
Sent: Thursday, December 17, 2020 10:20 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3032
We had a build fail due to the hard coded MAX_LONG_FILE_PATH value.
We should use PATH_MAX if it is available.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
---
BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Common/CommonLib.h
index e1cce985f7..0f05d88db2 100644
--- a/BaseTools/Source/C/Common/CommonLib.h
+++ b/BaseTools/Source/C/Common/CommonLib.h
@@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include <Common/UefiBaseTypes.h> #include <Common/BuildVersion.h> #include <assert.h>
+#ifndef _WIN32
+#include <limits.h>
+#endif
+
#define PRINTED_GUID_BUFFER_SIZE 37 // including null-termination
+#ifdef PATH_MAX
+#define MAX_LONG_FILE_PATH PATH_MAX
+#else
#define MAX_LONG_FILE_PATH 500
+#endif
#define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL) #define MAX_UINT32 ((UINT32)0xFFFFFFFF)
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-06 3:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-17 2:19 [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH Enze Zhu
2020-12-18 11:09 ` Bob Feng
[not found] ` <1651CB07AB6014B1.25767@groups.io>
2021-01-06 3:07 ` [edk2-devel] " Bob Feng
-- strict thread matches above, loose matches on Subject: below --
2020-12-16 6:29 Enze Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox