From: "Leif Lindholm" <leif@nuviainc.com>
To: Abner Chang <abner.chang@hpe.com>
Cc: devel@edk2.groups.io, Andrew Fish <afish@apple.com>,
Laszlo Ersek <lersek@redhat.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Nickle Wang <nickle.wang@hpe.com>,
Peter O'Hanley <peter.ohanley@hpe.com>
Subject: Re: [PATCH v7 2/6] edk2: jansson submodule for edk2 JSON library
Date: Thu, 17 Dec 2020 12:42:37 +0000 [thread overview]
Message-ID: <20201217124237.GP1664@vanye> (raw)
In-Reply-To: <20201216031406.7136-3-abner.chang@hpe.com>
On Wed, Dec 16, 2020 at 11:14:02 +0800, Abner Chang wrote:
> Add git submodule "jansson" library, which is the open
> source project (https://github.com/akheron/jansson) used
> to manipulate JSON data structure. jansson library is
> wrapped as edk2 JsonLib and the use cases will be the
> edk2 Redfish feature drivers and edk2 port of libredfish
> (https://github.com/DMTF/libredfish).
> jansson open source project is under MIT license.
> (refer to ReadMe.rst under edk2).
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
Acked-by: Leif Lindholm <leif@nuviainc.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> ---
> .gitmodules | 3 +++
> ReadMe.rst | 1 +
> RedfishPkg/Library/JsonLib/jansson | 1 +
> 3 files changed, 5 insertions(+)
> create mode 160000 RedfishPkg/Library/JsonLib/jansson
>
> diff --git a/.gitmodules b/.gitmodules
> index c3a4e4aeca..0f06c09a29 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -17,3 +17,6 @@
> path = BaseTools/Source/C/BrotliCompress/brotli
> url = https://github.com/google/brotli
> ignore = untracked
> +[submodule "RedfishPkg/Library/JsonLib/jansson"]
> + path = RedfishPkg/Library/JsonLib/jansson
> + url = https://github.com/akheron/jansson
> diff --git a/ReadMe.rst b/ReadMe.rst
> index c3c8178373..b754378646 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -93,6 +93,7 @@ that are covered by additional licenses.
> - `MdeModulePkg/Library/BrotliCustomDecompressLib/brotli <https://github.com/google/brotli/blob/666c3280cc11dc433c303d79a83d4ffbdd12cc8d/LICENSE>`__
> - `MdeModulePkg/Universal/RegularExpressionDxe/oniguruma <https://github.com/kkos/oniguruma/blob/abfc8ff81df4067f309032467785e06975678f0d/COPYING>`__
> - `UnitTestFrameworkPkg/Library/CmockaLib/cmocka <https://git.cryptomilk.org/projects/cmocka.git/tree/COPYING?h=cmocka-1.1.5&id=f5e2cd77c88d9f792562888d2b70c5a396bfbf7a>`__
> +- `RedfishPkg/Library/JsonLib/jansson <https://github.com/akheron/jansson/blob/2882ead5bb90cf12a01b07b2c2361e24960fae02/LICENSE>`__
>
> The EDK II Project is composed of packages. The maintainers for each package
> are listed in `Maintainers.txt <Maintainers.txt>`__.
> diff --git a/RedfishPkg/Library/JsonLib/jansson b/RedfishPkg/Library/JsonLib/jansson
> new file mode 160000
> index 0000000000..e9ebfa7e77
> --- /dev/null
> +++ b/RedfishPkg/Library/JsonLib/jansson
> @@ -0,0 +1 @@
> +Subproject commit e9ebfa7e77a6bee77df44e096b100e7131044059
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-12-17 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 3:14 [PATCH v7 0/6] jansson edk2 port Abner Chang
2020-12-16 3:14 ` [PATCH v7 1/6] RedfishPkg/Ucs2Utf8lib: UCS2 to UFT8 manipulation library Abner Chang
2020-12-17 12:41 ` Leif Lindholm
2020-12-16 3:14 ` [PATCH v7 2/6] edk2: jansson submodule for edk2 JSON library Abner Chang
2020-12-17 12:42 ` Leif Lindholm [this message]
2020-12-16 3:14 ` [PATCH v7 3/6] RedfishPkg/CrtLib: C runtime library Abner Chang
2020-12-17 12:41 ` Leif Lindholm
2020-12-16 3:14 ` [PATCH v7 4/6] RedfishPkg/library: EDK2 port of jansson library Abner Chang
2020-12-17 12:39 ` Leif Lindholm
2020-12-17 14:40 ` [edk2-devel] " Abner Chang
2020-12-17 17:52 ` Leif Lindholm
2020-12-18 0:27 ` Abner Chang
2020-12-16 3:14 ` [PATCH v7 5/6] RedfishPkg: Add EDK2 port of jansson library to build Abner Chang
2020-12-16 3:14 ` [PATCH v7 6/6] .pytool: Add required submodule for JsonLib Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217124237.GP1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox