From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.41]) by mx.groups.io with SMTP id smtpd.web09.7687.1608210354709164207 for ; Thu, 17 Dec 2020 05:05:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=p1KdOvtu; spf=pass (domain: arm.com, ip: 40.107.21.41, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CD6fG+fTe4taohcsFwCnxmrlapsmGnZJ573YUPlhPU4=; b=p1KdOvtuRfA3wde/3T2OyW+CDH932qWgKyBVkn7x4v/apVGixzvx4xbMCPLSZFTdi8wanzsthdfTRpOd0ICYCd/AekOxftrN24Twk+Fj9w/4Eew2XvHEraLESfG513fOgnQWnWJvvizyDmzAF8UMbDzTdB6Tsc2tZpqSRleEvqQ= Received: from DB6P195CA0013.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::23) by VI1PR08MB5358.eurprd08.prod.outlook.com (2603:10a6:803:13c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Thu, 17 Dec 2020 13:05:51 +0000 Received: from DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::5f) by DB6P195CA0013.outlook.office365.com (2603:10a6:4:cb::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Thu, 17 Dec 2020 13:05:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT029.mail.protection.outlook.com (10.152.20.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:51 +0000 Received: ("Tessian outbound 8b6e0bb22f1c:v71"); Thu, 17 Dec 2020 13:05:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 150458c8ddef94b0 X-CR-MTA-TID: 64aa7808 Received: from c0b82529683a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 524FAA8B-3AE2-48C4-96B0-1B450996B6D8.1; Thu, 17 Dec 2020 13:05:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c0b82529683a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Dec 2020 13:05:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SEZeZ3iBvaibGQgJS2OuZ2RNsHAYhfV/5DKRStmfVEpf9qG1zk77Gj5L0sb7aHGbF8r/SPo2gPUD6XWrfvLV68yv1eZ8M8qggH3od7EVVIN+63vxr2wZQcsG4iDeM0Ek/rP4oqg5ADuzsbzL/x57IPiXEfXLrIMCxK+pDt2NWseoiH+vTdG6bAq76Ek1SuJRQ7rpygQoMPe6XfGw3/i9In6uyBNtVCCyUPnRXgDeu2LkTT5RNR8/+XtloKW6OlfHUVTaNtTE/MrIKzl1zWpRZYFVUKhqqMkoWURhD/i9VFffD5rXa4wFRdzfSDqL/eWcU2Hprkk7UVDKMXG6IWEcQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CD6fG+fTe4taohcsFwCnxmrlapsmGnZJ573YUPlhPU4=; b=hW7sg6Rna18rZ6Adf54pYAi1yh0AixWmf/EZbzPRkW+TPoB8zqcSsXox6CvLBmrvEIoSBkcNue/URA6Q1sF1QUpXkXUcgixoQgIoWFtKpDbTD4fbK3n/mOiFZiE/OaFPOFR2gNEqMFBhLROHHMRkUyBCZW36cboM4BEXxlg3czsR8nl493HqcXYwaxfQCqIpUNCFDE8XlUuLVrUlVa/ddOb+z1laObQWTJwvcjOuhq8NjJAymcMS81CyIyAUzLRjAS+h5VbsmlJQ37RxnTs705relDW+BGQwmTGYOhNH1LPaYIf/9jDvhxgicwdEL0akBn0kIVXDeFuHKXyLVyeK2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CD6fG+fTe4taohcsFwCnxmrlapsmGnZJ573YUPlhPU4=; b=p1KdOvtuRfA3wde/3T2OyW+CDH932qWgKyBVkn7x4v/apVGixzvx4xbMCPLSZFTdi8wanzsthdfTRpOd0ICYCd/AekOxftrN24Twk+Fj9w/4Eew2XvHEraLESfG513fOgnQWnWJvvizyDmzAF8UMbDzTdB6Tsc2tZpqSRleEvqQ= Received: from DB9PR06CA0020.eurprd06.prod.outlook.com (2603:10a6:10:1db::25) by VE1PR08MB5744.eurprd08.prod.outlook.com (2603:10a6:800:1af::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.19; Thu, 17 Dec 2020 13:05:12 +0000 Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1db:cafe::fb) by DB9PR06CA0020.outlook.office365.com (2603:10a6:10:1db::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Thu, 17 Dec 2020 13:05:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:12 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Thu, 17 Dec 2020 13:05:10 +0000 Received: from E107187.Arm.com (10.57.33.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Thu, 17 Dec 2020 13:05:10 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v2 00/26] Enable Core CI support for StandaloneMmPkg Date: Thu, 17 Dec 2020 13:04:43 +0000 Message-ID: <20201217130509.12568-1-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25bf49ec-6998-41a8-d20d-08d8a28c7b0f X-MS-TrafficTypeDiagnostic: VE1PR08MB5744:|VI1PR08MB5358: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: B7yB+t6MER0VTPXTr5PLgBMwjufYICNSVbFks1fNGlRuNrnoJAcikJIkLjTagJ3tS3Xb0vQcqf0NrddpZVpanjBiD+Mt1jky9uIvNCbLTjxYlm4c2AVdzCT2duNtSNgNve+V4kSpYc1W37JpGhaK4ne7EFlbn31/gtHspYwU+ZK8N+dHU/bktndqezQ59sFoj1iarr2WLsIGXBmGxhvFSQFwAj0FDBhu74Ap2hwhb8+6fxaDBx/RIrju46F8yrvQaKnUe3YCEyT4OfgoCmM/U4Fa6LLJKY1J/IPKC1EoTMEVhmt2215Xg9T3XhIsyO3Cl9sWcpcunxpr+qzR4KII6duiWhJzhdXaf1QQVfLFjFxJHRnmVLLEA1nVhYQYtezNA1YOy054SeJVwC6POEXEgsOOsY8G2iFRc3fhWs1As8TQCSogYot2tRBRsvTsu07FLiz8CzzkLARLdihEq48nIBWMKSumHVFc5Ucu73APrWA= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(346002)(39860400002)(376002)(396003)(136003)(46966005)(316002)(86362001)(83380400001)(1076003)(966005)(2906002)(82740400003)(478600001)(186003)(82310400003)(4326008)(426003)(26005)(6916009)(54906003)(8936002)(7696005)(356005)(70586007)(2616005)(81166007)(36756003)(44832011)(70206006)(47076004)(8676002)(336012)(5660300002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5744 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 104b520b-91b7-4909-fdc8-08d8a28c639c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AUSI8RggY8KTVLaBwpV5ifovqPFWqq8u8/3UEKs6of5d0fu6r/kyLQ9FukdGJZD304TINhm3cUnpPw0mcIo7ljpgVHGr0ASC3PFsaZALZLDbva3q1wduQN4TSkqhwVms/IOv7+plB3kCW+Jci8G1IAmM04rpJKlniTNlYzsY4VwUGeSANVBrSiSizZoWYZOZ9MIO/nu3+Yw6Fe0Y7iw5rWM9awpvNkcbvXJ+Z/X2lICExE0ZOAJYqWQxWpA21h+gbw917p2I48d+kd2k/Wg9byVykV9Sw42P4nfpdGcf4J3aOOyiWKLvSFCcF4K+hq/5lexfL7Z9EQiolRo7+bJqA3i8/WgJh+cQOInmpSVqTfbt/nTKX721cQjw5OLCOSQnMltVuZQCX5+hqY8tvg33wSdxLvWNBMIziDQ4VdczMf/Y7hWBO7S3JEAecxVBbw3vQFgi/YTyYE5Mchssuv9EUtZlKtCIUr8o7G7/1MpYwZg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(396003)(346002)(136003)(39860400002)(376002)(46966005)(2906002)(6666004)(47076004)(26005)(186003)(7696005)(966005)(36756003)(70586007)(82310400003)(86362001)(8676002)(54906003)(4326008)(70206006)(478600001)(426003)(2616005)(6916009)(336012)(83380400001)(1076003)(8936002)(5660300002)(316002)(82740400003)(81166007)(44832011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2020 13:05:51.6570 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25bf49ec-6998-41a8-d20d-08d8a28c7b0f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5358 Content-Type: text/plain The EDKII Core CI runs the ECC tool that checks for good coding practices and the coding standard. This patch series fixes the ECC errors reported in the StandaloneMmPkg and enables support for EDKII Core CI. This v2 series: - addresses the feedback for the following patches: PATCH 24: StandaloneMmPkg: Add EDK2 Core CI support Ref: https://edk2.groups.io/g/devel/topic/78838418 PATCH 25:. .azurepipelines: Add StandaloneMmPkg to CI matrix Ref: https://edk2.groups.io/g/devel/message/68603 - Introduces a new PATCH 23: 'StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec' - There is no code change for Patches 1 to 22 and 26 since the v1 series. The changes can be seen at: https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v2 Sami Mujawar (26): StandaloneMmPkg: Add library header files to DEC StandaloneMmPkg: Add library files to DSC StandaloneMmPkg: Fix spell check reported errors StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu StandaloneMmPkg: Fix ECC error 4002 in FwVol helper StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec StandaloneMmPkg: Add EDK2 Core CI support .azurepipelines: Add StandaloneMmPkg to CI matrix .pytool: CI Settings to support StandaloneMmPkg .azurepipelines/templates/pr-gate-build-job.yml | 2 +- .pytool/CISettings.py | 1 + .pytool/Readme.md | 2 +- StandaloneMmPkg/Core/Dependency.c | 6 +- StandaloneMmPkg/Core/Dispatcher.c | 49 ++++++------ StandaloneMmPkg/Core/FwVol.c | 36 +++++---- StandaloneMmPkg/Core/Locate.c | 6 +- StandaloneMmPkg/Core/Mmi.c | 4 +- StandaloneMmPkg/Core/Pool.c | 6 +- StandaloneMmPkg/Core/StandaloneMmCore.c | 37 ++++++--- StandaloneMmPkg/Core/StandaloneMmCore.h | 12 +-- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c | 56 ++++++++++--- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c | 34 ++++++-- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h | 31 +++++++- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 9 +-- StandaloneMmPkg/Include/Guid/MmCoreData.h | 6 +- StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h | 47 ++++++----- StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h | 4 +- StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h | 6 +- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c | 6 +- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c | 53 +++++++++++- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 32 +++++--- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf | 3 +- StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c | 6 +- StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf | 4 +- StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c | 10 +-- StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c | 4 +- StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf | 4 +- StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 84 ++++++++++++++++++++ StandaloneMmPkg/StandaloneMmPkg.dec | 20 ++++- StandaloneMmPkg/StandaloneMmPkg.dsc | 15 +++- 31 files changed, 439 insertions(+), 156 deletions(-) create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'