From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <ard.biesheuvel@arm.com>,
<jiewen.yao@intel.com>, <thomas.abraham@arm.com>,
<Sughosh.Ganu@arm.com>, <Matteo.Carlini@arm.com>,
<Ben.Adderson@arm.com>, <nd@arm.com>
Subject: [PATCH v2 09/26] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
Date: Thu, 17 Dec 2020 13:04:52 +0000 [thread overview]
Message-ID: <20201217130509.12568-10-sami.mujawar@arm.com> (raw)
In-Reply-To: <20201217130509.12568-1-sami.mujawar@arm.com>
Fix ECC error "[5007] There should be no initialization of a variable
as part of its declaration Variable."
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
---
Notes:
v2:
- No code change. Resending patch with v2 series. [SAMI]
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
index 9738e8bd60149efb45ef1b66139e0cec38b6c1fe..7620a65c7e3bbd647961942f5b30d3d834107f70 100644
--- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
+++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
@@ -65,8 +65,8 @@ PiMmStandaloneArmTfCpuDriverEntry (
IN UINTN NsCommBufferAddr
)
{
- EFI_MM_COMMUNICATE_HEADER *GuidedEventContext = NULL;
- EFI_MM_ENTRY_CONTEXT MmEntryPointContext = {0};
+ EFI_MM_COMMUNICATE_HEADER *GuidedEventContext;
+ EFI_MM_ENTRY_CONTEXT MmEntryPointContext;
EFI_STATUS Status;
UINTN NsCommBufferSize;
@@ -107,6 +107,7 @@ PiMmStandaloneArmTfCpuDriverEntry (
return EFI_ACCESS_DENIED;
}
+ GuidedEventContext = NULL;
// Now that the secure world can see the normal world buffer, allocate
// memory to copy the communication buffer to the secure world.
Status = mMmst->MmAllocatePool (
@@ -127,6 +128,8 @@ PiMmStandaloneArmTfCpuDriverEntry (
// Stash the pointer to the allocated Event Context for this CPU
PerCpuGuidedEventContext[CpuNumber] = GuidedEventContext;
+ ZeroMem (&MmEntryPointContext, sizeof (EFI_MM_ENTRY_CONTEXT));
+
MmEntryPointContext.CurrentlyExecutingCpu = CpuNumber;
MmEntryPointContext.NumberOfCpus = mMpInformationHobData->NumberOfProcessors;
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2020-12-17 13:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 13:04 [PATCH v2 00/26] Enable Core CI support for StandaloneMmPkg Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 01/26] StandaloneMmPkg: Add library header files to DEC Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 02/26] StandaloneMmPkg: Add library files to DSC Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 03/26] StandaloneMmPkg: Fix spell check reported errors Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 04/26] StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 05/26] StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 06/26] StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 07/26] StandaloneMmPkg: Fix ECC error 4002 in FwVol helper Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 08/26] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint Sami Mujawar
2020-12-17 13:04 ` Sami Mujawar [this message]
2020-12-17 13:04 ` [PATCH v2 10/26] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 11/26] StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 12/26] StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 13/26] StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 14/26] StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 15/26] StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint Sami Mujawar
2020-12-17 13:04 ` [PATCH v2 16/26] StandaloneMmPkg: Fix ECC error 9003 " Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 17/26] StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 18/26] StandaloneMmPkg: Fix ECC error 9001 " Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 19/26] StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 20/26] StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 21/26] StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 22/26] StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 23/26] StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 24/26] StandaloneMmPkg: Add EDK2 Core CI support Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 25/26] .azurepipelines: Add StandaloneMmPkg to CI matrix Sami Mujawar
2020-12-17 13:05 ` [PATCH v2 26/26] .pytool: CI Settings to support StandaloneMmPkg Sami Mujawar
2020-12-24 1:34 ` 回复: [edk2-devel] [PATCH v2 00/26] Enable Core CI support for StandaloneMmPkg gaoliming
2021-01-04 12:50 ` [edk2-devel] " Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217130509.12568-10-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox