From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.48]) by mx.groups.io with SMTP id smtpd.web12.7700.1608210349484653863 for ; Thu, 17 Dec 2020 05:05:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=TihWeDcY; spf=pass (domain: arm.com, ip: 40.107.5.48, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=miLKIEy7+Nbu5kj8/XqoPkfaGNwKBko+0VhBzkNLEsE=; b=TihWeDcY0S+IuKNF+HZGZhigfuyK8yfObpCmy7jwQljOTfFE1QAwJEv0c/XhmvcZlMrK0tBQj6pqrMbz79QzFkj6oiVgyVI97fU/96jG/G/ZEm9RguUSFGlVMaWAbHQxjD9BWauhoVxAY+6r2V7kfPzeWAVa4tFGcbajQHBHdFg= Received: from DB6P195CA0022.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::32) by AM6PR08MB4658.eurprd08.prod.outlook.com (2603:10a6:20b:c4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.13; Thu, 17 Dec 2020 13:05:46 +0000 Received: from DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::9a) by DB6P195CA0022.outlook.office365.com (2603:10a6:4:cb::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Thu, 17 Dec 2020 13:05:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT029.mail.protection.outlook.com (10.152.20.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:46 +0000 Received: ("Tessian outbound 8b6e0bb22f1c:v71"); Thu, 17 Dec 2020 13:05:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c6049fb9715c48f6 X-CR-MTA-TID: 64aa7808 Received: from 4d006a0e2978.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F4D471AA-2195-4579-87FC-61D429259FF4.1; Thu, 17 Dec 2020 13:05:39 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4d006a0e2978.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Dec 2020 13:05:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=giFjnWTjaOnFy9+ozeK8T071Wbsj+zgm62IwVvbHPqJjtAHNBJXn+LqpHeHvrgfgoI2X8iKRw651xVxSxvYXaDsnaZferkdK54maWTdlrAmEyjwsloneGn0csVfG4AK8/wbnW4IRm2uKRIcNVlqruYcJuZh48vSLiQixSRYc8nTvpt8pboCozOyQGPIgavNGBRpdzBohJ6wIYgjnRpvMYOeO2Pp5VUPNMceCAzgGUywgVNZFx2ZCEeuseTE+qwTNyns578NBY/Y8EP+Ux01cELHcvZtIftkflMc2GXR1jV/AR3jCd3OdRRTcGsl11oDFzLWO4DV/lnrt+6XK0R0Y0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=miLKIEy7+Nbu5kj8/XqoPkfaGNwKBko+0VhBzkNLEsE=; b=m9CEO70uGiGY0gRa+o+grJ0YLoFbG2/LnXtilDMPXk0tcWpcCvsn3RPQXPgD4xFLR8MQYSRTcDazv9XZCP8I/TLQJlluPfBYfiJnghFTC2RWC+wZbkWYj8fIK68HyVzQOF3oV2AL+Imx9WqkfgybbwF+9H33+yehR8EwtBUEUeQbikADGglaM+2upFZeQxX/SXzOjdWDPjonDSzqKyC1ktrX1hJcO4A2GNG7XLPIhdKoL3sbpE34FXE7em/MBIqCcMKH+ClXtAmbNvuYPD50MPWx8Hg+LbKuCBRcqOefvDmjPBcw70zOCYVjt91VPx3hYQgIfU+fvlvt5d5KcZ1KtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=miLKIEy7+Nbu5kj8/XqoPkfaGNwKBko+0VhBzkNLEsE=; b=TihWeDcY0S+IuKNF+HZGZhigfuyK8yfObpCmy7jwQljOTfFE1QAwJEv0c/XhmvcZlMrK0tBQj6pqrMbz79QzFkj6oiVgyVI97fU/96jG/G/ZEm9RguUSFGlVMaWAbHQxjD9BWauhoVxAY+6r2V7kfPzeWAVa4tFGcbajQHBHdFg= Received: from DB6PR0301CA0096.eurprd03.prod.outlook.com (2603:10a6:6:30::43) by DB6PR0801MB2021.eurprd08.prod.outlook.com (2603:10a6:4:79::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.24; Thu, 17 Dec 2020 13:05:36 +0000 Received: from DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::d1) by DB6PR0301CA0096.outlook.office365.com (2603:10a6:6:30::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Thu, 17 Dec 2020 13:05:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT014.mail.protection.outlook.com (10.152.20.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:36 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Thu, 17 Dec 2020 13:05:19 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Thu, 17 Dec 2020 13:05:18 +0000 Received: from E107187.Arm.com (10.57.33.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Thu, 17 Dec 2020 13:05:18 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v2 12/26] StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore Date: Thu, 17 Dec 2020 13:04:55 +0000 Message-ID: <20201217130509.12568-13-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20201217130509.12568-1-sami.mujawar@arm.com> References: <20201217130509.12568-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 96e6547c-0b48-44a7-382e-08d8a28c77e1 X-MS-TrafficTypeDiagnostic: DB6PR0801MB2021:|AM6PR08MB4658: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: do7jwd1UztPyBaQa5tPu96l1brgggn43OWTtfOMUk7185oDDVZ+6loupgAJi8hIMpzlIubP+sv+b3W/IgnBhn3LYn05uk5kNFNuUluUIHSuXCPhgNZhdZ5s0i/g8vPEcYZivcWz3+ixoSPiXO3IArSj5qWc+2Sf6jUFPJvZR5q8/J3nW+A+wrGByktyuY3gky0sTOBT7pBiyznyIOwhSIEDTDe4lfsj0xgXu6J5xtQMv708Gc9JGEwP0gExDronV2G/9ceiuu9B9rgpA7AOnlgiyvsM9hXpePn74o4KMkLdhugBxp12WXhTqZhFLKYKVIaozg+FGIHuvMCaz3gScOiZzqwh8oSvmoyPHQtZbBegJHNR8mkSiKIJVjEhOETTaRvx9I3VxNL2dazYd0YKvuw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(136003)(346002)(39850400004)(396003)(376002)(46966005)(36756003)(7696005)(44832011)(1076003)(8936002)(2906002)(6916009)(478600001)(47076004)(6666004)(316002)(54906003)(426003)(81166007)(5660300002)(83380400001)(70206006)(4326008)(82310400003)(82740400003)(86362001)(8676002)(26005)(70586007)(186003)(2616005)(356005)(336012);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2021 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9d7d58f5-0654-4995-c555-08d8a28c7239 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y4KOVDY96LuovqIF1bwtH0FPeIhqiMLzMuavtzuX/YcM7TZP219qdSkTGC4bzX+Hh8IOxWKCgHDDCcwo7NArwzFkTzH5bUALDmOhhKwWKnmGHiMNLn1GSSQJ91+J2GUpFmFVlEM0mAD91FDIQCoBkhR+Cki3j72iV3pHmleJTBhSfNpLjEA37hufF6ZRMW6eNOK8QUzhsGAM6fLKuYFVcWh9JZGipsgVP7l7VFoA04b8nHxPiHBQ2ixgh9WBraDCE9B3avjWDO7Qg3j9lxmgXHctlTFOII0d49D4Jn0vaq9S5fyRpgb00kjpUIwdzYMwkoSNp1vO6cZHFT0LtDXswT2SIXMKp2vz9g2mnsxRFhdL4ah+42Ast2qmVD8Igi14odMhLn7qmEO27aFEL0JIlg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(376002)(39850400004)(346002)(136003)(396003)(46966005)(8676002)(81166007)(70206006)(4326008)(2906002)(70586007)(8936002)(44832011)(26005)(2616005)(47076004)(186003)(426003)(7696005)(336012)(6666004)(82310400003)(1076003)(83380400001)(86362001)(316002)(478600001)(6916009)(54906003)(5660300002)(36756003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2020 13:05:46.3225 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 96e6547c-0b48-44a7-382e-08d8a28c77e1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4658 Content-Type: text/plain Add doxygen style function documentation headers to fix the ECC reported errors: - [4002] Function header doesn't exist. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5. Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Core/StandaloneMmCore.c | 23 +++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c b/StandaloneMmPkg/Core/StandaloneMmCore.c index 803d7605ece7f6a3400866a04e39acf74cda8144..b04a9f985c6ecc601a6d7caf8fd433a1d4cf73c4 100644 --- a/StandaloneMmPkg/Core/StandaloneMmCore.c +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c @@ -414,6 +414,15 @@ MmEntryPoint ( DEBUG ((DEBUG_INFO, "MmEntryPoint Done\n")); } +/** Register the MM Entry Point provided by the MM Core with the + MM Configuration protocol. + + @param [in] Protocol Pointer to the protocol. + @param [in] Interface Pointer to the MM Configuration protocol. + @param [in] Handle Handle. + + @retval EFI_SUCCESS Success. +**/ EFI_STATUS EFIAPI MmConfigurationMmNotify ( @@ -448,6 +457,12 @@ MmConfigurationMmNotify ( return EFI_SUCCESS; } +/** Returns the HOB list size. + + @param [in] HobStart Pointer to the start of the HOB list. + + @retval Size of the HOB list. +**/ UINTN GetHobListSize ( IN VOID *HobStart @@ -475,12 +490,10 @@ GetHobListSize ( Note: This function is called for both DXE invocation and MMRAM invocation. - @param ImageHandle The firmware allocated handle for the EFI image. - @param SystemTable A pointer to the EFI System Table. - - @retval EFI_SUCCESS The entry point is executed successfully. - @retval Other Some error occurred when executing this entry point. + @param HobStart Pointer to the start of the HOB list. + @retval EFI_SUCCESS Success. + @retval EFI_UNSUPPORTED Unsupported operation. **/ EFI_STATUS EFIAPI -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'