From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (EUR03-AM5-obe.outbound.protection.outlook.com [40.107.3.67]) by mx.groups.io with SMTP id smtpd.web09.7686.1608210348578813180 for ; Thu, 17 Dec 2020 05:05:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=l4lrXcQt; spf=pass (domain: arm.com, ip: 40.107.3.67, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=658CuGcpHRV6IZe5g/DSRczRzi6T14Gr05uC7mSAusU=; b=l4lrXcQtLHL1wWU5rSfwajDTPRAZ3MiKDRNr0PDzP4iurEn4vdjsdZClg9DXo8Odydj9b7PJxRhwuYTkreMxU69RayL8Rp+fLjycm1j/CgF2Op6XNmM441rd1nc7YMklp2zSaZ+yXaYsk1sItZbGfxA+98UKyInC6LgC56TWkKM= Received: from DB6PR07CA0175.eurprd07.prod.outlook.com (2603:10a6:6:43::29) by DBBPR08MB4904.eurprd08.prod.outlook.com (2603:10a6:10:f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.15; Thu, 17 Dec 2020 13:05:45 +0000 Received: from DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::73) by DB6PR07CA0175.outlook.office365.com (2603:10a6:6:43::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.9 via Frontend Transport; Thu, 17 Dec 2020 13:05:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT046.mail.protection.outlook.com (10.152.21.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:44 +0000 Received: ("Tessian outbound 76bd5a04122f:v71"); Thu, 17 Dec 2020 13:05:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: dcab9a9c3e3359a1 X-CR-MTA-TID: 64aa7808 Received: from 58bbdf0c2937.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 623B0353-6D1A-40A1-8510-024191B1520A.1; Thu, 17 Dec 2020 13:05:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 58bbdf0c2937.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Dec 2020 13:05:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QhwkQWVnlSkv5Y6C5ScVethxhKK4pD/yJmsw0Q75xhO/O9TbmGbMk3HnsBbcMjbk0bwLFVuO4H5KVwdOXmC56uJuaveIt0rnciJwttxwrBBz63I8OgSmsEsvzO8QeAO4Ug+G00ccdDU2hUhtDYjLZe8mylsj1R1uJP/PZC0lGkkgReXDFv7XU6+GimPCKeDkWATLuSQ5Cs0S3PqcF/idKlAp1UrWHMtzaXIwklAKLlJwaCQ/zqie3NLM/he3bKcfjRzAA9MovR92jI4i2iSoLBUWELs+5HU4PD6IZ8jAM+E3D6MMnDosVd2tWQx/jYK0oNtLdm5tNp3hQckDJdAsOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=658CuGcpHRV6IZe5g/DSRczRzi6T14Gr05uC7mSAusU=; b=mjHc1OPW3ln/8Hfl7pyacWYSyGnilcjKO/tllqrzP4xS/e+9XRLUoC2eWphjUZ2cgMhezEARdDna7huRqBJqVYAFvaLrKrfIYN9KItH33Nx93thLKZw9D9LaA2xIEwPWM+nVtq+co01oSyUNdWa5XnbnLR/7mfRNrJj0Hy1p6v8GZa9lfqZXFYiuJlsVYx75gJZyTniYfnYAXc1Sv+L6cVIgeqlVrYWt9VlQHnuqM/+cstYzsLCKNYTdB4Eh1ox6N1cLO1nP+1TyBCzQWg9ckHV+jVVlBA302Sgq13ZrSOGG4UG6b/Yt2+gDKkxXLP51+hgo4fT+LljXkEEWWmR95Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=658CuGcpHRV6IZe5g/DSRczRzi6T14Gr05uC7mSAusU=; b=l4lrXcQtLHL1wWU5rSfwajDTPRAZ3MiKDRNr0PDzP4iurEn4vdjsdZClg9DXo8Odydj9b7PJxRhwuYTkreMxU69RayL8Rp+fLjycm1j/CgF2Op6XNmM441rd1nc7YMklp2zSaZ+yXaYsk1sItZbGfxA+98UKyInC6LgC56TWkKM= Received: from DB9PR01CA0006.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::11) by DBAPR08MB5751.eurprd08.prod.outlook.com (2603:10a6:10:1a0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Thu, 17 Dec 2020 13:05:37 +0000 Received: from DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d8:cafe::b3) by DB9PR01CA0006.outlook.office365.com (2603:10a6:10:1d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.18 via Frontend Transport; Thu, 17 Dec 2020 13:05:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT061.mail.protection.outlook.com (10.152.21.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:37 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Thu, 17 Dec 2020 13:05:20 +0000 Received: from E107187.Arm.com (10.57.33.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Thu, 17 Dec 2020 13:05:19 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v2 15/26] StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint Date: Thu, 17 Dec 2020 13:04:58 +0000 Message-ID: <20201217130509.12568-16-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20201217130509.12568-1-sami.mujawar@arm.com> References: <20201217130509.12568-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 564e863b-e449-4344-3f80-08d8a28c7713 X-MS-TrafficTypeDiagnostic: DBAPR08MB5751:|DBBPR08MB4904: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6FW0NTOCRYIGj6iLLsQn8WQD7rDxAP9ToWAVguWntW0UyFnctYtrbg9syfWy1rJ7uPsJllpePY4CEQ95GyuWZmD4Omgxkj2Zhrv+ipIpNcTUTIPdbIWok/nEAVIO3p8Vlboo2dBC0Zgx7/W6fZJQIPtMT64SBZGuoFqSTPyi20HLIOfyx5ckYq7m6PW1Z1bB15GS8YarjSgCnl9aDHyFaXHaWPEX1aw2QZ3nwCyZijiSBksGDyoYGbgKamuc3PRYcJC0IKNRCvBMGAqQHX7QdCet6JKGLUeWNU1xexmw3tPYnByvXkqSStJA3GAYEN2WN+Th6ksDfjkodlaEzr3XQtB46IoLMIaFKxdesxb98yflVp4MOiFrLKHsquprZVgtRMNNmiWzpGA62m0uxou9pA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(376002)(396003)(346002)(136003)(39860400002)(46966005)(86362001)(316002)(8936002)(7696005)(8676002)(5660300002)(82310400003)(336012)(1076003)(6916009)(2906002)(2616005)(426003)(44832011)(186003)(478600001)(81166007)(54906003)(70586007)(26005)(356005)(83380400001)(82740400003)(47076004)(4326008)(36756003)(6666004)(70206006);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5751 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 292b1841-282f-4dba-55e5-08d8a28c729c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q3hK2KdYoAYHKj4IAWKH6XjeiNzzkp29WgoAGGHaKYqjgZCAJVVwmjUqdLY2M9sCCbEey2qZis1xMBZKRZKc6vzTuJfCx4eDmlyn8UQB6Wpy7cVYHzaSjobSf2gYtrqwbi+4yNXKsfOE1aXBrgocWK+swDyIMq61RnzQUkjbt/hGIj0ip7DnXjZoZWAzHpJY+FkBedwRmJOfRhdMk/trnHEGaK70b6pl5AF5ia8Eq5d8k1yaLY8ed2Ht2tlP3YolScDOtNaSct6og+JVp4/JeUv75Fgmh45ZnvuBJ8qOnofZK2CRJzkJS3c+EFjcSJKszB2+5AlP0iFn6nKd41ja/L5MYGkaflMlvtCvbdcuex62fstr9INj68GfBjagEHbzzgUXWkJC6wvsj22inRZ8gA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(346002)(376002)(396003)(136003)(39850400004)(46966005)(70206006)(82310400003)(47076004)(36756003)(70586007)(83380400001)(5660300002)(316002)(426003)(2616005)(54906003)(7696005)(8936002)(6916009)(4326008)(478600001)(336012)(82740400003)(86362001)(26005)(1076003)(6666004)(8676002)(186003)(44832011)(2906002)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2020 13:05:44.7235 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 564e863b-e449-4344-3f80-08d8a28c7713 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4904 Content-Type: text/plain Fix the ECC reported error "[9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 in Comment". Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h | 13 ++++++++----- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c | 6 ++++-- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 7 ++++--- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h b/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h index 34c43897dded9aebe1470f2dbfe96b93590a9e45..b176e56e789b0bc766e48a6083512a9d0ae3ebc3 100644 --- a/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h +++ b/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h @@ -140,8 +140,9 @@ LocateStandaloneMmCorePeCoffData ( Use the boot information passed by privileged firmware to populate a HOB list suitable for consumption by the MM Core and drivers. - @param CpuDriverEntryPoint Address of MM CPU driver entrypoint - @param PayloadBootInfo Boot information passed by privileged firmware + @param [in, out] CpuDriverEntryPoint Address of MM CPU driver entrypoint + @param [in] PayloadBootInfo Boot information passed by privileged + firmware **/ VOID * @@ -155,9 +156,11 @@ CreateHobListFromBootInfo ( /** The entry point of Standalone MM Foundation. - @param SharedBufAddress Pointer to the Buffer between SPM and SP. - @param cookie1. - @param cookie2. + @param [in] SharedBufAddress Pointer to the Buffer between SPM and SP. + @param [in] SharedBufSize Size of the shared buffer. + @param [in] cookie1 Cookie 1 + @param [in] cookie2 Cookie 2 + **/ VOID EFIAPI diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c index 08b12c45bc2937942a85ee66cf1a6d80bfa41e69..887f2559dfd05bedb66bb86cd17021efa6a4aea0 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c @@ -2,7 +2,7 @@ Creates HOB during Standalone MM Foundation entry point on ARM platforms. -Copyright (c) 2017 - 2018, ARM Ltd. All rights reserved.
+Copyright (c) 2017 - 2020, Arm Ltd. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -46,7 +46,9 @@ extern EFI_GUID gEfiArmTfCpuDriverEpDescriptorGuid; Use the boot information passed by privileged firmware to populate a HOB list suitable for consumption by the MM Core and drivers. - @param PayloadBootInfo Boot information passed by privileged firmware + @param [in, out] CpuDriverEntryPoint Address of MM CPU driver entrypoint + @param [in] PayloadBootInfo Boot information passed by privileged + firmware **/ VOID * diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c index 3d3c772019df9afe9b8ec77019c776ea7c3b55fb..19472fa659a20d84eebd9e31e20eabab6596f799 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c @@ -214,9 +214,10 @@ GetSpmVersion (VOID) /** The entry point of Standalone MM Foundation. - @param SharedBufAddress Pointer to the Buffer between SPM and SP. - @param cookie1. - @param cookie2. + @param [in] SharedBufAddress Pointer to the Buffer between SPM and SP. + @param [in] SharedBufSize Size of the shared buffer. + @param [in] cookie1 Cookie 1 + @param [in] cookie2 Cookie 2 **/ VOID -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'