From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.45]) by mx.groups.io with SMTP id smtpd.web09.7712.1608210384619288391 for ; Thu, 17 Dec 2020 05:06:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=gTTIn13n; spf=pass (domain: arm.com, ip: 40.107.1.45, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3BU+QYoBreMnOXdd4FF4g6fv3/gkxrVZrY2KltH6ow=; b=gTTIn13nqD6yZihS4xqJHiNh96Olk7vOhgzdfoj3Pissw4kgyGiUxcr8Res2sWKKQtYHnDb3FMSInY/nDOEGl3FQkYwCsL6kx/ggFD0JfEVU8B4K2erP3+YRo+og24xxw7m/LtjiSnjcD6gnVJVe3h1O6Q4Z88X1Bw/pKAScYpE= Received: from AM6P192CA0043.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::20) by DB8PR08MB4188.eurprd08.prod.outlook.com (2603:10a6:10:b0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.13; Thu, 17 Dec 2020 13:06:21 +0000 Received: from AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::91) by AM6P192CA0043.outlook.office365.com (2603:10a6:209:82::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Thu, 17 Dec 2020 13:06:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT035.mail.protection.outlook.com (10.152.16.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:06:20 +0000 Received: ("Tessian outbound 6af064f543d4:v71"); Thu, 17 Dec 2020 13:06:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 88de779423d07d06 X-CR-MTA-TID: 64aa7808 Received: from d6191f50d82f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B63C9917-E784-4631-BBD5-FFFA855E7FA4.1; Thu, 17 Dec 2020 13:05:43 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d6191f50d82f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Dec 2020 13:05:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=coCOahmxlKph7tpcJInFIcQLRpCiFUKkt+Ls2ElcXzLqSQhzSjyQimh2Tkp7kqXMMZHwZpkslY7QDmXSW4GocQVBE3RyJwZrJapIRQsPvPqbx5jM87ubpLp4drSN0hRrkTmeQh8UXtUBiplKhxw+jH7r8GxUgcKj+LvyvWnoy2usfuLcnwkYNDoCn0blOw2xgz7pBaLciaNAlps5Ox91X1igr8ZcS1MgWAglr4iVdVaBGADd8sIY1KKMqF0D4nXUF35ui2DgA3Hw+hr/nptqwV/W60ekhN3qgj057v8i5EjM6zO2V68YxHMlWcf67iBsILHretjGpQ2oxgBUoSdy/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3BU+QYoBreMnOXdd4FF4g6fv3/gkxrVZrY2KltH6ow=; b=YdFi4XgK5hN0+chsJeZ20lsPK26ZI/gin0Zvtwpu3NLX8H9MHdWDUThvmEwlbJz7SZGj/tqhsFsHkNP47FbIhDVYO21c4iXEHrttVL6WbjEhbYAcmJDZOqgs6lDf3Gw9pmr6LnhDlTki+DXc/OnbZ3M97sMv27yIyaqCVMouAUbdcPhIGl7RZj2tyXaeVHzU2W8UV0Z2SLoHYs3Vj/LEMOpgwAHwO9ff+UgQg3epaCfJFh0l08E1JuLJOWX+3KSjnclql/rrZiAcvWfvkoTuEYVLxH3DuMlIuxtu9yqrv1p84QElpnRbv7JFjvUy29SBPtGKdbccIiMzuSaibpAXdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3BU+QYoBreMnOXdd4FF4g6fv3/gkxrVZrY2KltH6ow=; b=gTTIn13nqD6yZihS4xqJHiNh96Olk7vOhgzdfoj3Pissw4kgyGiUxcr8Res2sWKKQtYHnDb3FMSInY/nDOEGl3FQkYwCsL6kx/ggFD0JfEVU8B4K2erP3+YRo+og24xxw7m/LtjiSnjcD6gnVJVe3h1O6Q4Z88X1Bw/pKAScYpE= Received: from DB6PR0301CA0102.eurprd03.prod.outlook.com (2603:10a6:6:30::49) by AM0PR08MB3121.eurprd08.prod.outlook.com (2603:10a6:208:60::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Thu, 17 Dec 2020 13:05:40 +0000 Received: from DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::c1) by DB6PR0301CA0102.outlook.office365.com (2603:10a6:6:30::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Thu, 17 Dec 2020 13:05:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT014.mail.protection.outlook.com (10.152.20.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:40 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Thu, 17 Dec 2020 13:05:24 +0000 Received: from E107187.Arm.com (10.57.33.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Thu, 17 Dec 2020 13:05:23 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v2 22/26] StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint Date: Thu, 17 Dec 2020 13:05:05 +0000 Message-ID: <20201217130509.12568-23-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20201217130509.12568-1-sami.mujawar@arm.com> References: <20201217130509.12568-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1628bdc4-7be2-43ec-67d0-08d8a28c8c1c X-MS-TrafficTypeDiagnostic: AM0PR08MB3121:|DB8PR08MB4188: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pO0zqAjP/SlV3sFeT+TxK1nERSkpGSMBo3MVna258A7aoT5Gqyc+D4pwx03scjHGj05PHd6OyQ4TPljfcQ1DkuKQpdiraKTjKwfYwVLG2zkgRb8yfZrec+zdBJFVvIx4C9PoOS76rC33B252E+pTjb0roJDe2QY28+gzSQOfklC2mj02xI6EgcCbm4fSc45LP5mJJWbvd2nB5yu7b6QRgPQZlfHqV2kPmUfVMhWws9XvcMbqNoDK7Or8Z3E//oyNLnp6s3IPgvVNpnCloMLAHHSgt4+hcDERHzbn+/TcVkQ4LK29kSZm90dimzvq2+xKTQvUz+LExdNFNEIO6CMToNV/q9NzSadQGg1J4KPy3lz06tj5mF3yXHwjZv/M0oFvTb/zk3dUrl1Vy2N+S3hkdA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(396003)(346002)(376002)(136003)(46966005)(7696005)(336012)(83380400001)(478600001)(44832011)(86362001)(36756003)(82310400003)(186003)(2616005)(316002)(54906003)(47076004)(26005)(4326008)(70586007)(356005)(5660300002)(82740400003)(8936002)(81166007)(1076003)(6666004)(70206006)(8676002)(6916009)(426003)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3121 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 92746741-f09c-48ca-ef8c-08d8a28c7450 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kXlQSmJWcoEbSW/F4VrFGUqTnTqTKB8VD+U47azm2CTjrdf0totO78M450SlIyZZUBH2RKyOP5oWrl1rl+3jKTVuFzizGfLX2xTVuqcs0bH0S79pAJLAM15zWR0w1VAUqjHjvru+ERR2fWtRiLLymXoePp7hAaTkiq/m1AnQZWaYcS+JY5ouEOU+aewrH9wZraeuJBKds+7grVnUHDnE36f+IsA4yuvWnnZLM0wgODcoz+8l6U557l3gL7du5lyRkspZgjy4l4PvXYJWL2fDi1T1HyiW61MyQEx7bgytx+MpF18zKMDSj+XpKI6ssWIyIhCRg34Ldq3/MaXaKXU7V1Ey2ExC6M7FwCexEyx1Qe8vm/iyaOlp5gXwULn/HMPFDgpUO0ja3SP9swWayinwbQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(396003)(39850400004)(376002)(136003)(346002)(46966005)(47076004)(2906002)(5660300002)(6916009)(336012)(4326008)(1076003)(82310400003)(81166007)(44832011)(83380400001)(2616005)(82740400003)(86362001)(70206006)(26005)(54906003)(426003)(36756003)(8676002)(186003)(478600001)(7696005)(6666004)(8936002)(316002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2020 13:06:20.2169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1628bdc4-7be2-43ec-67d0-08d8a28c8c1c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4188 Content-Type: text/plain The ECC tool reports error [8005] Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' for the constants SPM_MAJOR_VER, SPM_MINOR_VER & BOOT_PAYLOAD_VERSION. Fix this by changing converting these constant variables to #defined values. Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c index d097c50360adce7f2280ea4d575971927860706e..1363d54ceebfcbc1d64ff476d4f33bdd626a2422 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c @@ -31,10 +31,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define SPM_MINOR_VER_MASK 0x0000FFFF #define SPM_MAJOR_VER_SHIFT 16 -CONST UINT32 SPM_MAJOR_VER = 0; -CONST UINT32 SPM_MINOR_VER = 1; +#define SPM_MAJOR_VER 0 +#define SPM_MINOR_VER 1 -CONST UINT8 BOOT_PAYLOAD_VERSION = 1; +#define BOOT_PAYLOAD_VERSION 1 PI_MM_ARM_TF_CPU_DRIVER_ENTRYPOINT CpuDriverEntryPoint = NULL; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'