From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.55]) by mx.groups.io with SMTP id smtpd.web08.7554.1608210357015947197 for ; Thu, 17 Dec 2020 05:05:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=DpER2q86; spf=pass (domain: arm.com, ip: 40.107.8.55, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WO1HJIn83dIS8gOLzooLNcOZ1IJZG4xlHmIrVaOjUsw=; b=DpER2q86kUPUZdtVPM+sGimoOsWD+f1ojbC/E8s/Vx/i/g8xFvfvfVHVrllnHGhDQQNTcHrtZF5KgmZarkmaTnbcTw0tya47ZNqgqH66mdRDti88nxbURRvVLwFNKqXrnV7VuyCxdUJof1Mq99Y0j/h6DLNjM4pWMTtxuDtdboM= Received: from DB6PR0301CA0084.eurprd03.prod.outlook.com (2603:10a6:6:30::31) by AM0PR08MB4370.eurprd08.prod.outlook.com (2603:10a6:208:148::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Thu, 17 Dec 2020 13:05:54 +0000 Received: from DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::ed) by DB6PR0301CA0084.outlook.office365.com (2603:10a6:6:30::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Thu, 17 Dec 2020 13:05:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT014.mail.protection.outlook.com (10.152.20.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:53 +0000 Received: ("Tessian outbound eeda57fffe7b:v71"); Thu, 17 Dec 2020 13:05:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f96919a56bf87a65 X-CR-MTA-TID: 64aa7808 Received: from 047e6e14397d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 52B933D5-C4F9-4327-85E8-C45E0C5FD795.1; Thu, 17 Dec 2020 13:05:16 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 047e6e14397d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Dec 2020 13:05:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GSzEbncL56RH4lAYUSNTe/Qo56vn7rF2QadadlqTdh2ZWG4QUx7tqII4Uy7tlNZ4X9areCmRKmwcuAK2CJY7Jdr4uRt+ZJvOyjdx9WwOtugNyDFQFkjI7wwuqkixNrwVs6VAhYDb/boUQPKCavU7fGCx/0sPQoBnMMsyH7Xfx6vrCWRYAEnP38iu9vegB5GS7dt092hnM2H5BVUXxzjgxo0BeblUSut/D4Ae+S5i1/gdjU2dIki8kLVGnJGoU2iD9fWxgMZLz7rkUoNAAnOR8Od6jcSboHOylyqqdAbWoOrXdzf2+u2IbWbc5eNLFd2VPn/RsYWt3V0IVCJDJKGD6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WO1HJIn83dIS8gOLzooLNcOZ1IJZG4xlHmIrVaOjUsw=; b=hSPwLHj9Y0Yn4O0xEC3iIzFITCDN26Zs8WW8EyeT91kDu0vG1+k3OWho4BvUuWE88surUKhqVAQtisSivwdgi7CvZBgLARzn9hOgN5gXg5xaeCs8bvrJYH9UKQt9PmZdYkysX9b9cDoKFJ+xD+z2zxLcz71JLE91iFm2WHQPJRkKDWgEnWKOXYI3HrBgJ7y+Ypo0cjYK4t2PrT4SnY7ybvBq9c5n6qyhHftyqLAUs36qUze75amSqG2CV7oHOEZuFmg54fU+qsb3MD/MspLjsMxYp5hMBEH2EbqXZG1KRnjfHLz8I2xvh3VbehXib4Ybib7kTAUb+8+In+s3y0Q0IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WO1HJIn83dIS8gOLzooLNcOZ1IJZG4xlHmIrVaOjUsw=; b=DpER2q86kUPUZdtVPM+sGimoOsWD+f1ojbC/E8s/Vx/i/g8xFvfvfVHVrllnHGhDQQNTcHrtZF5KgmZarkmaTnbcTw0tya47ZNqgqH66mdRDti88nxbURRvVLwFNKqXrnV7VuyCxdUJof1Mq99Y0j/h6DLNjM4pWMTtxuDtdboM= Received: from AM6PR10CA0032.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::45) by AM9PR08MB6305.eurprd08.prod.outlook.com (2603:10a6:20b:284::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.17; Thu, 17 Dec 2020 13:05:14 +0000 Received: from AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::e6) by AM6PR10CA0032.outlook.office365.com (2603:10a6:209:89::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Thu, 17 Dec 2020 13:05:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT024.mail.protection.outlook.com (10.152.16.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:14 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Thu, 17 Dec 2020 13:05:13 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Thu, 17 Dec 2020 13:05:13 +0000 Received: from E107187.Arm.com (10.57.33.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Thu, 17 Dec 2020 13:05:12 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v2 04/26] StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher Date: Thu, 17 Dec 2020 13:04:47 +0000 Message-ID: <20201217130509.12568-5-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20201217130509.12568-1-sami.mujawar@arm.com> References: <20201217130509.12568-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4529685-14bc-44c5-ad57-08d8a28c7c6f X-MS-TrafficTypeDiagnostic: AM9PR08MB6305:|AM0PR08MB4370: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mdWWcKD4GyfS4R5D0RCy1ypSePrfkgKtX2ELOL5eBmiHGP8giohhefpzIDGq2uh6HE4Aw/qRMJ/YM2HHIbOCxJTWLtj80YqYSvefxw8xnrkgzPbqmodgyV8CX4pesPeLWp+xUEPd92H1eRHEhiRp3Bl0W8HiLHq49JvJLODVKeTkeoPpolIrg8U32vuqQE45BN1CX8BNaJCrZI6/GNrcZahXuAPbYorE9pIdOThnFqk4cwqD6gcQW+7ijp3CWZQ93Fvdpte6B1LTGnpf73hsxGFI1ApApirWOsrGMCAiLWgYRCv+jSBNh+DEP1ez6CynXNol98yuO0Y7AydSMOpxC9H37mPt5GMr/ISxKGvucV5H5/WxH7WXbVNY+akbEDjMeFDrYescfGt4qdeGjpor7w== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(376002)(396003)(346002)(136003)(46966005)(86362001)(316002)(44832011)(83380400001)(336012)(6666004)(2906002)(7696005)(82310400003)(2616005)(478600001)(6916009)(1076003)(36756003)(81166007)(70586007)(70206006)(54906003)(5660300002)(426003)(356005)(8676002)(4326008)(26005)(47076004)(186003)(8936002)(82740400003);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6305 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: dafe0955-d0b1-4abd-2e61-08d8a28c64b8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S7iTRYZfaetD77HgOtTL2yccbTxUd0RuGfV7Wxz/Y6XWgjyf2D0AoByaMjv/jSMEKnxepdsQGi0tspeQ0NtZ2SAQFua1MtxhB3edkjvB+4VMKR0tkVFvo6y0DpBLiIJ/JBiIVZts0WY9QMFuW/Y0ysJgU6iyq04eI2vEnlWvLD+qry2gDIIkamjefOawO3D5ny+1tzfRFqgfnH66OkqR2nsPrfPgpuGmyJoUXiaiMH5usbQr3waL/lLW00oovy3kMTgsVvDjFPrroYM55I4paZ5iHv3B64LHxHlj/LymodnJxoo5V0D4Rmfg+8VMQPkVqK/d/2xp2xIXVS0/6lUkBaHAABcb/E6vdRw+o6pP4stJ5g6hRKKAgcLMXZxb5Nlve3VQa/ZYMxAgJfcMkWHwhQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(346002)(396003)(376002)(136003)(46966005)(82310400003)(70206006)(8936002)(47076004)(186003)(26005)(1076003)(426003)(82740400003)(81166007)(70586007)(336012)(7696005)(54906003)(6916009)(83380400001)(4326008)(86362001)(2906002)(478600001)(316002)(8676002)(44832011)(5660300002)(2616005)(6666004)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2020 13:05:53.9650 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e4529685-14bc-44c5-ad57-08d8a28c7c6f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4370 Content-Type: text/plain Fix the ECC reported error "[9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 in Comment" Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Core/Dispatcher.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c index 45b17fe3acfec9c056396873006c03f668c1aed6..26e5a6933f8d5b5a33865ff63d3ae4bea9fc8c09 100644 --- a/StandaloneMmPkg/Core/Dispatcher.c +++ b/StandaloneMmPkg/Core/Dispatcher.c @@ -834,18 +834,14 @@ FvIsBeingProcessed ( The Discovered list is never freed and contains booleans that represent the other possible MM driver states. - @param Fv Fv protocol, needed to read Depex info out of - FLASH. - @param FvHandle Handle for Fv, needed in the - EFI_MM_DRIVER_ENTRY so that the PE image can be - read out of the FV at a later time. - @param DriverName Name of driver to add to mDiscoveredList. + @param [in] FwVolHeader Pointer to the formware volume header. + @param [in] Pe32Data Pointer to the PE data. + @param [in] Pe32DataSize Size of the PE data. + @param [in] Depex Pointer to the Depex info. + @param [in] DepexSize Size of the Depex info. + @param [in] DriverName Name of driver to add to mDiscoveredList. @retval EFI_SUCCESS If driver was added to the mDiscoveredList. - @retval EFI_ALREADY_STARTED The driver has already been started. Only one - DriverName may be active in the system at any one - time. - **/ EFI_STATUS MmAddToDriverList ( -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'