From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.82]) by mx.groups.io with SMTP id smtpd.web12.7710.1608210374234337171 for ; Thu, 17 Dec 2020 05:06:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=xCkC+BZI; spf=pass (domain: arm.com, ip: 40.107.6.82, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5h9HeCVHHudD4qfH9KzUhJVGnrw6AYnsboeXGUwdBaw=; b=xCkC+BZIrCo4Q18jQfuDGzM16tbOhkXq4Ewxi+bUvHyyQxOS01RtI65ehKZ8Cvj9jQCF35t92oAMyo97pzXp6/Y0n5uYY+UqpBW9dsLnUTaDcV7KbzdT17j0leoEIPAAWIuYLqPqQf6x5GR7yJcJVam94gfGVGv6yCuNmuCJE/g= Received: from DB6PR07CA0067.eurprd07.prod.outlook.com (2603:10a6:6:2a::29) by HE1PR0801MB1900.eurprd08.prod.outlook.com (2603:10a6:3:4d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.18; Thu, 17 Dec 2020 13:06:11 +0000 Received: from DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::65) by DB6PR07CA0067.outlook.office365.com (2603:10a6:6:2a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.9 via Frontend Transport; Thu, 17 Dec 2020 13:06:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT018.mail.protection.outlook.com (10.152.20.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:06:11 +0000 Received: ("Tessian outbound 76bd5a04122f:v71"); Thu, 17 Dec 2020 13:06:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 80e5c918ca842e0c X-CR-MTA-TID: 64aa7808 Received: from 1c5c930c5037.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6D45CD56-E6CB-4DEF-ABCB-ED9382962843.1; Thu, 17 Dec 2020 13:05:33 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1c5c930c5037.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Dec 2020 13:05:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LW/RZviZi8JSy4xUcF0jJW5Sfef/ezducVb8SYxKerZ/shqwCkyx1uzs7exDQoaW6Y6pMH+54TdoVsigmm1PtLIewFSigjlknOVNTj+vu/52tMa/mGUlDB0c8Ue0au/kZx3BWlf0f8k9VUBTmOC6x8aJM/3JSQ2Bes9fUG/UEsIGQusqOhD/gOVw/kBFZAAmil3lHlwhK6HjLcpeVF3l5jziByFMaMOi3vuEEt9RsksXwy3aF3rbYSjPw9RY5wdxuPN8+TZFBATqALnW0gEPzGg13m6KDcHLDdMcsFJNnQbNgX9MxanmgPpgQIgJMBRjYT/Tsr4xT+BrOtqy03Vuyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5h9HeCVHHudD4qfH9KzUhJVGnrw6AYnsboeXGUwdBaw=; b=mR8HD7WJuATQpAX94GHfKbFy7Onfr/Gtgaz4nkgxBtmjOQ0k1krKwaLroyeDGeb8aLEn2jrkkOvVkvmhD/0Giw0/5jkJe/OSNt4VP3MolFwSEkgGV4wJmoWuDreJlQilALN+wkFZMtOxbYFVr/XQ+/+1ZXKDhxtDGcoPXbBRUSSlaTywH4Ai+j3wr8IkXpwNLGYYdwM/e1RL9ps9YZI7ap6OhiA8A8om4bCEq308fwOeTWO/CQzG/NKcCa573Qd/KeurrX9N/2wwbF+LrxM8BkCAjynd4oyagcqRuiN+twE27u5p+8YvPlzGMRkNhRc2yw5XRwyQDbC3O8rk0ahgYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5h9HeCVHHudD4qfH9KzUhJVGnrw6AYnsboeXGUwdBaw=; b=xCkC+BZIrCo4Q18jQfuDGzM16tbOhkXq4Ewxi+bUvHyyQxOS01RtI65ehKZ8Cvj9jQCF35t92oAMyo97pzXp6/Y0n5uYY+UqpBW9dsLnUTaDcV7KbzdT17j0leoEIPAAWIuYLqPqQf6x5GR7yJcJVam94gfGVGv6yCuNmuCJE/g= Received: from DB9PR01CA0008.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::13) by PR3PR08MB5851.eurprd08.prod.outlook.com (2603:10a6:102:85::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.13; Thu, 17 Dec 2020 13:05:32 +0000 Received: from DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d8:cafe::c7) by DB9PR01CA0008.outlook.office365.com (2603:10a6:10:1d8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.17 via Frontend Transport; Thu, 17 Dec 2020 13:05:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT061.mail.protection.outlook.com (10.152.21.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3676.22 via Frontend Transport; Thu, 17 Dec 2020 13:05:32 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Thu, 17 Dec 2020 13:05:17 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Thu, 17 Dec 2020 13:05:14 +0000 Received: from E107187.Arm.com (10.57.33.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Thu, 17 Dec 2020 13:05:14 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v2 07/26] StandaloneMmPkg: Fix ECC error 4002 in FwVol helper Date: Thu, 17 Dec 2020 13:04:50 +0000 Message-ID: <20201217130509.12568-8-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20201217130509.12568-1-sami.mujawar@arm.com> References: <20201217130509.12568-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9b556a0-69e4-4ee2-a268-08d8a28c869c X-MS-TrafficTypeDiagnostic: PR3PR08MB5851:|HE1PR0801MB1900: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2657;OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: texd4Q+oljX+PMnqB30lxhB4vjDzCodT6+Zg+4o3Ym69Cpb6DJf5p1A14IvziwRNeFI9Thqx5/QbrGSvjGjHJ7/y9GOugQZ+y4mnV3EYuuqouYNXeebXdwImqKgTS5gO+rP2VmdKgNPGAfwKUbIMIwCxFC+qI1Vs9SjrSxPHRuZ8vS0FfpFAL9cQOm3QKEA3mzGwABBZtgYaYqkIETrUgcX/VE4KoRJcT/SnJznUQxL3Tw0I5rqPlEFhQBHYbjlMXvY1WElcfSloSZi6ev+x52bvkPtB8sZBJSo/sSbuIRzHnQyTgnygneMOJPYfUu6XkwZorSzgogc8HEDa1M5wGLxj0McFgPdit24V1zojF3/Tx1a9Je+u06sa+l0jQ47wvc7ra77ncy3Dxf42EDjt9A== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(136003)(39860400002)(376002)(346002)(396003)(46966005)(8936002)(7696005)(44832011)(2616005)(8676002)(316002)(81166007)(70206006)(70586007)(426003)(186003)(6666004)(36756003)(2906002)(47076004)(1076003)(26005)(5660300002)(82310400003)(478600001)(54906003)(86362001)(356005)(336012)(6916009)(83380400001)(82740400003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5851 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 730f6a6c-20d5-480e-b5ff-08d8a28c6f58 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kxA9X+LlJyfJwGN/iRL3GBxrh546qLVqQqGkBrHDq6Th814/v46R96sAjlDQeWn1iNN1drAWFrNwf+rpz0jTSetd/D+7w0ydZHr6SBMuRLBdZQ/VNp4qOZFQSBsluGkuph4Bg/ognofJrL4UpkBdn5TQwC4VBz7qMB3A6NrpTA9q7EHH4zlxFTm6aTfBLwl/Q+YXM1Y+xDxurggVggTdwWJF85KNYWGf3BURrUCa+1+u6C36Ugq+n4wUqfkwK8KPuV3u9Fd4l4iWMC4B3/d3TlQ2Lk/2BnieH/7mhfWUhn3vCfVqctyWbTCJCbTQsggIskpj9r9uDwqngA7tIBwjUr0JRO3STa9zDH4Zohv87rRMzNDTtXbN52qukeqSEQuor3mX0q0cFuKsylWseFbE4w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(39850400004)(376002)(396003)(136003)(346002)(46966005)(36756003)(478600001)(47076004)(8676002)(2616005)(86362001)(316002)(83380400001)(7696005)(26005)(54906003)(4326008)(70586007)(426003)(5660300002)(82310400003)(44832011)(81166007)(186003)(6666004)(8936002)(6916009)(336012)(1076003)(2906002)(82740400003)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2020 13:06:11.0398 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9b556a0-69e4-4ee2-a268-08d8a28c869c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1900 Content-Type: text/plain Fix ECC Error "[4002] Function header doesn't exist Function [MmCoreFfsFindMmDriver] has NO comment immediately preceding it." Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Core/FwVol.c | 29 ++++++++++---------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c index 856d86011d314a33cdee66af77f34fc8b290b509..c441afc3957b0f8c39625d8199a16c3823990e99 100644 --- a/StandaloneMmPkg/Core/FwVol.c +++ b/StandaloneMmPkg/Core/FwVol.c @@ -1,7 +1,7 @@ /**@file Copyright (c) 2015, Intel Corporation. All rights reserved.
-Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
+Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -42,23 +42,24 @@ FvIsBeingProcessed ( IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader ); +/** + Given the pointer to the Firmware Volume Header find the + MM driver and return its PE32 image. + + @param [in] FwVolHeader Pointer to memory mapped FV + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_NOT_FOUND Could not find section data. + @retval EFI_OUT_OF_RESOURCES Out of resources. + @retval EFI_VOLUME_CORRUPTED Firmware volume is corrupted. + @retval EFI_UNSUPPORTED Operation not supported. + +**/ EFI_STATUS MmCoreFfsFindMmDriver ( IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader ) -/*++ - -Routine Description: - Given the pointer to the Firmware Volume Header find the - MM driver and return its PE32 image. - -Arguments: - FwVolHeader - Pointer to memory mapped FV - -Returns: - other - Failure - ---*/ { EFI_STATUS Status; EFI_STATUS DepexStatus; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'