From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.23893.1608472447423026274 for ; Sun, 20 Dec 2020 05:54:07 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: samer.el-haj-mahmoud@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 128F41042; Sun, 20 Dec 2020 05:53:57 -0800 (PST) Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7A923F66B; Sun, 20 Dec 2020 05:53:56 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel , Pete Batard Subject: [edk2-platform][PATCH v2 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE Date: Sun, 20 Dec 2020 08:53:53 -0500 Message-Id: <20201220135355.12814-2-Samer.El-Haj-Mahmoud@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> References: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable REF: https://github.com/pftf/RPi4/issues/115 GraphicsConsoleDxe defaults the ConOut Mode.CursorVisible to TRUE. However, the driver never draws the cursor during init. This results in the first call to disable the cursor (using ConOut->EnableCursor(FALSE)) to actually draw the cursor on the screen, as the logic in FlushCursor depe= nds on the Mode.CursorVisible state to determine if it should draw or erase the cursor. Fix by changing the default CursorVisible in this driver to FALSE. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Zhichao Gao --- MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= ole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c index c042451a9b52..6b8d11d587d1 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c @@ -33,7 +33,7 @@ GRAPHICS_CONSOLE_DEV mGraphicsConsoleDevTemplate =3D { EFI_TEXT_ATTR(EFI_LIGHTGRAY, EFI_BLACK),=0D 0,=0D 0,=0D - TRUE=0D + FALSE=0D },=0D (GRAPHICS_CONSOLE_MODE_DATA *) NULL,=0D (EFI_GRAPHICS_OUTPUT_BLT_PIXEL *) NULL=0D --=20 2.25.1