public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>,
	Zhichao Gao <zhichao.gao@intel.com>, Ray Ni <ray.ni@intel.com>,
	Ard Biesheuvel <Ard.Biesheuvel@arm.com>
Subject: [edk2-platform][PATCH v2 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY
Date: Sun, 20 Dec 2020 08:53:55 -0500	[thread overview]
Message-ID: <20201220135355.12814-4-Samer.El-Haj-Mahmoud@arm.com> (raw)
In-Reply-To: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com>

ConSplitter is using EFI_LIGHTGRAY foreground color for ConOut
and EFI_MAGENTA for StdErr consoles. This is impacting the DebugLib
output on that same serial console (e.g. DebugLibSerialPort) after
gEfiStandardErrorDeviceGuid is installed on that port. The impact
also extends to Linux serial console output in OVMF because it inherits
the color setting from the firmware.

This is inconsistent and annoying, with MAGENTA being barely legible on
a black background.

Let's change StdErr default color to LIGHTGRAY for consistency and
readability. This results in the same color being used for all consoles
sharing the same serial port (ConOut, StdErr, DebugLib, OS console).
Platforms wishing to distinguish the colors of consoles can do so in
their own Platform BDS initialization.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
---
 MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
index b090de288517..e8cd4ce120a0 100644
--- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
+++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
@@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart (
   // their MaxMode and QueryData should be the intersection of both.
   //
   Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL);
-  ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAGENTA, EFI_BLACK));
+  ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_LIGHTGRAY, EFI_BLACK));
 
   return Status;
 }
-- 
2.25.1


  parent reply	other threads:[~2020-12-20 13:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-20 13:53 [edk2-platform][PATCH v2 0/3] MdeModulePkg/GraphicsConsole : Console cleanup Samer El-Haj-Mahmoud
2020-12-20 13:53 ` [edk2-platform][PATCH v2 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE Samer El-Haj-Mahmoud
2020-12-23 16:34   ` Pete Batard
2020-12-20 13:53 ` [edk2-platform][PATCH v2 2/3] MdeModulePkg/Graphics: Fix spelling mistakes Samer El-Haj-Mahmoud
2020-12-20 13:53 ` Samer El-Haj-Mahmoud [this message]
2020-12-23 16:35   ` [edk2-devel] [edk2-platform][PATCH v2 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY Pete Batard
2020-12-24  1:11     ` Gao, Zhichao
2020-12-24 16:33       ` Samer El-Haj-Mahmoud
2020-12-25  1:21         ` Gao, Zhichao
2020-12-25  2:50           ` Ni, Ray
2020-12-30 18:10             ` Samer El-Haj-Mahmoud
2021-01-05 14:25               ` Pete Batard
2021-01-06  5:28 ` [edk2-devel] [edk2-platform][PATCH v2 0/3] MdeModulePkg/GraphicsConsole : Console cleanup Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201220135355.12814-4-Samer.El-Haj-Mahmoud@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox