From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.23699.1608472448063056197 for ; Sun, 20 Dec 2020 05:54:08 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: samer.el-haj-mahmoud@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C6A37106F; Sun, 20 Dec 2020 05:53:57 -0800 (PST) Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 80D8A3F66B; Sun, 20 Dec 2020 05:53:57 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel Subject: [edk2-platform][PATCH v2 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY Date: Sun, 20 Dec 2020 08:53:55 -0500 Message-Id: <20201220135355.12814-4-Samer.El-Haj-Mahmoud@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> References: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ConSplitter is using EFI_LIGHTGRAY foreground color for ConOut and EFI_MAGENTA for StdErr consoles. This is impacting the DebugLib output on that same serial console (e.g. DebugLibSerialPort) after gEfiStandardErrorDeviceGuid is installed on that port. The impact also extends to Linux serial console output in OVMF because it inherits the color setting from the firmware. This is inconsistent and annoying, with MAGENTA being barely legible on a black background. Let's change StdErr default color to LIGHTGRAY for consistency and readability. This results in the same color being used for all consoles sharing the same serial port (ConOut, StdErr, DebugLib, OS console). Platforms wishing to distinguish the colors of consoles can do so in their own Platform BDS initialization. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/= MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c index b090de288517..e8cd4ce120a0 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c @@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart ( // their MaxMode and QueryData should be the intersection of both.=0D //=0D Status =3D ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL);= =0D - ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAG= ENTA, EFI_BLACK));=0D + ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_LIG= HTGRAY, EFI_BLACK));=0D =0D return Status;=0D }=0D --=20 2.25.1