* [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds
@ 2020-12-29 18:31 Marcin Wojtas
2020-12-29 18:40 ` Rebecca Cran
0 siblings, 1 reply; 3+ messages in thread
From: Marcin Wojtas @ 2020-12-29 18:31 UTC (permalink / raw)
To: devel; +Cc: leif, ard.biesheuvel, mw, jaz, kostap, rebecca, Laszlo Ersek
As the SignedCapsulePkg requires ArmSoftFloatLib resolution
for ARM builds, add missing dependency for all Marvell
platforms.
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reported-by: Laszlo Ersek <lersek@redhat.com>
---
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 017c6287f7..e8e7300441 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -211,6 +211,9 @@
# Add support for GCC stack protector
NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+[LibraryClasses.ARM]
+ ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
+
################################################################################
#
# Pcd Section - list of all EDK II PCD Entries defined by this Platform
--
2.29.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds
2020-12-29 18:31 [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds Marcin Wojtas
@ 2020-12-29 18:40 ` Rebecca Cran
2021-01-04 17:06 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Rebecca Cran @ 2020-12-29 18:40 UTC (permalink / raw)
To: Marcin Wojtas, devel; +Cc: leif, ard.biesheuvel, jaz, kostap, Laszlo Ersek
On 12/29/20 11:31 AM, Marcin Wojtas wrote:
> As the SignedCapsulePkg requires ArmSoftFloatLib resolution
> for ARM builds, add missing dependency for all Marvell
> platforms.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 017c6287f7..e8e7300441 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -211,6 +211,9 @@
> # Add support for GCC stack protector
> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>
> +[LibraryClasses.ARM]
> + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> +
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
Thanks - that was good timing!
--
Rebecca Cran
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds
2020-12-29 18:40 ` Rebecca Cran
@ 2021-01-04 17:06 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2021-01-04 17:06 UTC (permalink / raw)
To: Rebecca Cran, Marcin Wojtas, devel; +Cc: leif, jaz, kostap, Laszlo Ersek
On 12/29/20 7:40 PM, Rebecca Cran wrote:
> On 12/29/20 11:31 AM, Marcin Wojtas wrote:
>> As the SignedCapsulePkg requires ArmSoftFloatLib resolution
>> for ARM builds, add missing dependency for all Marvell
>> platforms.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>> Reported-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> index 017c6287f7..e8e7300441 100644
>> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> @@ -211,6 +211,9 @@
>> # Add support for GCC stack protector
>> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>> +[LibraryClasses.ARM]
>> + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
>> +
>
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
>
> Thanks - that was good timing!
>
Pushed as eec4526f3bc2..a34e27a1fa79
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-04 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-29 18:31 [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds Marcin Wojtas
2020-12-29 18:40 ` Rebecca Cran
2021-01-04 17:06 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox