From: "Heinrich Schuchardt" <xypron.glpk@gmx.de>
To: EDK II Development <devel@edk2.groups.io>
Cc: Eric Jin <eric.jin@intel.com>,
G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Barton Gao <gaojie@byosoft.com.cn>,
Arvin Chen <arvinx.chen@intel.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: [PATCH 1/1] uefi-sct/SctPkg: format string BBTestFatToStrFunctionAutoTest
Date: Fri, 1 Jan 2021 20:52:27 +0100 [thread overview]
Message-ID: <20210101195227.59101-1-xypron.glpk@gmx.de> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3146
EFI_UNICODE_COLLATION_PROTOCOL.FatToStr() expects as parameter Fat an ASCII
string not a wide string.
In function BBTestFatToStrFunctionAutoTest() this string is supplied as
TestData[Index].
When printing this string we cannot use "%s" but we must use "%a".
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
.../BlackBoxTest/UnicodeCollation2BBTestFunction.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/UnicodeCollation2BBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/UnicodeCollation2BBTestFunction.c
index 8bf5170f..22b57f21 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/UnicodeCollation2BBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/UnicodeCollation2BBTestFunction.c
@@ -636,7 +636,7 @@ BBTestFatToStrFunctionAutoTest (
AssertionType,
gUnicodeCollationFunctionTestAssertionGuid007,
L"EFI_UNICODE_COLLATION_PROTOCOL.FatToStr - Verification of FatToStr interface",
- L"%a:%d: Fat='%s', FatToStr='%s', FatSize=%d, StrSize=%d",
+ L"%a:%d: Fat='%a', FatToStr='%s', FatSize=%d, StrSize=%d",
__FILE__,
(UINTN)__LINE__,
TestData[Index],
@@ -668,7 +668,7 @@ BBTestFatToStrFunctionAutoTest (
AssertionType,
gUnicodeCollationFunctionTestAssertionGuid008,
L"EFI_UNICODE_COLLATION_PROTOCOL.FatToStr - Verification of FatToStr interface",
- L"%a:%d: Fat='%s', FatToStr='%s', FatSize=%d, StrSize=%d",
+ L"%a:%d: Fat='%a', FatToStr='%s', FatSize=%d, StrSize=%d",
__FILE__,
(UINTN)__LINE__,
TestData[Index],
@@ -701,7 +701,7 @@ BBTestFatToStrFunctionAutoTest (
AssertionType,
gUnicodeCollationFunctionTestAssertionGuid009,
L"EFI_UNICODE_COLLATION_PROTOCOL.FatToStr - Verification of FatToStr interface",
- L"%a:%d: Fat='%s', FatToStr='%s', FatSize=%d, StrSize=%d",
+ L"%a:%d: Fat='%a', FatToStr='%s', FatSize=%d, StrSize=%d",
__FILE__,
(UINTN)__LINE__,
TestData[Index],
--
2.29.2
next reply other threads:[~2021-01-01 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 19:52 Heinrich Schuchardt [this message]
2021-01-05 15:13 ` [PATCH 1/1] uefi-sct/SctPkg: format string BBTestFatToStrFunctionAutoTest G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210101195227.59101-1-xypron.glpk@gmx.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox