From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.40]) by mx.groups.io with SMTP id smtpd.web08.13289.1609766557930787922 for ; Mon, 04 Jan 2021 05:22:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=N6w8Wg1M; spf=pass (domain: arm.com, ip: 40.107.6.40, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tw0hYfXd4Utr4sXqsqB7n3ivuncu+abcma7R3cmUb4M=; b=N6w8Wg1M40vKxD/Yp4pqG9vXuDbHHBOvKYIZ3x17X/HJm1+n/cNPeT1SWHvvToWLUmdxvH3KB7vXvGFIMS9mGxHxmbbaw6DmKDKupvDcrTgeLCMs1m28mUuIQicSUOoiW2+lOpKp3ZBJwMYiI5LIbmOMeVXw48MpSB/I/PkoUSw= Received: from DB6PR07CA0068.eurprd07.prod.outlook.com (2603:10a6:6:2a::30) by DB8PR08MB4987.eurprd08.prod.outlook.com (2603:10a6:10:e2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20; Mon, 4 Jan 2021 13:22:35 +0000 Received: from DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::73) by DB6PR07CA0068.outlook.office365.com (2603:10a6:6:2a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.2 via Frontend Transport; Mon, 4 Jan 2021 13:22:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT060.mail.protection.outlook.com (10.152.21.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:22:35 +0000 Received: ("Tessian outbound 39646a0fd094:v71"); Mon, 04 Jan 2021 13:22:35 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6db403e895d05b1b X-CR-MTA-TID: 64aa7808 Received: from 8af1bbcaec80.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B56BE64-F2B5-4F5B-9482-B2E2D37FF133.1; Mon, 04 Jan 2021 13:22:29 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8af1bbcaec80.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jan 2021 13:22:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AmR1ipJHdwuZvkphCg3zCN2CuqBrEv19V3bA2in/EjRStyyizbMOylfWZqsrPIFqFan0XhFQQB2D/IQskRVII/2+p+F4mBONFqc1Zw4t252b3XO/zTANYiZ4hbbGwTep4K20QRL6y4bWPxxT8RQY5ckJCqWJfibrZ5ydiuKfhfikljL47ivn0zy67Q/ik7QjFTVJXqBtFMw4j5BZDuuMl0cm0BBCzQBfH4IOC7dTG1HHBkkU3zAuLiFndK2cLhRD/7Af83O+Q3Xuqj/Az9dDA0g0xsAptnSKkM0TWgNfMKS3ChcAFZMDOUyAJhbdAgh1pFpQmox0b88bUXH9qSwKCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tw0hYfXd4Utr4sXqsqB7n3ivuncu+abcma7R3cmUb4M=; b=aF5SavX+ZsrlC41iFjE03icd91tLHfhFKEnN45uI3DY1wOrxpVFxCT4SM5V6urgRZPoCNpPg0ITzLrjvHV0I2bvYsHjX9TLR4TxmAg+YQeeiIl4A4jJ2KMSx1AOugwH62TsuFzfCCB6+OYi28jbAPhgD43/j4PExEuzk61Ztn3Re4BWSxCkRliHvKaYebVv6McSlb75RgIjRfe1X35JSO9/mcdIOSkY2+tqEXeFpGcz15WuXkHdRVlrQQyB/nTXqQlzVxDMgW7CerXvX1wULk12cLdKahGt3jf1EZ6SDvWkE/7jJ00K4HW26GVpXXZM0bHgz+weqLhK9rvO20/TfbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tw0hYfXd4Utr4sXqsqB7n3ivuncu+abcma7R3cmUb4M=; b=N6w8Wg1M40vKxD/Yp4pqG9vXuDbHHBOvKYIZ3x17X/HJm1+n/cNPeT1SWHvvToWLUmdxvH3KB7vXvGFIMS9mGxHxmbbaw6DmKDKupvDcrTgeLCMs1m28mUuIQicSUOoiW2+lOpKp3ZBJwMYiI5LIbmOMeVXw48MpSB/I/PkoUSw= Received: from DB6P193CA0017.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::27) by DB8PR08MB3947.eurprd08.prod.outlook.com (2603:10a6:10:ae::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20; Mon, 4 Jan 2021 13:22:28 +0000 Received: from DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::ec) by DB6P193CA0017.outlook.office365.com (2603:10a6:6:29::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19 via Frontend Transport; Mon, 4 Jan 2021 13:22:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT011.mail.protection.outlook.com (10.152.20.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:22:28 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Mon, 4 Jan 2021 13:22:22 +0000 Received: from E107187.Arm.com (10.57.38.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Mon, 4 Jan 2021 13:22:22 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v3 10/26] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore Date: Mon, 4 Jan 2021 13:21:57 +0000 Message-ID: <20210104132213.22376-11-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20210104132213.22376-1-sami.mujawar@arm.com> References: <20210104132213.22376-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4789e6b6-56a8-4aa2-f454-08d8b0b3cca0 X-MS-TrafficTypeDiagnostic: DB8PR08MB3947:|DB8PR08MB4987: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:538;OLM:538; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /D6rrjPvELMSXLfyAU/kr44FWGKPtub7IluC9rDurT0xJS0y7R7iFiR6hONy8E0FSqN9AYmK98Ph+1Blb9Vy8MTXmJfG08NY4gKFmuzj8zVD9laGl3Q2OWE4jd6Oo8gLGhnOw2kL8SKOasIo+uzri9i4uE7hvSr1URocyopVdwpmWFYFVA5vDtDCZnpLhC2plMX1DvwwGjDSS5WrQbRalaz2jOLEA42SNLdKqyFifhbY5HJZE/QcMY2Rxe1V5mD1++IupLnuEYdhrulWkVfacYAIok2H9H8QUyKOymlM4pwJoZL/rkVkosx7jn+P4SsVa168XX/8xw0WkNcqPcnMP0hQbN1RytxbjWdj23tbEX5UxIwhhlX9RgTp2jZ1wzM/rtk+r3hP+2Lyg4Tn32UV6xVqmArLdU8LDxGfbq1WRWFHniQE+s8I4ScBAfvmcUhgqYHlcX9iudqAeVf8EGyvmcUuxiqIuVAHt7Dp3wVZtvi0AELkcsPQIdmZgIU8aGFXW5P2e0f553nJTCVbZMdWmOfTMJ5ojN+LFf3MeySqtaA= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966006)(70586007)(44832011)(70206006)(356005)(81166007)(478600001)(83380400001)(86362001)(6666004)(36756003)(82310400003)(186003)(26005)(54906003)(6916009)(8936002)(8676002)(336012)(2906002)(47076005)(7696005)(5660300002)(426003)(316002)(82740400003)(1076003)(4326008)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB3947 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f0278beb-8d6b-4df7-18f4-08d8b0b3c887 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BwNJ2SvonNj/rcN4azfMIJV1Bhi4zeTZ5zOtSGRUzjwjCi+iK+oHRDH689ScRNrbR8EJEsgr9UNvRBrUNzzWSrVkiWOu07UyigibCzMRty0FcE5Anqh9Vz6N7lvHC4oju/iIzstFkCPcf5AQojV/poLTHgeQoH/U5AUQoWpnKVNvIIl43hbDm/k5O8fKwdXAaZEYpx99b63DjYU3XZ6SQrkYqoieD2wivQZPrXrc940DvGjEMvECTvJFtvqWjtBiAjIAmmRpE1X9XPnVBv3qW1egjaPsN0v+wgOeRa9qhpA57lzP4mDW6DXxWzqwZCmj6GpQoepyW7vJao95+IU1hjeQBtRc6U62gTOftvL0yuKrCzFKRwSANTDioZk6e9bDgjK5lvbRBGGCWnagGRFtsGUyL04fmZ9XZVZ/DYHss5oYQCagOJumyEvRe7MFYT6b06Enjdk9vbNnRwKHFrEDPRsOFeJ2OMMasUHJO3qxWPD0xwVrMBIMtDe98pIy6L/Gh4uXD4SIRH4MmZfyKu+45WJusOuUhp12E4JeRBeMF0o= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(346002)(136003)(396003)(376002)(46966006)(8936002)(44832011)(2906002)(70206006)(81166007)(6916009)(82740400003)(70586007)(6666004)(2616005)(83380400001)(36756003)(316002)(47076005)(26005)(5660300002)(426003)(82310400003)(7696005)(4326008)(336012)(186003)(86362001)(1076003)(478600001)(54906003)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2021 13:22:35.1600 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4789e6b6-56a8-4aa2-f454-08d8b0b3cca0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4987 Content-Type: text/plain Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150) Fix ECC error "[5007] There should be no initialization of a variable as part of its declaration Variable." Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v3: - No code change. Added bugzilla ID and resending patch [SAMI] with v3 series. v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Core/StandaloneMmCore.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.c b/StandaloneMmPkg/Core/StandaloneMmCore.c index 0b3ddbaa6a35e2e609f737a39ace62c2406bf8df..803d7605ece7f6a3400866a04e39acf74cda8144 100644 --- a/StandaloneMmPkg/Core/StandaloneMmCore.c +++ b/StandaloneMmPkg/Core/StandaloneMmCore.c @@ -149,9 +149,10 @@ MmExitBootServiceHandler ( ) { EFI_HANDLE MmHandle; - EFI_STATUS Status = EFI_SUCCESS; + EFI_STATUS Status; STATIC BOOLEAN mInExitBootServices = FALSE; + Status = EFI_SUCCESS; if (!mInExitBootServices) { MmHandle = NULL; Status = MmInstallProtocolInterface ( @@ -187,9 +188,10 @@ MmReadyToBootHandler ( ) { EFI_HANDLE MmHandle; - EFI_STATUS Status = EFI_SUCCESS; + EFI_STATUS Status; STATIC BOOLEAN mInReadyToBoot = FALSE; + Status = EFI_SUCCESS; if (!mInReadyToBoot) { MmHandle = NULL; Status = MmInstallProtocolInterface ( -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'