From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.45]) by mx.groups.io with SMTP id smtpd.web12.13530.1609766594548026702 for ; Mon, 04 Jan 2021 05:23:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=FvTXzB/w; spf=pass (domain: arm.com, ip: 40.107.13.45, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S1DKDHFiA/39JaSXH8Sm5sgRQaOHj90r17y9DNubSXA=; b=FvTXzB/wPtio7RitdowoLix5auZjxEjyA+lgY3U9XR1mtca8mn2CPYIgZZgy3PZ301IvoW7soZaPv40RpElWJbqUepR2ME+DyhKzk71UMutCqVTN1FTikbH9CW+yjmA4oSPCCAphmo6EuvxHdrn5kaDi3AENWF3lx5c+X3Nde20= Received: from DB6PR0402CA0023.eurprd04.prod.outlook.com (2603:10a6:4:91::33) by PA4PR08MB6126.eurprd08.prod.outlook.com (2603:10a6:102:ea::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.24; Mon, 4 Jan 2021 13:23:10 +0000 Received: from DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::60) by DB6PR0402CA0023.outlook.office365.com (2603:10a6:4:91::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19 via Frontend Transport; Mon, 4 Jan 2021 13:23:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT062.mail.protection.outlook.com (10.152.20.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:23:10 +0000 Received: ("Tessian outbound 39646a0fd094:v71"); Mon, 04 Jan 2021 13:23:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9a7518c3003891ae X-CR-MTA-TID: 64aa7808 Received: from f5c3c9c2553b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 77E24AE0-2590-47D7-A4AD-CAA5A3E14E0D.1; Mon, 04 Jan 2021 13:22:46 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f5c3c9c2553b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jan 2021 13:22:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qe/3T0eBY3Md9BaBNcY9uQTj395zLO2nhU9FlW57+lwjkW7yorLxuHsa+DxKhK5tya6cHaYlnj7V+HehgUauraTPhD7X30aySVU6gTMbwvJj9v9e8bnXh47Z2kKZe/Qv/rfQ82DJgV/sEakIlQNH3K0ktGnCF81tx2hUVe5KGlq8vID6slVLmJhZbWEdLE8eE/u18gr8l/9DMsMspXOlFfOE3pfOX1E/LKlhNs38l+sxQPlk5Y8QB3x8dq0YAY8oEsELv6WZLdME51o4Y5cJUEaGkko8ceeVL3I6DUTmB8A/m/5eRV5n24qzD8F09qu8yKGv8hFWExBAsCIHrhAo9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S1DKDHFiA/39JaSXH8Sm5sgRQaOHj90r17y9DNubSXA=; b=MFONT8KvRKPsnhcWOMnQnVRWZawOohgS1cQNLHS1D4l2dfFGXQBwXAt3JCSJjsVgSXKkjXsBqOFnbk/oam0nycRGg1cLuWDXLPpDFxO+l+zBedBjVl2UUwDR/OU6bhrOL1YZl3X/pjE1roQON2wshzkVLxZZWb1qFHl1hDRyNthgUdgk4QkrDLZC0gHplANJTDIxhduyBBUIMPv0kRCb+71z2+yI1AMYVqIsSIdgRRzg3FKLVqr5b4nCodkFXJcu7kCG8z4lcf+sP9ulkzMzxrelnx93UWOupDA04trawWqulvAyuHPpQbxtpW2brM2N3tDdLZol4owDzGUI/t6PJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S1DKDHFiA/39JaSXH8Sm5sgRQaOHj90r17y9DNubSXA=; b=FvTXzB/wPtio7RitdowoLix5auZjxEjyA+lgY3U9XR1mtca8mn2CPYIgZZgy3PZ301IvoW7soZaPv40RpElWJbqUepR2ME+DyhKzk71UMutCqVTN1FTikbH9CW+yjmA4oSPCCAphmo6EuvxHdrn5kaDi3AENWF3lx5c+X3Nde20= Received: from DB7PR05CA0043.eurprd05.prod.outlook.com (2603:10a6:10:2e::20) by DBBPR08MB4837.eurprd08.prod.outlook.com (2603:10a6:10:d9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20; Mon, 4 Jan 2021 13:22:43 +0000 Received: from DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::e) by DB7PR05CA0043.outlook.office365.com (2603:10a6:10:2e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19 via Frontend Transport; Mon, 4 Jan 2021 13:22:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT038.mail.protection.outlook.com (10.152.21.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:22:43 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Mon, 4 Jan 2021 13:22:28 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Mon, 4 Jan 2021 13:22:26 +0000 Received: from E107187.Arm.com (10.57.38.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Mon, 4 Jan 2021 13:22:26 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v3 15/26] StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint Date: Mon, 4 Jan 2021 13:22:02 +0000 Message-ID: <20210104132213.22376-16-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20210104132213.22376-1-sami.mujawar@arm.com> References: <20210104132213.22376-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c4c7c1cb-f250-484b-57c5-08d8b0b3e1db X-MS-TrafficTypeDiagnostic: DBBPR08MB4837:|PA4PR08MB6126: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5bzWp6MniKWzoheXTjIIJK7opbixW70/BfRAjZFr6DmVXhWHhRoFWD/LzcCRYjlpSiMl0fpFPSCz5Tu4MAZ4J2K3Z/AA5v3SwUzJ9OhWMXeFiVvjp1lOj6nhuSAgZ2g33OEL+G7qVuyanmKZ0/VJFsHYlJ1DYOMBjv1DhZhQr6zv/OeDFgLzOdMWuupGFEVytA5pFQeGqmZPjdu8NwB258OY1htO6lP09LnKlq92HvmHNy32R1m1g4EdUzg7HXOBVMsDv2jyUgC/13qdioZNslSZwL4NpzlXHPmHmT5wg57nziQUfrdAoP7690QczYyRGEQwshHDoFL/Bd0ka/unDiDljwbi29Xh/SYxcBaF3/e+w6NKcZRxSUWRHG6WFH04434JK204Mip/LVYs9JQgKcMZ0MTBceWw4uVV6OiHOJgqdQRF1Y0hkLG3RzF7uakYfXhRxvzF4gh8o6RpOWqLr+oB6XIjF/GrjXfMKkebZnyDpbopioptkpQiRHuPNcNn+j1uKeQOuDXB8QdLpZ0kWgTtf7HuKOPkcK7F3YUOd80= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(346002)(396003)(376002)(136003)(39860400002)(46966006)(1076003)(82740400003)(54906003)(36756003)(8936002)(83380400001)(70586007)(316002)(2906002)(186003)(86362001)(44832011)(26005)(5660300002)(70206006)(426003)(47076005)(478600001)(336012)(7696005)(2616005)(356005)(6916009)(4326008)(82310400003)(6666004)(8676002)(81166007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4837 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a25adbfa-a53c-4885-3684-08d8b0b3d1bc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 296cH9dBW0lUTmQOaU7nKE9CK0VeJyg7EI66+eyXm1XtWjCwUMTkgl0uZ3Zy3ZEEEIRFnRoiukzfK3rtnardTePW4GbMrXdgdkGTIm/TQ0d8StBFYBB3+D7Y/pSK8OraiMSV1GW9UKymzINcQMphoN6TRHNoW3tmfmRftDYBYcsKRjS2ewE8QSLUVfQ7zoCugf7sVcI9z9jCimT9Ck7W4zEapMSgxW/AG8aC0J9rFPmwqHreGlA/hb4FULlbM65r8dKNYXH8ITH+zYNrKLAQNpIMp/R2x9WipaHYagUB54GVTrCfeT/wAwp06bvus5VaNQNXlTx18En2Kx9859zxMLMHKPrHv/kCJM0uK0eGAhcxqlzuRKFzPS4D9cy+lTya7Gw3s1/J1zHch3pYgN2iGYaNILtSA6fQfKJWZgjignwVtIoutHGoroFCW/yJiZRmU5NcHIv0ZZ1WsrUzLK1EnTJGyXNnsY+UDZsfUITeuftCP4OWT8ZDnHQBnmxZk2E1uym72mMKRpAoA/deCvCjv0JLfWXy/WEQe+joQyu95jk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(396003)(136003)(376002)(346002)(39860400002)(46966006)(44832011)(70206006)(6916009)(70586007)(8936002)(336012)(1076003)(5660300002)(2906002)(47076005)(26005)(478600001)(82740400003)(4326008)(6666004)(426003)(86362001)(82310400003)(2616005)(186003)(316002)(81166007)(54906003)(83380400001)(8676002)(36756003)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2021 13:23:10.7748 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4c7c1cb-f250-484b-57c5-08d8b0b3e1db X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6126 Content-Type: text/plain Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150) Fix the ECC reported error "[9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 in Comment". Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v3: - No code change. Added bugzilla ID and resending patch [SAMI] with v3 series. v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h | 13 ++++++++----- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c | 6 ++++-- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 7 ++++--- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h b/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h index 34c43897dded9aebe1470f2dbfe96b93590a9e45..b176e56e789b0bc766e48a6083512a9d0ae3ebc3 100644 --- a/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h +++ b/StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h @@ -140,8 +140,9 @@ LocateStandaloneMmCorePeCoffData ( Use the boot information passed by privileged firmware to populate a HOB list suitable for consumption by the MM Core and drivers. - @param CpuDriverEntryPoint Address of MM CPU driver entrypoint - @param PayloadBootInfo Boot information passed by privileged firmware + @param [in, out] CpuDriverEntryPoint Address of MM CPU driver entrypoint + @param [in] PayloadBootInfo Boot information passed by privileged + firmware **/ VOID * @@ -155,9 +156,11 @@ CreateHobListFromBootInfo ( /** The entry point of Standalone MM Foundation. - @param SharedBufAddress Pointer to the Buffer between SPM and SP. - @param cookie1. - @param cookie2. + @param [in] SharedBufAddress Pointer to the Buffer between SPM and SP. + @param [in] SharedBufSize Size of the shared buffer. + @param [in] cookie1 Cookie 1 + @param [in] cookie2 Cookie 2 + **/ VOID EFIAPI diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c index 08b12c45bc2937942a85ee66cf1a6d80bfa41e69..887f2559dfd05bedb66bb86cd17021efa6a4aea0 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c @@ -2,7 +2,7 @@ Creates HOB during Standalone MM Foundation entry point on ARM platforms. -Copyright (c) 2017 - 2018, ARM Ltd. All rights reserved.
+Copyright (c) 2017 - 2020, Arm Ltd. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -46,7 +46,9 @@ extern EFI_GUID gEfiArmTfCpuDriverEpDescriptorGuid; Use the boot information passed by privileged firmware to populate a HOB list suitable for consumption by the MM Core and drivers. - @param PayloadBootInfo Boot information passed by privileged firmware + @param [in, out] CpuDriverEntryPoint Address of MM CPU driver entrypoint + @param [in] PayloadBootInfo Boot information passed by privileged + firmware **/ VOID * diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c index 3d3c772019df9afe9b8ec77019c776ea7c3b55fb..19472fa659a20d84eebd9e31e20eabab6596f799 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c @@ -214,9 +214,10 @@ GetSpmVersion (VOID) /** The entry point of Standalone MM Foundation. - @param SharedBufAddress Pointer to the Buffer between SPM and SP. - @param cookie1. - @param cookie2. + @param [in] SharedBufAddress Pointer to the Buffer between SPM and SP. + @param [in] SharedBufSize Size of the shared buffer. + @param [in] cookie1 Cookie 1 + @param [in] cookie2 Cookie 2 **/ VOID -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'