From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.48]) by mx.groups.io with SMTP id smtpd.web09.13175.1609766594282625521 for ; Mon, 04 Jan 2021 05:23:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=WLktvkIC; spf=pass (domain: arm.com, ip: 40.107.13.48, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NVXaJAKJNj5kLCrU5uh04Xe6Ut/AxureR1GZm3cnEXo=; b=WLktvkICQzCupxTXBrfQ2CyEAkO6EMnI3TT32+VnDLr/98sNFkwBqYSvMFKx+5DoQMUQOEcc+FqKZkxITiOUpFM5TRoP1jXAbitQFOc4wen/ICsV0pan0gIQdFbe7Hhb5l7cNS2ivG9KpWTL1Mm8lWWajGEPoI4Lp+jbRON1Tuw= Received: from DU2PR04CA0124.eurprd04.prod.outlook.com (2603:10a6:10:231::9) by PAXPR08MB6525.eurprd08.prod.outlook.com (2603:10a6:102:154::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19; Mon, 4 Jan 2021 13:23:11 +0000 Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:231:cafe::a8) by DU2PR04CA0124.outlook.office365.com (2603:10a6:10:231::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20 via Frontend Transport; Mon, 4 Jan 2021 13:23:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:23:10 +0000 Received: ("Tessian outbound 6af064f543d4:v71"); Mon, 04 Jan 2021 13:23:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9ebcc7da2979dd8f X-CR-MTA-TID: 64aa7808 Received: from 963ae05b93d2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CA6A788E-DE9C-41D0-BA61-860A80B9762A.1; Mon, 04 Jan 2021 13:22:48 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 963ae05b93d2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jan 2021 13:22:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a3QuLA2DekqwKrZkN8Fa5FF4d8IFfTy3rh5J/B+z+W55tJEhM7uHHYYdlBPI/BNgdYnVBOxpWS6/aqNyktGv8G5JWOJy3m02i9mOv3Lm2riHO9MnWNLa5soXNL8bXfu/Hred5Bzp5z1fTWn5v+1imZSpiKyVuwL9d/LmKuiY7uo5F05Rlm+DWPGPn/SQk+67uclwulRsXg1CC1xPAlAD6hEqPW1oCfIriwgOeK4GKbcTgDhGGm2ftPkroA51UWOwhoWWxfduDVBb8Nkn2enog9h3twKNXK3GEPPKpbfYDdGU5mc77X4yv+ezFFTPPTwk1zwnfQROXDX7B7cnox5W7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NVXaJAKJNj5kLCrU5uh04Xe6Ut/AxureR1GZm3cnEXo=; b=VE+0fYTOmhGAg5wbNcc8cNSSPXt7y0/ToSi7lLHahtpMGt6hMY2h7h9OTPiBCD3NwP3E0gdhQgPyJJ2hdTYv1HcAoAnUoBfJSEhxYmD/ySKvE2lExo08kYlED08RvqShyXywvQB/bIXdvaUBrHuYL8ZDaAaVCXmBYAqcEbh0ApNRM2KqBUZTdFPwuQQTS1e0XQRbwU1vKytPfbYC+FZxOkh4JMR8KyC8hSR6+pg15yUnrBOe5nNbm8bFhWGifsoA9PYmb9BCGtpAPOQK9XOynLPmKd85RjNsq1ipRNn0c5Ku1oIz8bqL+/tp++aJo0J7yxx+U/8R8wvyjaMVUeUOuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NVXaJAKJNj5kLCrU5uh04Xe6Ut/AxureR1GZm3cnEXo=; b=WLktvkICQzCupxTXBrfQ2CyEAkO6EMnI3TT32+VnDLr/98sNFkwBqYSvMFKx+5DoQMUQOEcc+FqKZkxITiOUpFM5TRoP1jXAbitQFOc4wen/ICsV0pan0gIQdFbe7Hhb5l7cNS2ivG9KpWTL1Mm8lWWajGEPoI4Lp+jbRON1Tuw= Received: from DB6PR0501CA0036.eurprd05.prod.outlook.com (2603:10a6:4:67::22) by HE1PR0802MB2604.eurprd08.prod.outlook.com (2603:10a6:3:db::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.22; Mon, 4 Jan 2021 13:22:46 +0000 Received: from DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:67:cafe::2b) by DB6PR0501CA0036.outlook.office365.com (2603:10a6:4:67::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19 via Frontend Transport; Mon, 4 Jan 2021 13:22:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT024.mail.protection.outlook.com (10.152.20.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:22:45 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Mon, 4 Jan 2021 13:22:34 +0000 Received: from E107187.Arm.com (10.57.38.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Mon, 4 Jan 2021 13:22:33 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v3 22/26] StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint Date: Mon, 4 Jan 2021 13:22:09 +0000 Message-ID: <20210104132213.22376-23-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20210104132213.22376-1-sami.mujawar@arm.com> References: <20210104132213.22376-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ace0ba51-b763-4699-28ae-08d8b0b3e1df X-MS-TrafficTypeDiagnostic: HE1PR0802MB2604:|PAXPR08MB6525: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tzHOZLUVLfYh7RhODu2QCsukCvFU+W+uRomWcfEqimKBQpVT/yqD3xoqROKTGwj8QBU9C70OTw2vp1jv1Tby2gGgjYoncoeWu+Hl18vvcew/0vYMD2r9p3B8n+dlfVukicjkKokOY5282Y7S8eS6vj1/oD3m51kabWuhTLvLutsZ2erYa66xsEC2ldfCwM2lGajpRSSVrLi6U7G/DIzlqyhWQZv5FsmrZBnm+G80unNXCI143lDWjvJWZhvmK/8gR2UTLiiIRVzVCB6BpGGwTd0T6JuJMPumAsylNSs1SfQR5kHDz2wagKJwuXH6qKVwYe3fiHFXMlnM5vFdnbBq6jBh9Hl5xxptsvb9plOeRNP1CfyBqA3b2LUwJiT1P4tZxfDXmhxpcVh8OjM0yYM6CSEbGGdZN5H1p3NvDcAxzM5TSXO+dGyckVZXeOkMDWN8DGmZO4/Bv8I70O/e5qqakiavZPXjOgVDVFz49aJHuRMtE8FMoNw0jDnCCubM03f6s0ZD1Bg/yB5evhzXMuTg481CoKM0ZGRkql7UiwHheUk= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(136003)(376002)(346002)(39860400002)(396003)(46966006)(2616005)(36756003)(26005)(7696005)(6916009)(70586007)(86362001)(70206006)(54906003)(426003)(83380400001)(478600001)(8676002)(4326008)(44832011)(47076005)(8936002)(82310400003)(186003)(1076003)(81166007)(356005)(82740400003)(5660300002)(336012)(6666004)(2906002)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2604 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c6be652f-97f0-4332-2850-08d8b0b3d2ff X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: abmW9xBkNFkvZwfxpsmpKcZIuGQ5uS8xssy3hsPW7nK3eZ76WWW/QC7+5nXcPpUt2SVjHNZUXVZVgJ3TkNH7afsPgN1zzAHNOoTkNNj136oeR/kKbTXyKEfrhfCMi1tjdsJNgjAXegQDfe+cT3cCrquFSGwwWY40XPxRr5uAK7I6kYhWTm0Sn5XD4W6T3CdAwjDL6SrZGVb3tbGngiE8jxK2LwsOXMMkHB3b66yrSbvuhipejHXYOwSNfU1g5kOJsPHsGbg+2aHiZkJuC8Fjm7UmZ1uzSvC9R42XJx29e2aOgOY5Wi3P3bv+yTOibqbBXfmBe8Ce1Dep6w78LOnW+vIiydXKVzRnkMvkrZTyKlexPrGfuJlvuCQQicGLRjps5i8tstb9wLrQloQAQsaA5QDVPJQ8nOUVqmZunNqQg9GvohZKH3tEx1rh+FxNcUGmYePl3zgpNNN2M1Q+VHIRkPiIs/FgEzXQc78g/W5gOiPDHJHq3zLHTuDqbxyDwTPJgzo4PVzWQaPpkW1QUel2RkO9e2MAQYRUI72l/Q90XV0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(376002)(346002)(396003)(136003)(46966006)(8676002)(8936002)(478600001)(82310400003)(6666004)(44832011)(2906002)(36756003)(82740400003)(336012)(316002)(7696005)(54906003)(426003)(2616005)(47076005)(26005)(4326008)(83380400001)(1076003)(186003)(86362001)(6916009)(70206006)(81166007)(70586007)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2021 13:23:10.7988 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ace0ba51-b763-4699-28ae-08d8b0b3e1df X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6525 Content-Type: text/plain Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150) The ECC tool reports error [8005] Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' for the constants SPM_MAJOR_VER, SPM_MINOR_VER & BOOT_PAYLOAD_VERSION. Fix this by changing converting these constant variables to #defined values. Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v3: - No code change. Added bugzilla ID and resending patch [SAMI] with v3 series. v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c index d097c50360adce7f2280ea4d575971927860706e..1363d54ceebfcbc1d64ff476d4f33bdd626a2422 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c @@ -31,10 +31,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define SPM_MINOR_VER_MASK 0x0000FFFF #define SPM_MAJOR_VER_SHIFT 16 -CONST UINT32 SPM_MAJOR_VER = 0; -CONST UINT32 SPM_MINOR_VER = 1; +#define SPM_MAJOR_VER 0 +#define SPM_MINOR_VER 1 -CONST UINT8 BOOT_PAYLOAD_VERSION = 1; +#define BOOT_PAYLOAD_VERSION 1 PI_MM_ARM_TF_CPU_DRIVER_ENTRYPOINT CpuDriverEntryPoint = NULL; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'