From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.62]) by mx.groups.io with SMTP id smtpd.web10.13325.1609766554596713001 for ; Mon, 04 Jan 2021 05:22:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=cjd6NkOW; spf=pass (domain: arm.com, ip: 40.107.20.62, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V5/uQi+CYgHeY1uRsQeyGlZwRtsOTXZ+n34iIdSXPWg=; b=cjd6NkOWsL+gFWso4WSFr4kQ3LHRFhK7LVawYr+vFh/LRLBdTRD3BxW2cNcv3flavOgkd5dic/JzQJkjxqsNzcZcZkMa86bv7yBe2pxv2/zkXMaV98ddPU6DFAZEG/4Fp1YzSuNk8v3YJbNn6F4uG7rE5iEyQOm+tCv0SG+zlyI= Received: from DB6PR0301CA0085.eurprd03.prod.outlook.com (2603:10a6:6:30::32) by VI1PR0801MB2045.eurprd08.prod.outlook.com (2603:10a6:800:89::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.23; Mon, 4 Jan 2021 13:22:31 +0000 Received: from DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::1f) by DB6PR0301CA0085.outlook.office365.com (2603:10a6:6:30::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19 via Frontend Transport; Mon, 4 Jan 2021 13:22:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT046.mail.protection.outlook.com (10.152.21.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:22:30 +0000 Received: ("Tessian outbound 665ba7fbdfd9:v71"); Mon, 04 Jan 2021 13:22:30 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d9c554c5d71d70fc X-CR-MTA-TID: 64aa7808 Received: from 4d66278076c4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CB064299-828B-4CAF-82EB-A70E12E1BCAE.1; Mon, 04 Jan 2021 13:22:25 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4d66278076c4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jan 2021 13:22:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YVHWuAGOXKrxw4UOShAvjovw8n5KLX0htqtNTFNaVG5uv6XX0tNDzcAwuLo8Z21GtxKQ+ZZyg4uYo31zHFxg3tlyqOPXD8c40ouA11oYXjgdG2Eg1r4RKXGW9mCkZ/rVd02MgQbb7v0VgQDyPgfCIYGLXSfy2b5qupvtWSi9L/44YCXRshYe74ryGSAu/wzyxgEWO33v0aAVWn0e0kzjEv1brU7RGdLJMl9eJWv5bxCxzomClVjnKyTZVUVaG52KF8z5J+GylHvVlp6XLA3ItW5dy6oWkXgBQoG8Hm2e43JHTHPOcCEQPtm3CbWQFTykvswWIUHFHqyO6yw7PrS3kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V5/uQi+CYgHeY1uRsQeyGlZwRtsOTXZ+n34iIdSXPWg=; b=NTbQQP+XsLBRCM+vXAMyZh5wcpKd2D7FUNXXOmNC3WtlhyrI4VxcccWChxp1CI0jiP2ri2tJgu6xScCSrkLDv669eTJoxeM7HCzwtbtRpFGWQBUAYuaDPV4pFV4wDD+oTVIqcMBkUp7EH2HilMtS7Unu+LWXvXYbDEPUorlvDGBeXl6/hXbFmpv4CMpvRjtJC0U0eT3IE3HlgbJOT5pc4PDgVv9SRvxLCQ3xl1NoUj/cnw96GvHzb0wbSfKe7+FjC+pZRWCYbi79MF0hSNzj+8cSbodWXALpzX1wHktXOXhx0Z4vGAqr2nWr6eDMPKeb1v2Ys6BucF+qV38zY8YvfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V5/uQi+CYgHeY1uRsQeyGlZwRtsOTXZ+n34iIdSXPWg=; b=cjd6NkOWsL+gFWso4WSFr4kQ3LHRFhK7LVawYr+vFh/LRLBdTRD3BxW2cNcv3flavOgkd5dic/JzQJkjxqsNzcZcZkMa86bv7yBe2pxv2/zkXMaV98ddPU6DFAZEG/4Fp1YzSuNk8v3YJbNn6F4uG7rE5iEyQOm+tCv0SG+zlyI= Received: from DB6P193CA0021.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::31) by DBAPR08MB5656.eurprd08.prod.outlook.com (2603:10a6:10:1a2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20; Mon, 4 Jan 2021 13:22:24 +0000 Received: from DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::49) by DB6P193CA0021.outlook.office365.com (2603:10a6:6:29::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20 via Frontend Transport; Mon, 4 Jan 2021 13:22:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT011.mail.protection.outlook.com (10.152.20.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:22:24 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Mon, 4 Jan 2021 13:22:18 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Mon, 4 Jan 2021 13:22:17 +0000 Received: from E107187.Arm.com (10.57.38.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Mon, 4 Jan 2021 13:22:17 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v3 04/26] StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher Date: Mon, 4 Jan 2021 13:21:51 +0000 Message-ID: <20210104132213.22376-5-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20210104132213.22376-1-sami.mujawar@arm.com> References: <20210104132213.22376-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4d1f0fb-09ef-457d-8371-08d8b0b3ca1b X-MS-TrafficTypeDiagnostic: DBAPR08MB5656:|VI1PR0801MB2045: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rqzTdm2A/iLWb6QECUxow//920INgKITxXsdjpMihc/gsaIytPVNhXbrCn6BuT3d59gm2wJFRxyH4E15h308sVAZQLua3vPvWhbaB5H7oX2OEkYf47Un60BtZ0JmqZV9zoAqzQnzNWpLG9tGmsKfQOdIx44GvDfM+zxoel8jY4QmJt3KzarXDxj2Bu2D31hY/CY0GLYua1az2KnzXAzQz8fs3x1C1TbABOsNKAnNQXZuFRNw4rIuH/jDy8lRELaSMlllPh8bm/pwL0bhWIxPilfK3GvBeAW+o+l6VVSoc2SSvi2bBzvnlSE3jG6yTRLMdTX9v9mbP21Qi3DRTpy9bH4djhngTw78zXdNscjBRELyKPP00W43U9DU4kgOjdcUz5CYGVUYu/Tb36ZNrs3T97hVsCpUqLlb1q0p1TtlSB0u/5RssaHcYYBy3AZ8/xWVlM58fFaunvAHPvmFny4NdlLhr9f0IVtfXd/9n3+MvNBEELhZgPGfC5IHDbouqx4mrNN7XMzy5JkjHmRauU1RSPgtdkurZ8GPQ0xKJY3n6tA= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(396003)(376002)(136003)(346002)(39860400002)(46966006)(2616005)(47076005)(316002)(6666004)(44832011)(26005)(336012)(54906003)(478600001)(426003)(82310400003)(6916009)(8936002)(8676002)(186003)(4326008)(5660300002)(1076003)(7696005)(81166007)(83380400001)(70206006)(70586007)(2906002)(86362001)(36756003)(356005)(82740400003);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5656 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 95f6326f-9014-413c-2cc5-08d8b0b3c640 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7ybOkwmtoTD0GOQyuJ8LcQSLDdaPzXhWFpcR+8AQ4Tfyhvi23iOf4VKnMH0qeyV9U68cG5kWn2vjkJuC1J5ooHNwEHtY9gcn+3m9UUc0PUG5RxMlt3SX9GI4box16+8Ua7S8Zb1VH3N0+7oJti+fesWLViI8Kx+j/h8INZefyhRk99hYFL5ofUAIdty82DgUDvUS1SplAlD1L22QKB/MElbWwR9l1Q63tCC4S+ml2ACW118Ex8CsbCiyBHbNzOxzHHBrYfyeAmvB5CTtMRTzcYUdQ2a0ukUIMH4uxvQN1aQYTyZUiI8+X7vpA6Hk4WmJFCUxtFC7wQofDdkv3x4q/wbUAjdTd+kodluQ5xzDamoLpiyma796CFY0O1eUikAb44JNOO30I39Zm6LWF68rNP+RPZtPT+z8XPEph3ZPpxPjfbpi1LEHVu5RyTZi1TXKYd/BpxV+KY5s8e7NJoTCdLAHOYUIEkZksNllDYf1fIyaX7K4/bQ7PE+gmosvyYRs0NIhIhjTHIwSsL4s+d0T25l4dSre5UF1IlPaV+ui59M= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(376002)(346002)(39860400002)(136003)(396003)(46966006)(5660300002)(86362001)(81166007)(36756003)(47076005)(44832011)(8936002)(70206006)(83380400001)(2616005)(6916009)(426003)(82740400003)(336012)(478600001)(186003)(26005)(1076003)(82310400003)(316002)(8676002)(54906003)(6666004)(70586007)(4326008)(7696005)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2021 13:22:30.9280 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4d1f0fb-09ef-457d-8371-08d8b0b3ca1b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2045 Content-Type: text/plain Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150) Fix the ECC reported error "[9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 in Comment" Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v3: - No code change. Added bugzilla ID and resending patch [SAMI] with v3 series. v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Core/Dispatcher.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c index 45b17fe3acfec9c056396873006c03f668c1aed6..26e5a6933f8d5b5a33865ff63d3ae4bea9fc8c09 100644 --- a/StandaloneMmPkg/Core/Dispatcher.c +++ b/StandaloneMmPkg/Core/Dispatcher.c @@ -834,18 +834,14 @@ FvIsBeingProcessed ( The Discovered list is never freed and contains booleans that represent the other possible MM driver states. - @param Fv Fv protocol, needed to read Depex info out of - FLASH. - @param FvHandle Handle for Fv, needed in the - EFI_MM_DRIVER_ENTRY so that the PE image can be - read out of the FV at a later time. - @param DriverName Name of driver to add to mDiscoveredList. + @param [in] FwVolHeader Pointer to the formware volume header. + @param [in] Pe32Data Pointer to the PE data. + @param [in] Pe32DataSize Size of the PE data. + @param [in] Depex Pointer to the Depex info. + @param [in] DepexSize Size of the Depex info. + @param [in] DriverName Name of driver to add to mDiscoveredList. @retval EFI_SUCCESS If driver was added to the mDiscoveredList. - @retval EFI_ALREADY_STARTED The driver has already been started. Only one - DriverName may be active in the system at any one - time. - **/ EFI_STATUS MmAddToDriverList ( -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'