From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.68]) by mx.groups.io with SMTP id smtpd.web10.13328.1609766555678412670 for ; Mon, 04 Jan 2021 05:22:36 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=zuF4kaoX; spf=pass (domain: arm.com, ip: 40.107.6.68, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C38LicE/k0aIcXdo67h+IeFPppYnVq1+wGgUXT6EDXA=; b=zuF4kaoXvRd6oRzUDcMnyYTRQ0IILp61UXvdYa+tjUc9F1l/wIYwQEAOa/Epq0DjNhtNddNwF2WgltfgpkVAEWeJ/pXoDWNzP39WSquqKtvMbSZYR86EEVfdKxqL1gGBeSGNegK46kLwTsbFyb83CK+TsFTIbTJ/h2esh8T6DUQ= Received: from DB6PR0201CA0031.eurprd02.prod.outlook.com (2603:10a6:4:3f::41) by AM0PR08MB3908.eurprd08.prod.outlook.com (2603:10a6:208:106::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.22; Mon, 4 Jan 2021 13:22:33 +0000 Received: from DB5EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::66) by DB6PR0201CA0031.outlook.office365.com (2603:10a6:4:3f::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19 via Frontend Transport; Mon, 4 Jan 2021 13:22:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT040.mail.protection.outlook.com (10.152.20.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:22:32 +0000 Received: ("Tessian outbound 39646a0fd094:v71"); Mon, 04 Jan 2021 13:22:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3a2ae100b9adc13c X-CR-MTA-TID: 64aa7808 Received: from 32fb7aed6461.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4265E70D-B125-4147-9AC3-F3B4364588BE.1; Mon, 04 Jan 2021 13:22:27 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32fb7aed6461.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jan 2021 13:22:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5gX+1iZMhv1wwvMsNoo7RH6aHnmHgSH05QKpEutmBonMgQBP+7bMVUOjZt0oX83TYok2uF6LLXt5AaZmSwBoTuxlnwWSxGg+BjA60HekE7pLwcnb1S4kJ7boTTTUwM9o2+2lTLFxX1CvfYT95RwBd+sqVrnhrl+C5t3ZxqDii+43XPtrOmsN1P1/jl8PP/nECxZFvsUnkl9iWJ5KcPq0g9ZRYmb+xbkrNBc7rCP4/yL9FpWGvK7fSFbljXo2TF2Lod/ngkncno1HK6GZkveAJwWxGq4Xt8WaV/V7xBC70RqZC4P3c3czNsmf8t2eN0kO+0wbpjVqj2MmTTHxcQUfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C38LicE/k0aIcXdo67h+IeFPppYnVq1+wGgUXT6EDXA=; b=PKy75EqTTsBtL2edgmFEZ4zKKGu6yK1OqBX1YCoBsguKAC5teQ/mcB9VYpn0/fwXgQdWkAxVAWXzN28IfvhK7vIDi+hEeL/yCACFgKQW2sQUPRTExu6aHEph+Zlo/yxINHrplnpqy5+pYUbYoAgKMF6cY7cWK7Mk/Da1drXu7VTKBQ8IxV06Q/cBN0zUk6UkuY8o6gk3+O0pNQJGCAxureBIPScuk9EsEtmP21iu2pKCI7KUcgGLicNjJ1D9/0T6wxqJeEBL/zzDnjPZvY740HJYv5TKHOFE9cTbr4BxVotvp2AOSaG8pOVJ5fp44UI19cSRymPtMeWacVOGNstzew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C38LicE/k0aIcXdo67h+IeFPppYnVq1+wGgUXT6EDXA=; b=zuF4kaoXvRd6oRzUDcMnyYTRQ0IILp61UXvdYa+tjUc9F1l/wIYwQEAOa/Epq0DjNhtNddNwF2WgltfgpkVAEWeJ/pXoDWNzP39WSquqKtvMbSZYR86EEVfdKxqL1gGBeSGNegK46kLwTsbFyb83CK+TsFTIbTJ/h2esh8T6DUQ= Received: from DB6P193CA0008.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::18) by PR3PR08MB5724.eurprd08.prod.outlook.com (2603:10a6:102:85::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.21; Mon, 4 Jan 2021 13:22:26 +0000 Received: from DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::ee) by DB6P193CA0008.outlook.office365.com (2603:10a6:6:29::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19 via Frontend Transport; Mon, 4 Jan 2021 13:22:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT011.mail.protection.outlook.com (10.152.20.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3721.21 via Frontend Transport; Mon, 4 Jan 2021 13:22:26 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Mon, 4 Jan 2021 13:22:20 +0000 Received: from E107187.Arm.com (10.57.38.43) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Mon, 4 Jan 2021 13:22:19 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , Subject: [PATCH v3 07/26] StandaloneMmPkg: Fix ECC error 4002 in FwVol helper Date: Mon, 4 Jan 2021 13:21:54 +0000 Message-ID: <20210104132213.22376-8-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20210104132213.22376-1-sami.mujawar@arm.com> References: <20210104132213.22376-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb78bd21-21c9-4b18-2dc3-08d8b0b3cb43 X-MS-TrafficTypeDiagnostic: PR3PR08MB5724:|AM0PR08MB3908: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2657;OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KwPOV3tKLlFHpSIgwQWesS3tqPOGn8X0dNlhTbtpkS8OeMrLiO0vtCUA7C86ikdNQQuU4m68t/gq7Q97Gs0Oi9/sZKssVMiKj/ZtwqcJ/jAQwJSyKpt0iZLizWDGcRTqLNFTUbY1xnMGJAHxEnKs68D9LpkkWO9bKqg15u5V3T4CwDN+uFM5T7HVRW/dRQDtRcKLj+mUwRK+C6mXWyV63pMR/F09LSSMvve390vW85tw9tYF7+K4Yz4jGRfGCqkvwisPygisnR4JNkjiuDFOGvLHuFZ44xraytvJp1fAm5aHEBPYYbELTQIEqfF/qDXlE9ukrbM8osORjfn7bnUwaxPumcmQIrWtHDVYjAAOR7lYeX1AxWbu0+q6zmLoE1n7HEbBqlfBqCyaZl8aB/HvpINlyCfi6YZGzrDJ6NMIvDezn1NaO4Nk/7Ww2r76Danox51DmMExrzd8dg3/7vqL/CdUaskEhfnTA+HjzoswuNewhmsu0XCpcVwlrSFoX2QVOBzFSW3M540v6GGhU5cDXt+QdMtXypPP86ZpkMJmtHY= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(6029001)(4636009)(376002)(136003)(396003)(39860400002)(346002)(46966006)(2906002)(47076005)(26005)(8676002)(1076003)(4326008)(5660300002)(6666004)(478600001)(2616005)(356005)(36756003)(86362001)(44832011)(81166007)(316002)(54906003)(336012)(186003)(8936002)(426003)(6916009)(82740400003)(83380400001)(7696005)(82310400003)(70586007)(70206006);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5724 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 80f204b2-80b2-46f8-3d9c-08d8b0b3c788 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BbT7/w6HhSSsVhrs4uDmOpF2cJCb6xvUucUSwxkiyGvqki2GSFIbMnBZRNNcBFGKKe67wrI8Nz5mceO23N8x2OXgU98pJ/EhmV6s3mbK2V+gFddBOuBf1EKoyiRcdnQaYxoxE7h5WXjlLsDb6U1+0aSrYDUmI1nm1n+4vdV5Y9kITQdcUsZZxJfkXKrp+BvQBsdDE5K8daXMR8oUd0vdkmk5P78HGt8msMeVa89Lp9m+d3LCZ5VVwzGNR/XSwiXyTyd3J1u5wZX6jzJryl4PWe1Q+tpaXVGtBBF53SADDQtUn0eQS82v+X7/FKuP8K30ElOFexnsAqVyDc8SmD2mjvV5orkJaYAlhhw1S4dOa08FlvApGanHdB0u0AufMQ+HRwdgsWdaeNSvywVj5U10CcXKEfa5UhOy35dFGPvEAJ5OXirS7uZ1pJ2WCwaMP9uUIjJqloQ5z3ss9hndIWGcd7n71B2rNWsPpqOo7Dhp+p4KpXGUzxv5Pe4yYRNOfL1Q0cpM+UjxNssdE38pK0fts2tEQ3QCsSTBxWIvllg3Xk0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(136003)(376002)(346002)(396003)(46966006)(6666004)(2906002)(86362001)(8676002)(6916009)(316002)(47076005)(44832011)(2616005)(36756003)(336012)(4326008)(478600001)(426003)(82310400003)(54906003)(1076003)(81166007)(7696005)(82740400003)(70586007)(70206006)(5660300002)(186003)(8936002)(26005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2021 13:22:32.8677 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb78bd21-21c9-4b18-2dc3-08d8b0b3cb43 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3908 Content-Type: text/plain Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150) Fix ECC Error "[4002] Function header doesn't exist Function [MmCoreFfsFindMmDriver] has NO comment immediately preceding it." Signed-off-by: Sami Mujawar Acked-by: Jiewen Yao --- Notes: v3: - No code change. Added bugzilla ID and resending patch [SAMI] with v3 series. v2: - No code change. Resending patch with v2 series. [SAMI] StandaloneMmPkg/Core/FwVol.c | 29 ++++++++++---------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c index 856d86011d314a33cdee66af77f34fc8b290b509..c441afc3957b0f8c39625d8199a16c3823990e99 100644 --- a/StandaloneMmPkg/Core/FwVol.c +++ b/StandaloneMmPkg/Core/FwVol.c @@ -1,7 +1,7 @@ /**@file Copyright (c) 2015, Intel Corporation. All rights reserved.
-Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
+Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -42,23 +42,24 @@ FvIsBeingProcessed ( IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader ); +/** + Given the pointer to the Firmware Volume Header find the + MM driver and return its PE32 image. + + @param [in] FwVolHeader Pointer to memory mapped FV + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_NOT_FOUND Could not find section data. + @retval EFI_OUT_OF_RESOURCES Out of resources. + @retval EFI_VOLUME_CORRUPTED Firmware volume is corrupted. + @retval EFI_UNSUPPORTED Operation not supported. + +**/ EFI_STATUS MmCoreFfsFindMmDriver ( IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader ) -/*++ - -Routine Description: - Given the pointer to the Firmware Volume Header find the - MM driver and return its PE32 image. - -Arguments: - FwVolHeader - Pointer to memory mapped FV - -Returns: - other - Failure - ---*/ { EFI_STATUS Status; EFI_STATUS DepexStatus; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'