From: "Heinrich Schuchardt" <xypron.glpk@gmx.de>
To: EDK II Development <devel@edk2.groups.io>
Cc: Eric Jin <eric.jin@intel.com>,
G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Barton Gao <gaojie@byosoft.com.cn>,
Arvin Chen <arvinx.chen@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent
Date: Wed, 6 Jan 2021 13:42:15 +0100 [thread overview]
Message-ID: <20210106124215.60368-2-xypron.glpk@gmx.de> (raw)
In-Reply-To: <20210106124215.60368-1-xypron.glpk@gmx.de>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3057
According to table Table 27. TPL Restrictions in UEFI spec 2.8 B:
Event Notification Levels must be "> TPL_APPLICATION" and "<= TPL_HIGH_LEVEL".
In the conformance test for CreateEvent() check that TPL_APPLICATION
results in EFI_INVALID_PARAMETER if the event can be notified.
In the functional tests check that events can be created with
TPL_HIGH_LEVEL.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
.../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
index f71d6d21b8db..5fc0614192bb 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
@@ -190,6 +190,7 @@ BBTestCreateEvent_Conf_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -263,6 +264,7 @@ BBTestCreateEvent_Conf_Sub2 (
EFI_TPL InvalidNotifyTpls[] = {
(EFI_TPL) (TPL_HIGH_LEVEL + 1),
(EFI_TPL) (TPL_APPLICATION - 1),
+ (EFI_TPL) TPL_APPLICATION,
(EFI_TPL) -1,
0
};
@@ -340,6 +342,7 @@ BBTestCreateEvent_Conf_Sub3 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -404,6 +407,7 @@ BBTestCreateEvent_Conf_Sub4 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -478,6 +482,7 @@ BBTestCreateEvent_Func_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
--
2.29.2
next prev parent reply other threads:[~2021-01-06 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 12:42 [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx Heinrich Schuchardt
2021-01-06 12:42 ` Heinrich Schuchardt [this message]
2021-02-01 14:33 ` [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent Samer El-Haj-Mahmoud
2021-02-24 9:08 ` [edk2-devel] " G Edhaya Chandran
2021-02-01 14:37 ` [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx Samer El-Haj-Mahmoud
2021-02-24 9:07 ` [edk2-devel] " G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106124215.60368-2-xypron.glpk@gmx.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox