* [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx
@ 2021-01-06 12:42 Heinrich Schuchardt
2021-01-06 12:42 ` [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent Heinrich Schuchardt
2021-02-01 14:37 ` [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx Samer El-Haj-Mahmoud
0 siblings, 2 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2021-01-06 12:42 UTC (permalink / raw)
To: EDK II Development
Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen, Liming Gao,
Samer El-Haj-Mahmoud, Heinrich Schuchardt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3057
According to table Table 27. TPL Restrictions in UEFI spec 2.8 B:
Event Notification Levels must be "> TPL_APPLICATION" and "<= TPL_HIGH_LEVEL".
In the conformance test for CreateEvent() check that TPL_APPLICATION
results in EFI_INVALID_PARAMETER if the event can be notified.
Run the other conformance tests for TPL_HIGH_LEVEL, too.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
.../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
index c7f0a80f60b3..eb458de5e185 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
@@ -228,6 +228,7 @@ BBTestCreateEventEx_Conf_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_GUID *EventGroups[] = {
@@ -317,6 +318,7 @@ BBTestCreateEventEx_Conf_Sub2 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_GUID *EventGroups[] = {
@@ -411,6 +413,7 @@ BBTestCreateEventEx_Conf_Sub3 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_GUID *EventGroups[] = {
@@ -492,6 +495,8 @@ BBTestCreateEventEx_Conf_Sub4 (
};
EFI_TPL InvalidNotifyTpls[] = {
(EFI_TPL) (TPL_HIGH_LEVEL + 1),
+ (EFI_TPL) TPL_APPLICATION,
+ (EFI_TPL) (TPL_APPLICATION - 1),
(EFI_TPL) -1,
0
};
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent
2021-01-06 12:42 [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx Heinrich Schuchardt
@ 2021-01-06 12:42 ` Heinrich Schuchardt
2021-02-01 14:33 ` Samer El-Haj-Mahmoud
2021-02-01 14:37 ` [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx Samer El-Haj-Mahmoud
1 sibling, 1 reply; 6+ messages in thread
From: Heinrich Schuchardt @ 2021-01-06 12:42 UTC (permalink / raw)
To: EDK II Development
Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen, Liming Gao,
Samer El-Haj-Mahmoud, Heinrich Schuchardt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3057
According to table Table 27. TPL Restrictions in UEFI spec 2.8 B:
Event Notification Levels must be "> TPL_APPLICATION" and "<= TPL_HIGH_LEVEL".
In the conformance test for CreateEvent() check that TPL_APPLICATION
results in EFI_INVALID_PARAMETER if the event can be notified.
In the functional tests check that events can be created with
TPL_HIGH_LEVEL.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
.../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
index f71d6d21b8db..5fc0614192bb 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
@@ -190,6 +190,7 @@ BBTestCreateEvent_Conf_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -263,6 +264,7 @@ BBTestCreateEvent_Conf_Sub2 (
EFI_TPL InvalidNotifyTpls[] = {
(EFI_TPL) (TPL_HIGH_LEVEL + 1),
(EFI_TPL) (TPL_APPLICATION - 1),
+ (EFI_TPL) TPL_APPLICATION,
(EFI_TPL) -1,
0
};
@@ -340,6 +342,7 @@ BBTestCreateEvent_Conf_Sub3 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -404,6 +407,7 @@ BBTestCreateEvent_Conf_Sub4 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -478,6 +482,7 @@ BBTestCreateEvent_Func_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
+ TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent
2021-01-06 12:42 ` [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent Heinrich Schuchardt
@ 2021-02-01 14:33 ` Samer El-Haj-Mahmoud
2021-02-24 9:08 ` [edk2-devel] " G Edhaya Chandran
0 siblings, 1 reply; 6+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-02-01 14:33 UTC (permalink / raw)
To: Heinrich Schuchardt, EDK II Development
Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen, Liming Gao,
Samer El-Haj-Mahmoud
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Wednesday, January 6, 2021 7:42 AM
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Arvin
> Chen <arvinx.chen@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Heinrich
> Schuchardt <xypron.glpk@gmx.de>
> Subject: [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3057
>
> According to table Table 27. TPL Restrictions in UEFI spec 2.8 B:
>
> Event Notification Levels must be "> TPL_APPLICATION" and "<=
> TPL_HIGH_LEVEL".
>
> In the conformance test for CreateEvent() check that TPL_APPLICATION
> results in EFI_INVALID_PARAMETER if the event can be notified.
>
> In the functional tests check that events can be created with
> TPL_HIGH_LEVEL.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> index f71d6d21b8db..5fc0614192bb 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPrior
> +++ ityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateE
> +++ vent.c
> @@ -190,6 +190,7 @@ BBTestCreateEvent_Conf_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> +TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -263,6 +264,7 @@ BBTestCreateEvent_Conf_Sub2 (
> EFI_TPL InvalidNotifyTpls[] = {
> (EFI_TPL) (TPL_HIGH_LEVEL + 1),
> (EFI_TPL) (TPL_APPLICATION - 1),
> + (EFI_TPL) TPL_APPLICATION,
> (EFI_TPL) -1,
> 0
> };
> @@ -340,6 +342,7 @@ BBTestCreateEvent_Conf_Sub3 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> +TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -404,6 +407,7 @@ BBTestCreateEvent_Conf_Sub4 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> +TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -478,6 +482,7 @@ BBTestCreateEvent_Func_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> +TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> --
> 2.29.2
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx
2021-01-06 12:42 [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx Heinrich Schuchardt
2021-01-06 12:42 ` [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent Heinrich Schuchardt
@ 2021-02-01 14:37 ` Samer El-Haj-Mahmoud
2021-02-24 9:07 ` [edk2-devel] " G Edhaya Chandran
1 sibling, 1 reply; 6+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-02-01 14:37 UTC (permalink / raw)
To: Heinrich Schuchardt, EDK II Development
Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Arvin Chen, Liming Gao,
Samer El-Haj-Mahmoud
Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Wednesday, January 6, 2021 7:42 AM
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Arvin
> Chen <arvinx.chen@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Heinrich
> Schuchardt <xypron.glpk@gmx.de>
> Subject: [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3057
>
> According to table Table 27. TPL Restrictions in UEFI spec 2.8 B:
>
> Event Notification Levels must be "> TPL_APPLICATION" and "<=
> TPL_HIGH_LEVEL".
>
> In the conformance test for CreateEvent() check that TPL_APPLICATION
> results in EFI_INVALID_PARAMETER if the event can be notified.
>
> Run the other conformance tests for TPL_HIGH_LEVEL, too.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> index c7f0a80f60b3..eb458de5e185 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPrior
> +++ ityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateE
> +++ ventEx.c
> @@ -228,6 +228,7 @@ BBTestCreateEventEx_Conf_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> + TPL_HIGH_LEVEL,
> 0
> };
> EFI_GUID *EventGroups[] = {
> @@ -317,6 +318,7 @@ BBTestCreateEventEx_Conf_Sub2 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> + TPL_HIGH_LEVEL,
> 0
> };
> EFI_GUID *EventGroups[] = {
> @@ -411,6 +413,7 @@ BBTestCreateEventEx_Conf_Sub3 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> + TPL_HIGH_LEVEL,
> 0
> };
> EFI_GUID *EventGroups[] = {
> @@ -492,6 +495,8 @@ BBTestCreateEventEx_Conf_Sub4 (
> };
> EFI_TPL InvalidNotifyTpls[] = {
> (EFI_TPL) (TPL_HIGH_LEVEL + 1),
> + (EFI_TPL) TPL_APPLICATION,
> + (EFI_TPL) (TPL_APPLICATION - 1),
> (EFI_TPL) -1,
> 0
> };
> --
> 2.29.2
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-24 9:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-06 12:42 [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx Heinrich Schuchardt
2021-01-06 12:42 ` [PATCH 2/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent Heinrich Schuchardt
2021-02-01 14:33 ` Samer El-Haj-Mahmoud
2021-02-24 9:08 ` [edk2-devel] " G Edhaya Chandran
2021-02-01 14:37 ` [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx Samer El-Haj-Mahmoud
2021-02-24 9:07 ` [edk2-devel] " G Edhaya Chandran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox