[PATCH 0/2] Introduce and use new boot logo position

[PATCH 0/2] Introduce and use new boot logo position

[Patrick Rudolph]

- Enable the boot logo for UefiPayloadPkg.
- Use Microsoft's recommended positioning for the boot logo as default

Tim Crawford (2):
  UefiPayloadPkg: Enable boot logo
  MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen

 MdeModulePkg/Include/Protocol/PlatformLogo.h                             | 3 ++-
 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c                           | 4 ++++
 MdeModulePkg/Logo/Logo.c                                                 | 2 +-
 UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c      | 3 +++
 UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
 UefiPayloadPkg/UefiPayloadPkg.dsc                                        | 2 ++
 UefiPayloadPkg/UefiPayloadPkg.fdf                                        | 2 ++
 7 files changed, 15 insertions(+), 2 deletions(-)

-- 
2.26.2

[PATCH 1/2] UefiPayloadPkg: Enable boot logo

[Patrick Rudolph]

From: Tim Crawford <tcrawford@system76.com>

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
 UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c      | 3 +++
 UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
 UefiPayloadPkg/UefiPayloadPkg.dsc                                        | 2 ++
 UefiPayloadPkg/UefiPayloadPkg.fdf                                        | 2 ++
 4 files changed, 8 insertions(+)

diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
index c5c6af0abc..2df2d5a02d 100644
--- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
+++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
@@ -216,6 +216,9 @@ PlatformBootManagerAfterConsole (
   Black.Blue = Black.Green = Black.Red = Black.Reserved = 0;
   White.Blue = White.Green = White.Red = White.Reserved = 0xFF;
 
+  gST->ConOut->ClearScreen (gST->ConOut);
+  BootLogoEnableLogo ();
+
   EfiBootManagerConnectAll ();
   EfiBootManagerRefreshAllBootOption ();
 
diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
index 1f5a0bcad0..beba973a70 100644
--- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
+++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
@@ -39,6 +39,7 @@
   UefiRuntimeServicesTableLib
   UefiLib
   UefiBootManagerLib
+  BootLogoLib
   PcdLib
   DxeServicesLib
   MemoryAllocationLib
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index ae62a9c4d6..1a084c479e 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -169,6 +169,7 @@
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
   SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
+  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
   CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
   FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
 
@@ -389,6 +390,7 @@
   MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
   UefiCpuPkg/CpuDxe/CpuDxe.inf
   MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
+  MdeModulePkg/Logo/LogoDxe.inf
   MdeModulePkg/Application/UiApp/UiApp.inf {
     <LibraryClasses>
       NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index a97ace7395..98d3fdea4a 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -112,6 +112,8 @@ INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
 INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
 
 INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
+INF MdeModulePkg/Logo/LogoDxe.inf
+
 #
 # PCI Support
 #
-- 
2.26.2

[PATCH 2/2] MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen

[Patrick Rudolph]

From: Tim Crawford <tcrawford@system76.com>

Use Microsoft's recommended positioning [1] for the boot logo.

> We recommend that the logo is placed with its center at 38.2% from the
> screen's top edge. This positioning is based on the golden ratio's
> visual aesthetics and matches the Windows 10 design proportions.

[1]: https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components#position-the-logo-during-post

Based on Tim Crawford <tcrawford@system76.com> initial commit.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
 MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4 ++++
 MdeModulePkg/Logo/Logo.c                       | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h b/MdeModulePkg/Include/Protocol/PlatformLogo.h
index 55c9e08696..21a4c79e1d 100644
--- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
+++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
@@ -29,7 +29,8 @@ typedef enum {
   EdkiiPlatformLogoDisplayAttributeCenterBottom,
   EdkiiPlatformLogoDisplayAttributeLeftBottom,
   EdkiiPlatformLogoDisplayAttributeCenterLeft,
-  EdkiiPlatformLogoDisplayAttributeCenter
+  EdkiiPlatformLogoDisplayAttributeCenter,
+  EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended
 } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
 
 /**
diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
index 134660f28d..d40c65b59f 100644
--- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
+++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
@@ -173,6 +173,10 @@ BootLogoEnableLogo (
       DestX = 0;
       DestY = (SizeOfY - Image.Height) / 2;
       break;
+    case EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended:
+      DestX = (SizeOfX - Image.Width) / 2;
+      DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;
+      break;
     case EdkiiPlatformLogoDisplayAttributeCenter:
       DestX = (SizeOfX - Image.Width) / 2;
       DestY = (SizeOfY - Image.Height) / 2;
diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c
index c647253ecd..131a1b456a 100644
--- a/MdeModulePkg/Logo/Logo.c
+++ b/MdeModulePkg/Logo/Logo.c
@@ -26,7 +26,7 @@ EFI_HII_HANDLE            mHiiHandle;
 LOGO_ENTRY                mLogos[] = {
   {
     IMAGE_TOKEN (IMG_LOGO),
-    EdkiiPlatformLogoDisplayAttributeCenter,
+    EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended,
     0,
     0
   }
-- 
2.26.2

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Enable boot logo

[Ma, Maurice]

Reviewed-by:  Maurice Ma <maurice.ma@intel.com>

Regards
Maurice
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Patrick
> Rudolph
> Sent: Wednesday, January 6, 2021 7:08
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>;
> You, Benjamin <benjamin.you@intel.com>
> Subject: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Enable boot logo
> 
> From: Tim Crawford <tcrawford@system76.com>
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---
>  UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c      |
> 3 +++
>  UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> | 1 +
>  UefiPayloadPkg/UefiPayloadPkg.dsc                                        | 2 ++
>  UefiPayloadPkg/UefiPayloadPkg.fdf                                        | 2 ++
>  4 files changed, 8 insertions(+)
> 
> diff --git
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> index c5c6af0abc..2df2d5a02d 100644
> --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> +++
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> @@ -216,6 +216,9 @@ PlatformBootManagerAfterConsole (
>    Black.Blue = Black.Green = Black.Red = Black.Reserved = 0;
> 
>    White.Blue = White.Green = White.Red = White.Reserved = 0xFF;
> 
> 
> 
> +  gST->ConOut->ClearScreen (gST->ConOut);
> 
> +  BootLogoEnableLogo ();
> 
> +
> 
>    EfiBootManagerConnectAll ();
> 
>    EfiBootManagerRefreshAllBootOption ();
> 
> 
> 
> diff --git
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> index 1f5a0bcad0..beba973a70 100644
> ---
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> +++
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> @@ -39,6 +39,7 @@
>    UefiRuntimeServicesTableLib
> 
>    UefiLib
> 
>    UefiBootManagerLib
> 
> +  BootLogoLib
> 
>    PcdLib
> 
>    DxeServicesLib
> 
>    MemoryAllocationLib
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
> b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index ae62a9c4d6..1a084c479e 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -169,6 +169,7 @@
>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> 
> 
> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/
> DxeSecurityManagementLib.inf
> 
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootM
> anagerLib.inf
> 
> +  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
> 
> 
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customiz
> edDisplayLib.inf
> 
> 
> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltL
> ib.inf
> 
> 
> 
> @@ -389,6 +390,7 @@
>    MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
> 
>    UefiCpuPkg/CpuDxe/CpuDxe.inf
> 
>    MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> 
> +  MdeModulePkg/Logo/LogoDxe.inf
> 
>    MdeModulePkg/Application/UiApp/UiApp.inf {
> 
>      <LibraryClasses>
> 
> 
> NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index a97ace7395..98d3fdea4a 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -112,6 +112,8 @@ INF
> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
>  INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> 
> 
> 
>  INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> 
> +INF MdeModulePkg/Logo/LogoDxe.inf
> 
> +
> 
>  #
> 
>  # PCI Support
> 
>  #
> 
> --
> 2.26.2
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#69834): https://edk2.groups.io/g/devel/message/69834
> Mute This Topic: https://groups.io/mt/79476244/1773972
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [maurice.ma@intel.com]
> -=-=-=-=-=-=
> 

Re: [PATCH 1/2] UefiPayloadPkg: Enable boot logo

[Guo Dong]

Hi Patrick,

I didn't look at the impl details. If the logo is shown from the bootloader, how it would be impacted in payload phase?
I saw you have clearscreen in this patch. Does it only move the logo to center of the screen?

Thanks,
Guo

> -----Original Message-----
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
> Sent: Wednesday, January 6, 2021 8:08 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>;
> You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH 1/2] UefiPayloadPkg: Enable boot logo
> 
> From: Tim Crawford <tcrawford@system76.com>
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---
>  UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> | 3 +++
> 
> UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> | 1 +
>  UefiPayloadPkg/UefiPayloadPkg.dsc                                        | 2 ++
>  UefiPayloadPkg/UefiPayloadPkg.fdf                                        | 2 ++
>  4 files changed, 8 insertions(+)
> 
> diff --git
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> index c5c6af0abc..2df2d5a02d 100644
> ---
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> +++
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> @@ -216,6 +216,9 @@ PlatformBootManagerAfterConsole (
>    Black.Blue = Black.Green = Black.Red = Black.Reserved = 0;
> 
>    White.Blue = White.Green = White.Red = White.Reserved = 0xFF;
> 
> 
> 
> +  gST->ConOut->ClearScreen (gST->ConOut);
> 
> +  BootLogoEnableLogo ();
> 
> +
> 
>    EfiBootManagerConnectAll ();
> 
>    EfiBootManagerRefreshAllBootOption ();
> 
> 
> 
> diff --git
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> index 1f5a0bcad0..beba973a70 100644
> ---
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> +++
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> @@ -39,6 +39,7 @@
>    UefiRuntimeServicesTableLib
> 
>    UefiLib
> 
>    UefiBootManagerLib
> 
> +  BootLogoLib
> 
>    PcdLib
> 
>    DxeServicesLib
> 
>    MemoryAllocationLib
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
> b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index ae62a9c4d6..1a084c479e 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -169,6 +169,7 @@
>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> 
> 
> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/
> DxeSecurityManagementLib.inf
> 
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootM
> anagerLib.inf
> 
> +  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
> 
> 
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customiz
> edDisplayLib.inf
> 
> 
> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBlt
> Lib.inf
> 
> 
> 
> @@ -389,6 +390,7 @@
>    MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
> 
>    UefiCpuPkg/CpuDxe/CpuDxe.inf
> 
>    MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> 
> +  MdeModulePkg/Logo/LogoDxe.inf
> 
>    MdeModulePkg/Application/UiApp/UiApp.inf {
> 
>      <LibraryClasses>
> 
> 
> NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index a97ace7395..98d3fdea4a 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -112,6 +112,8 @@ INF
> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
>  INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> 
> 
> 
>  INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> 
> +INF MdeModulePkg/Logo/LogoDxe.inf
> 
> +
> 
>  #
> 
>  # PCI Support
> 
>  #
> 
> --
> 2.26.2

Re: [PATCH 1/2] UefiPayloadPkg: Enable boot logo

[Patrick Rudolph]

Hi Guo,
Yes, the clear screen will remove the boot logo, if any, displayed by
the bootloader.
The EDK2 user that builds UefiPayloadPkg needs to add the bootloader
logo as part of the build process to keep this boot logo displayed.

It might be possible to keep the bootloader's boot logo by adding an
ACPI BGRT parser in the BlSupportDxe.

Regards,
Patrick Rudolph

On Wed, Jan 6, 2021 at 11:30 PM Dong, Guo <guo.dong@intel.com> wrote:
>
>
> Hi Patrick,
>
> I didn't look at the impl details. If the logo is shown from the bootloader, how it would be impacted in payload phase?
> I saw you have clearscreen in this patch. Does it only move the logo to center of the screen?
>
> Thanks,
> Guo
>
> > -----Original Message-----
> > From: Patrick Rudolph <patrick.rudolph@9elements.com>
> > Sent: Wednesday, January 6, 2021 8:08 AM
> > To: devel@edk2.groups.io
> > Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>;
> > You, Benjamin <benjamin.you@intel.com>
> > Subject: [PATCH 1/2] UefiPayloadPkg: Enable boot logo
> >
> > From: Tim Crawford <tcrawford@system76.com>
> >
> > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> > ---
> >  UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > | 3 +++
> >
> > UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> > | 1 +
> >  UefiPayloadPkg/UefiPayloadPkg.dsc                                        | 2 ++
> >  UefiPayloadPkg/UefiPayloadPkg.fdf                                        | 2 ++
> >  4 files changed, 8 insertions(+)
> >
> > diff --git
> > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > index c5c6af0abc..2df2d5a02d 100644
> > ---
> > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > +++
> > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > @@ -216,6 +216,9 @@ PlatformBootManagerAfterConsole (
> >    Black.Blue = Black.Green = Black.Red = Black.Reserved = 0;
> >
> >    White.Blue = White.Green = White.Red = White.Reserved = 0xFF;
> >
> >
> >
> > +  gST->ConOut->ClearScreen (gST->ConOut);
> >
> > +  BootLogoEnableLogo ();
> >
> > +
> >
> >    EfiBootManagerConnectAll ();
> >
> >    EfiBootManagerRefreshAllBootOption ();
> >
> >
> >
> > diff --git
> > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> > nf
> > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> > nf
> > index 1f5a0bcad0..beba973a70 100644
> > ---
> > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> > nf
> > +++
> > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> > nf
> > @@ -39,6 +39,7 @@
> >    UefiRuntimeServicesTableLib
> >
> >    UefiLib
> >
> >    UefiBootManagerLib
> >
> > +  BootLogoLib
> >
> >    PcdLib
> >
> >    DxeServicesLib
> >
> >    MemoryAllocationLib
> >
> > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
> > b/UefiPayloadPkg/UefiPayloadPkg.dsc
> > index ae62a9c4d6..1a084c479e 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> > @@ -169,6 +169,7 @@
> >    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> >
> >
> > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/
> > DxeSecurityManagementLib.inf
> >
> >
> > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootM
> > anagerLib.inf
> >
> > +  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
> >
> >
> > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customiz
> > edDisplayLib.inf
> >
> >
> > FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBlt
> > Lib.inf
> >
> >
> >
> > @@ -389,6 +390,7 @@
> >    MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
> >
> >    UefiCpuPkg/CpuDxe/CpuDxe.inf
> >
> >    MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> >
> > +  MdeModulePkg/Logo/LogoDxe.inf
> >
> >    MdeModulePkg/Application/UiApp/UiApp.inf {
> >
> >      <LibraryClasses>
> >
> >
> > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
> >
> > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > index a97ace7395..98d3fdea4a 100644
> > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > @@ -112,6 +112,8 @@ INF
> > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> >  INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> >
> >
> >
> >  INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> >
> > +INF MdeModulePkg/Logo/LogoDxe.inf
> >
> > +
> >
> >  #
> >
> >  # PCI Support
> >
> >  #
> >
> > --
> > 2.26.2
>

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Enable boot logo

[Guo Dong]

Thanks Patrick Rudolph for this info.

Reviewed-by: Guo Dong <guo.dong@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Patrick
> Rudolph
> Sent: Thursday, January 7, 2021 12:20 AM
> To: Dong, Guo <guo.dong@intel.com>
> Cc: devel@edk2.groups.io; Ma, Maurice <maurice.ma@intel.com>; You,
> Benjamin <benjamin.you@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Enable boot logo
> 
> Hi Guo,
> Yes, the clear screen will remove the boot logo, if any, displayed by
> the bootloader.
> The EDK2 user that builds UefiPayloadPkg needs to add the bootloader
> logo as part of the build process to keep this boot logo displayed.
> 
> It might be possible to keep the bootloader's boot logo by adding an
> ACPI BGRT parser in the BlSupportDxe.
> 
> Regards,
> Patrick Rudolph
> 
> On Wed, Jan 6, 2021 at 11:30 PM Dong, Guo <guo.dong@intel.com> wrote:
> >
> >
> > Hi Patrick,
> >
> > I didn't look at the impl details. If the logo is shown from the bootloader, how
> it would be impacted in payload phase?
> > I saw you have clearscreen in this patch. Does it only move the logo to center
> of the screen?
> >
> > Thanks,
> > Guo
> >
> > > -----Original Message-----
> > > From: Patrick Rudolph <patrick.rudolph@9elements.com>
> > > Sent: Wednesday, January 6, 2021 8:08 AM
> > > To: devel@edk2.groups.io
> > > Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo
> <guo.dong@intel.com>;
> > > You, Benjamin <benjamin.you@intel.com>
> > > Subject: [PATCH 1/2] UefiPayloadPkg: Enable boot logo
> > >
> > > From: Tim Crawford <tcrawford@system76.com>
> > >
> > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> > > ---
> > >  UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > > | 3 +++
> > >
> > >
> UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> > > | 1 +
> > >  UefiPayloadPkg/UefiPayloadPkg.dsc                                        | 2 ++
> > >  UefiPayloadPkg/UefiPayloadPkg.fdf                                        | 2 ++
> > >  4 files changed, 8 insertions(+)
> > >
> > > diff --git
> > >
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > >
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > > index c5c6af0abc..2df2d5a02d 100644
> > > ---
> > >
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > > +++
> > >
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> > > @@ -216,6 +216,9 @@ PlatformBootManagerAfterConsole (
> > >    Black.Blue = Black.Green = Black.Red = Black.Reserved = 0;
> > >
> > >    White.Blue = White.Green = White.Red = White.Reserved = 0xFF;
> > >
> > >
> > >
> > > +  gST->ConOut->ClearScreen (gST->ConOut);
> > >
> > > +  BootLogoEnableLogo ();
> > >
> > > +
> > >
> > >    EfiBootManagerConnectAll ();
> > >
> > >    EfiBootManagerRefreshAllBootOption ();
> > >
> > >
> > >
> > > diff --git
> > >
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> > > nf
> > >
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> > > nf
> > > index 1f5a0bcad0..beba973a70 100644
> > > ---
> > >
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> > > nf
> > > +++
> > >
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> > > nf
> > > @@ -39,6 +39,7 @@
> > >    UefiRuntimeServicesTableLib
> > >
> > >    UefiLib
> > >
> > >    UefiBootManagerLib
> > >
> > > +  BootLogoLib
> > >
> > >    PcdLib
> > >
> > >    DxeServicesLib
> > >
> > >    MemoryAllocationLib
> > >
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
> > > b/UefiPayloadPkg/UefiPayloadPkg.dsc
> > > index ae62a9c4d6..1a084c479e 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> > > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> > > @@ -169,6 +169,7 @@
> > >
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> > >
> > >
> > >
> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/
> > > DxeSecurityManagementLib.inf
> > >
> > >
> > >
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootM
> > > anagerLib.inf
> > >
> > > +  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
> > >
> > >
> > >
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customiz
> > > edDisplayLib.inf
> > >
> > >
> > >
> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBlt
> > > Lib.inf
> > >
> > >
> > >
> > > @@ -389,6 +390,7 @@
> > >    MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
> > >
> > >    UefiCpuPkg/CpuDxe/CpuDxe.inf
> > >
> > >    MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> > >
> > > +  MdeModulePkg/Logo/LogoDxe.inf
> > >
> > >    MdeModulePkg/Application/UiApp/UiApp.inf {
> > >
> > >      <LibraryClasses>
> > >
> > >
> > >
> NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
> > >
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > index a97ace7395..98d3fdea4a 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > @@ -112,6 +112,8 @@ INF
> > > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > >  INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> > >
> > >
> > >
> > >  INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> > >
> > > +INF MdeModulePkg/Logo/LogoDxe.inf
> > >
> > > +
> > >
> > >  #
> > >
> > >  # PCI Support
> > >
> > >  #
> > >
> > > --
> > > 2.26.2
> >
> 
> 
> 
>