public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Nhi Pham <nhi@os.amperecomputing.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [PATCH v2 0/4] EmbeddedPkg/TimeBaseLib: Reduce duplicate code in RTC modules
Date: Thu, 7 Jan 2021 17:42:25 +0000	[thread overview]
Message-ID: <20210107174225.GF1664@vanye> (raw)
In-Reply-To: <20210106160903.27679-1-nhi@os.amperecomputing.com>

On Wed, Jan 06, 2021 at 23:08:59 +0700, Nhi Pham wrote:
> This patch series replaces all time checking functions and leverage
> the helper function in TimeBaseLib library.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Pushed as 8015f3f6d400..55ee36b0c490.

Many thanks for this cleanup, especially for adding the doxygen
comments to the pre-existing functions.

> Nhi Pham (4):
>   EmbeddedPkg/TimeBaseLib: Update comment blocks for API functions
>   EmbeddedPkg/TimeBaseLib: Fix for minor code formatting
>   EmbeddedPkg/TimeBaseLib: Add function to check Timezone and Daylight
>   EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from
>     TimeBaseLib
> 
>  .../RealTimeClockRuntimeDxe.inf               |   2 +
>  EmbeddedPkg/Include/Library/TimeBaseLib.h     |  90 +++++++++++-
>  EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 134 +++++++++++++++---
>  .../RealTimeClockRuntimeDxe/RealTimeClock.c   |  88 +-----------
>  4 files changed, 201 insertions(+), 113 deletions(-)
> 
> -- 
> 2.17.1
> 

      parent reply	other threads:[~2021-01-07 17:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 16:08 [PATCH v2 0/4] EmbeddedPkg/TimeBaseLib: Reduce duplicate code in RTC modules Nhi Pham
2021-01-06 16:09 ` [PATCH v2 1/4] EmbeddedPkg/TimeBaseLib: Update comment blocks for API functions Nhi Pham
2021-01-06 16:09 ` [PATCH v2 2/4] EmbeddedPkg/TimeBaseLib: Fix for minor code formatting Nhi Pham
2021-01-06 16:09 ` [PATCH v2 3/4] EmbeddedPkg/TimeBaseLib: Add function to check Timezone and Daylight Nhi Pham
2021-01-06 16:09 ` [PATCH v2 4/4] EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib Nhi Pham
2021-01-07 17:42 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107174225.GF1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox