From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.groups.io with SMTP id smtpd.web08.56.1610041348744176511 for ; Thu, 07 Jan 2021 09:42:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=BmH4XLKF; spf=pass (domain: nuviainc.com, ip: 209.85.221.53, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f53.google.com with SMTP id d13so6413418wrc.13 for ; Thu, 07 Jan 2021 09:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lXSa4QrnXYUtVjYN6uu02Opp+zCJ4yh+yu5UsFSdcKE=; b=BmH4XLKFBM4V9LG+b7f1ReOlRKStFCZ3htDEDM/2XZ0KBH18bDAPFYcrQB57xK3K93 hAeadMOK/ZLGqQqqG7p8opc3ECCrNMddi7SKXqNhozKSarax+onvOAzmss82KJJRJcHV 8PjiXwM6Lbhy2TrkhJOJWgkpb85Z0LKFJtw1KkppJYnCFePbkRHSnie0Pnrng0izoiaV ekxnl61ALeDiTOBZ+F0ZdWRjCeSaJx5RaD3xOVJj5X4SX3wkvSlLLC7lTDQ2Pr4chExd 6s3742bhsGswsEZqgqhAdtHTO82VPTsxNjrm6jOF0+wAfB5lIVyfbW6Uzx9N8QOQWv8y 5/MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lXSa4QrnXYUtVjYN6uu02Opp+zCJ4yh+yu5UsFSdcKE=; b=mUilF2T/1HnDoSG2kEXYcU/PL0V/RboPJondRUAoGHAVWWoV+V+6Ghm9X+CiaBoNcB g9gxm/lzW37FZtEs30zE3HGfwb/RCL07Nkc4WGGNbW5K8XKSIya91xtKrfgLxbIQqcwq sw9zLmHUC0ZdxrJqXQZAWy1v0f9RuZ+0L04L4ThFwNsu3/sXST5XIVVe5Q4JGsz9RvVL f1egKcbJ6BwPsSRDyedCmvxcBI4CzZT+gDQTaLv2xksZxcukPwAKOlYXU/tADHc9wCKT C2LWGVEcZtXRZhx/GUMsglpna0HtYa7MSC0s6Y3drPuJU6j6/LHORuC4bLXKmVrynNuY uTaA== X-Gm-Message-State: AOAM533FpO0224UpLLJPcmyGNDNlR1MQjq91taDLp+Amyvy9MOlAYolL DGELVu67KKyF8vFCTkKXlx+HSA== X-Google-Smtp-Source: ABdhPJyGHqOr5+dC5IB+uZcDpqEueqv5CUNexz9F/dKZIrLnaGysGu0e60kbDz6m5GNJJbhaBxr3GQ== X-Received: by 2002:a5d:4dc6:: with SMTP id f6mr10162031wru.336.1610041347287; Thu, 07 Jan 2021 09:42:27 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id v7sm8847706wma.26.2021.01.07.09.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 09:42:26 -0800 (PST) Date: Thu, 7 Jan 2021 17:42:25 +0000 From: "Leif Lindholm" To: Nhi Pham Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH v2 0/4] EmbeddedPkg/TimeBaseLib: Reduce duplicate code in RTC modules Message-ID: <20210107174225.GF1664@vanye> References: <20210106160903.27679-1-nhi@os.amperecomputing.com> MIME-Version: 1.0 In-Reply-To: <20210106160903.27679-1-nhi@os.amperecomputing.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 06, 2021 at 23:08:59 +0700, Nhi Pham wrote: > This patch series replaces all time checking functions and leverage > the helper function in TimeBaseLib library. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Nhi Pham For the series: Reviewed-by: Leif Lindholm Pushed as 8015f3f6d400..55ee36b0c490. Many thanks for this cleanup, especially for adding the doxygen comments to the pre-existing functions. > Nhi Pham (4): > EmbeddedPkg/TimeBaseLib: Update comment blocks for API functions > EmbeddedPkg/TimeBaseLib: Fix for minor code formatting > EmbeddedPkg/TimeBaseLib: Add function to check Timezone and Daylight > EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from > TimeBaseLib > > .../RealTimeClockRuntimeDxe.inf | 2 + > EmbeddedPkg/Include/Library/TimeBaseLib.h | 90 +++++++++++- > EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 134 +++++++++++++++--- > .../RealTimeClockRuntimeDxe/RealTimeClock.c | 88 +----------- > 4 files changed, 201 insertions(+), 113 deletions(-) > > -- > 2.17.1 >