From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.groups.io with SMTP id smtpd.web09.193.1610115329964568289 for ; Fri, 08 Jan 2021 06:15:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=K1RBdT45; spf=pass (domain: nuviainc.com, ip: 209.85.221.44, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f44.google.com with SMTP id r3so9180967wrt.2 for ; Fri, 08 Jan 2021 06:15:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/2OcAgKDDOsue+VcoL4dcHF/Tk2NbjB63nI3//JNvaw=; b=K1RBdT45rZNgJNVu9AjBpuBwBHLZoanzw803cpfv3BXzmBrdly5ChzjaDNrbYZBsMX xHYmhBvXXwdb1PtTtbJFh7s9hL2X9m1rlx435N1VfnJz3vIh253ru8+oMi+RnszRTvgb KpKFb8Y6B6rLTSN9U8PFBRy312Cy2E+SXb9EkToceXA4Gbn0DqBP6OPm1/HY/3S0EfTL X8r5BUVe3/8LUtqzXBy77OXlCFWvE5IMjMjh2OsgThz5LM2gqEG2AFvy0dX+VniRBlMy xh0zWigHhDSj4Gg3wV6keNqnGIzC3G5RfbflTJvRVsiS/WpGHT3J92f0DaU0/DW7kwsz YK8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/2OcAgKDDOsue+VcoL4dcHF/Tk2NbjB63nI3//JNvaw=; b=lqsfRQDj/d0NPDI5Rodx8DxxGc6H/zmxbxLB4/uUcT15ZtdfbpHXa0IiB+aDVd8HWA HISUp8Uxx/YhyK58QE+53IcGtSoeggdrRVJTbk+sFOh4vLnNgZuL4sJXrhoGcgqQhQd6 hYsdJfMZoacjTOuHWT+WPs/FMFTQHJSyl/B32rCN/J3wWQpBUHMYmW7/0ysbaPAxJm6Q FNMyoobCcDoRRe/fuEdthl66I5piwhGgY6z+YtC3Tf5Al+LLgdRvm9L+A5EEmqp1jMFW VdAu4xOwpUvusPtDyfqzIrzT7cWoyKht1EIP3aIQMF29g5tbHkOHSBNbi91AokFe7lxq QtPA== X-Gm-Message-State: AOAM533r1XmQPzJf05Y+IErAudGrGgw4EKtC6cJpaFyki3ZfLhv9Ch0S GG4zZ7m/0n8F+APmIfTW7ZaG8g== X-Google-Smtp-Source: ABdhPJxQJhElX20p7nIs1Ssv7k80NYG+NC6y/kV3hCScwQGIl3RvwGRCA7TjisnKhIuKf4kGUjHFFw== X-Received: by 2002:a5d:674c:: with SMTP id l12mr3822110wrw.399.1610115328601; Fri, 08 Jan 2021 06:15:28 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id a14sm13299785wrn.3.2021.01.08.06.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 06:15:28 -0800 (PST) Date: Fri, 8 Jan 2021 14:15:26 +0000 From: "Leif Lindholm" To: Laszlo Ersek Cc: devel@edk2.groups.io, Ard Biesheuvel , Nhi Pham Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc Message-ID: <20210108141526.GO1664@vanye> References: <20210107194158.11539-1-leif@nuviainc.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 07, 2021 at 21:25:17 +0100, Laszlo Ersek wrote: > On 01/07/21 20:41, Leif Lindholm wrote: > > Commit 55ee36b0c490 > > ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib") > > added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks > > build of EmbeddedPkg.dsc. > > > > Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf. > > > > Cc: Ard Biesheuvel > > Cc: Nhi Pham > > Signed-off-by: Leif Lindholm > > --- > > EmbeddedPkg/EmbeddedPkg.dsc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc > > index e88d76ab2f04..8e83e50c3ef0 100644 > > --- a/EmbeddedPkg/EmbeddedPkg.dsc > > +++ b/EmbeddedPkg/EmbeddedPkg.dsc > > @@ -103,6 +103,8 @@ [LibraryClasses.common] > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf > > > > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > > + > > [LibraryClasses.common.DXE_DRIVER] > > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > > > Reviewed-by: Laszlo Ersek Thanks. Apologies for missing your R-b on the patch I just pushed. > A similar patch is needed for "OvmfPkg/OvmfXen.dsc" please: > > OvmfPkg/OvmfXen.dsc(...): error 4000: Instance of library class [TimeBaseLib] is not found > in [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] [X64] > consumed by module [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] Agh, I mistakenly assumed we had only ARM consumers of that lib in the main repo. Next time I'll actually grep. Patch sent. / Leif > Thanks, > Laszlo >