public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
	devel@edk2.groups.io, Nhi Pham <nhi@os.amperecomputing.com>
Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc
Date: Fri, 8 Jan 2021 14:24:11 +0000	[thread overview]
Message-ID: <20210108142411.GQ1664@vanye> (raw)
In-Reply-To: <52834fd0-72e2-07ba-dbd0-39785233a8f0@arm.com>

On Fri, Jan 08, 2021 at 10:13:00 +0100, Ard Biesheuvel wrote:
> On 1/7/21 9:25 PM, Laszlo Ersek wrote:
> > On 01/07/21 20:41, Leif Lindholm wrote:
> >> Commit 55ee36b0c490
> >> ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
> >> added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
> >> build of EmbeddedPkg.dsc.
> >>
> >> Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
> >>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> >> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> >> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Thanks!
Pushed as fabeffb09e3b.

> >> ---
> >>  EmbeddedPkg/EmbeddedPkg.dsc | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> >> index e88d76ab2f04..8e83e50c3ef0 100644
> >> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> >> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> >> @@ -103,6 +103,8 @@ [LibraryClasses.common]
> >>    DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> >>    DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
> >>  
> >> +  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> >> +
> >>  [LibraryClasses.common.DXE_DRIVER]
> >>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> >>    ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >>
> > 
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> > 
> > A similar patch is needed for "OvmfPkg/OvmfXen.dsc" please:
> > 
> > OvmfPkg/OvmfXen.dsc(...): error 4000: Instance of library class [TimeBaseLib] is not found
> >         in [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] [X64]
> >         consumed by module [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf]
> > 
> > Thanks,
> > Laszlo
> > 
> 

  reply	other threads:[~2021-01-08 14:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 19:41 [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc Leif Lindholm
2021-01-07 20:25 ` [edk2-devel] " Laszlo Ersek
2021-01-08  9:13   ` Ard Biesheuvel
2021-01-08 14:24     ` Leif Lindholm [this message]
2021-01-08 14:15   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108142411.GQ1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox