From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.groups.io with SMTP id smtpd.web08.297.1610115855648196742 for ; Fri, 08 Jan 2021 06:24:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=dYJzp8KE; spf=pass (domain: nuviainc.com, ip: 209.85.221.45, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f45.google.com with SMTP id t16so9206074wra.3 for ; Fri, 08 Jan 2021 06:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UCzTgeRW2tRkuIfLlKjwAb5HrC08cYqD19xqlULX15Y=; b=dYJzp8KEhgtUqAAuk8PU3m/mw60uigTOn1JJysTwPndruCB9wXVwCD5x/uURL4Dcam d5SLZbfAG2MlYzIHz9nOKT3IcmHqIGCbl3wntzp3MQ45HMNTDYMo0kpdIn2jDJC/brvp lj54w5AOua5kJY6SIkcWEIqB/DFN4AoMFqrpJWYxqhV4XmzCBi79ykwsfgOooza9DoE7 +Lbuf7PA9sRp9EQ1e0XR+ahTIc22XQMpYiZ/KOi066Q5Hm0BwfJeqHlHPhEAcRw0gcsS Xi2SMIIxQHN0xZA1TXtQcIj8RwvKRgdOiXHeDhFK3Ysq1h2rH/UlDbSNhYTFqvpBIBcu wfDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UCzTgeRW2tRkuIfLlKjwAb5HrC08cYqD19xqlULX15Y=; b=qp/fzCogVbGcFGDogc1MtaXV8m0ysHa68eFWanyePHxl9e3u8mSYMbesymCc6DlFBj h3zjAvghehJBaIqketNrYvcRqcxOVUFfbKBay8SR68uNmA9rvVlt1hgRxEMXIHkl6apY ujWvuYWlzrKOL+QhOLIesKfgrEK2amTRjuzTzEgVbnylYw8Xxr2LZRGhFImnxem9cOb5 PitvLy1cdKuH8bTmkzGR5e6rVGBg7xzZkVly/ex069pe4vFl/+iYTRzcrd0jIbfKJKim hUstEX6IXxlI0HB0xZQmASE0MKWH6hoed8BiX7W9fLRtMKqBrf10JoT3y46fYoE0ooB1 pF/A== X-Gm-Message-State: AOAM530ky3jUWGDompQqU9zNUU/4feJ6xdqAYoI2fUYTp54NtLtOungl OJcKwKXIlH5YLUL2zcyCMG9qKA== X-Google-Smtp-Source: ABdhPJx/CG9yNhEWfZh7D1rdZacO3ny5eCnGvVdgbQWFjGYZPCZkrOjzCquMUCQUdxaRqIhn74jeZA== X-Received: by 2002:a5d:4242:: with SMTP id s2mr3889432wrr.187.1610115854078; Fri, 08 Jan 2021 06:24:14 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id c4sm12417627wmf.19.2021.01.08.06.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 06:24:13 -0800 (PST) Date: Fri, 8 Jan 2021 14:24:11 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: Laszlo Ersek , devel@edk2.groups.io, Nhi Pham Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc Message-ID: <20210108142411.GQ1664@vanye> References: <20210107194158.11539-1-leif@nuviainc.com> <52834fd0-72e2-07ba-dbd0-39785233a8f0@arm.com> MIME-Version: 1.0 In-Reply-To: <52834fd0-72e2-07ba-dbd0-39785233a8f0@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 08, 2021 at 10:13:00 +0100, Ard Biesheuvel wrote: > On 1/7/21 9:25 PM, Laszlo Ersek wrote: > > On 01/07/21 20:41, Leif Lindholm wrote: > >> Commit 55ee36b0c490 > >> ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib") > >> added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks > >> build of EmbeddedPkg.dsc. > >> > >> Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf. > >> > >> Cc: Ard Biesheuvel > >> Cc: Nhi Pham > >> Signed-off-by: Leif Lindholm > > Reviewed-by: Ard Biesheuvel Thanks! Pushed as fabeffb09e3b. > >> --- > >> EmbeddedPkg/EmbeddedPkg.dsc | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc > >> index e88d76ab2f04..8e83e50c3ef0 100644 > >> --- a/EmbeddedPkg/EmbeddedPkg.dsc > >> +++ b/EmbeddedPkg/EmbeddedPkg.dsc > >> @@ -103,6 +103,8 @@ [LibraryClasses.common] > >> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > >> DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf > >> > >> + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > >> + > >> [LibraryClasses.common.DXE_DRIVER] > >> PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > >> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > >> > > > > Reviewed-by: Laszlo Ersek > > > > A similar patch is needed for "OvmfPkg/OvmfXen.dsc" please: > > > > OvmfPkg/OvmfXen.dsc(...): error 4000: Instance of library class [TimeBaseLib] is not found > > in [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] [X64] > > consumed by module [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] > > > > Thanks, > > Laszlo > > >