public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: devel@edk2.groups.io
Cc: leif@nuviainc.com, Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: [PATCH edk2-platforms 2/4] Platform/AMD/Styx: simplify PCIe root bus MMIO resources
Date: Fri,  8 Jan 2021 15:28:48 +0100	[thread overview]
Message-ID: <20210108142850.14535-2-ard.biesheuvel@arm.com> (raw)
In-Reply-To: <20210108142850.14535-1-ard.biesheuvel@arm.com>

There is no need to split up adjacent MMIO resources into separate
DWordMemory() or QWordMemory() declarations, so just merge them
together.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 67 +-------------------
 1 file changed, 2 insertions(+), 65 deletions(-)

diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
index 3a3bdcad627e..2ee6ea3b1eb1 100644
--- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
+++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
@@ -353,79 +353,16 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3)
                     DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
                         0x00000000,         // Granularity
                         0x40000000,         // Range Minimum
-                        0x5FFFFFFF,         // Range Maximum
-                        0x00000000,         // Translation Offset
-                        0x20000000          // Length
-                        )
-                    DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x00000000,         // Granularity
-                        0x60000000,         // Range Minimum
-                        0x7FFFFFFF,         // Range Maximum
-                        0x00000000,         // Translation Offset
-                        0x20000000          // Length
-                        )
-                    DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x00000000,         // Granularity
-                        0x80000000,         // Range Minimum
-                        0x9FFFFFFF,         // Range Maximum
-                        0x00000000,         // Translation Offset
-                        0x20000000          // Length
-                        )
-                    DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x00000000,         // Granularity
-                        0xA0000000,         // Range Minimum
                         0xBFFFFFFF,         // Range Maximum
                         0x00000000,         // Translation Offset
-                        0x20000000          // Length
+                        0x80000000          // Length
                         )
                     QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
                         0x0000000000000000, // Granularity
                         0x0000000100000000, // Range Minimum
-                        0x00000001FFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000000100000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000000200000000, // Range Minimum
-                        0x00000003FFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000000200000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000000400000000, // Range Minimum
-                        0x00000007FFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000000400000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000000800000000, // Range Minimum
-                        0x0000000FFFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000000800000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000001000000000, // Range Minimum
-                        0x0000001FFFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000001000000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000002000000000, // Range Minimum
-                        0x0000003FFFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000002000000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000004000000000, // Range Minimum
                         0x0000007FFFFFFFFF, // Range Maximum
                         0x0000000000000000, // Translation Offset
-                        0x0000004000000000  // Length
+                        0x0000007F00000000  // Length
                         )
                     DWordIo (ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange,
                         0x00000000,         // Granularity
-- 
2.17.1


  reply	other threads:[~2021-01-08 14:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 14:28 [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Ard Biesheuvel
2021-01-08 14:28 ` Ard Biesheuvel [this message]
2021-01-08 14:28 ` [PATCH edk2-platforms 3/4] Platform/AMD/Styx: implement PCIe _DSM #5 to preserve boot allocations Ard Biesheuvel
2021-01-08 14:28 ` [PATCH edk2-platforms 4/4] Platform/AMD/Styx: remove unused RP0 device Ard Biesheuvel
2021-01-08 15:26 ` [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Leif Lindholm
2021-01-08 15:50   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108142850.14535-2-ard.biesheuvel@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox