public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: devel@edk2.groups.io
Cc: leif@nuviainc.com, Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: [PATCH edk2-platforms 4/4] Platform/AMD/Styx: remove unused RP0 device
Date: Fri,  8 Jan 2021 15:28:50 +0100	[thread overview]
Message-ID: <20210108142850.14535-4-ard.biesheuvel@arm.com> (raw)
In-Reply-To: <20210108142850.14535-1-ard.biesheuvel@arm.com>

The RP0 device has no _HID or _CID or any other identifying attribute,
and its use of _ADR within the scope of the PNP0A08 device object suggests
that _ADR carries a PCIe dev/fn identifier (like the EXPn device objects
earlier in the file), whereas in reality, the address it carries is the
MMIO address of the ECAM window.

So let's just drop it.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
index 53ad25ea9a2f..05f3efc40418 100644
--- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
+++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
@@ -453,15 +453,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3)
               }
               Return (Buffer(){0})
             } // Method(_DSM)
-
-            //
-            // Root-Complex 0
-            //
-            Device (RP0)
-            {
-                Name (_ADR, 0xF0000000)  // _ADR: Bus 0, Dev 0, Func 0
-            }
         }
     }
 }
-
-- 
2.17.1


  parent reply	other threads:[~2021-01-08 14:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 14:28 [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Ard Biesheuvel
2021-01-08 14:28 ` [PATCH edk2-platforms 2/4] Platform/AMD/Styx: simplify PCIe root bus MMIO resources Ard Biesheuvel
2021-01-08 14:28 ` [PATCH edk2-platforms 3/4] Platform/AMD/Styx: implement PCIe _DSM #5 to preserve boot allocations Ard Biesheuvel
2021-01-08 14:28 ` Ard Biesheuvel [this message]
2021-01-08 15:26 ` [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Leif Lindholm
2021-01-08 15:50   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108142850.14535-4-ard.biesheuvel@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox