public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions
@ 2021-01-08 14:28 Ard Biesheuvel
  2021-01-08 14:28 ` [PATCH edk2-platforms 2/4] Platform/AMD/Styx: simplify PCIe root bus MMIO resources Ard Biesheuvel
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2021-01-08 14:28 UTC (permalink / raw)
  To: devel; +Cc: leif, Ard Biesheuvel

Add the resolution for TimeBaseLib to the various Styx DSCs, which is
now required to build the EmbeddedPkg RTC driver.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 1 +
 Platform/LeMaker/CelloBoard/CelloBoard.dsc                  | 1 +
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
 3 files changed, 3 insertions(+)

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 73a679bee942..19102b2ef818 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -108,6 +108,7 @@ [LibraryClasses.common]
   AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf
   ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
   RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
+  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
 
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
   DisplayUpdateProgressLib|MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index 3bf67adce680..d787f87c0b86 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -114,6 +114,7 @@ [LibraryClasses.common]
   AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf
   ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
   RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
+  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
 
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index e515aaade126..d5f75cbba5e5 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -116,6 +116,7 @@ [LibraryClasses.common]
   AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf
   ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
   RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
+  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
 
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH edk2-platforms 2/4] Platform/AMD/Styx: simplify PCIe root bus MMIO resources
  2021-01-08 14:28 [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Ard Biesheuvel
@ 2021-01-08 14:28 ` Ard Biesheuvel
  2021-01-08 14:28 ` [PATCH edk2-platforms 3/4] Platform/AMD/Styx: implement PCIe _DSM #5 to preserve boot allocations Ard Biesheuvel
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2021-01-08 14:28 UTC (permalink / raw)
  To: devel; +Cc: leif, Ard Biesheuvel

There is no need to split up adjacent MMIO resources into separate
DWordMemory() or QWordMemory() declarations, so just merge them
together.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 67 +-------------------
 1 file changed, 2 insertions(+), 65 deletions(-)

diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
index 3a3bdcad627e..2ee6ea3b1eb1 100644
--- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
+++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
@@ -353,79 +353,16 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3)
                     DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
                         0x00000000,         // Granularity
                         0x40000000,         // Range Minimum
-                        0x5FFFFFFF,         // Range Maximum
-                        0x00000000,         // Translation Offset
-                        0x20000000          // Length
-                        )
-                    DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x00000000,         // Granularity
-                        0x60000000,         // Range Minimum
-                        0x7FFFFFFF,         // Range Maximum
-                        0x00000000,         // Translation Offset
-                        0x20000000          // Length
-                        )
-                    DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x00000000,         // Granularity
-                        0x80000000,         // Range Minimum
-                        0x9FFFFFFF,         // Range Maximum
-                        0x00000000,         // Translation Offset
-                        0x20000000          // Length
-                        )
-                    DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x00000000,         // Granularity
-                        0xA0000000,         // Range Minimum
                         0xBFFFFFFF,         // Range Maximum
                         0x00000000,         // Translation Offset
-                        0x20000000          // Length
+                        0x80000000          // Length
                         )
                     QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
                         0x0000000000000000, // Granularity
                         0x0000000100000000, // Range Minimum
-                        0x00000001FFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000000100000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000000200000000, // Range Minimum
-                        0x00000003FFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000000200000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000000400000000, // Range Minimum
-                        0x00000007FFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000000400000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000000800000000, // Range Minimum
-                        0x0000000FFFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000000800000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000001000000000, // Range Minimum
-                        0x0000001FFFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000001000000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000002000000000, // Range Minimum
-                        0x0000003FFFFFFFFF, // Range Maximum
-                        0x0000000000000000, // Translation Offset
-                        0x0000002000000000  // Length
-                        )
-                    QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
-                        0x0000000000000000, // Granularity
-                        0x0000004000000000, // Range Minimum
                         0x0000007FFFFFFFFF, // Range Maximum
                         0x0000000000000000, // Translation Offset
-                        0x0000004000000000  // Length
+                        0x0000007F00000000  // Length
                         )
                     DWordIo (ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange,
                         0x00000000,         // Granularity
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH edk2-platforms 3/4] Platform/AMD/Styx: implement PCIe _DSM #5 to preserve boot allocations
  2021-01-08 14:28 [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Ard Biesheuvel
  2021-01-08 14:28 ` [PATCH edk2-platforms 2/4] Platform/AMD/Styx: simplify PCIe root bus MMIO resources Ard Biesheuvel
@ 2021-01-08 14:28 ` Ard Biesheuvel
  2021-01-08 14:28 ` [PATCH edk2-platforms 4/4] Platform/AMD/Styx: remove unused RP0 device Ard Biesheuvel
  2021-01-08 15:26 ` [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Leif Lindholm
  3 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2021-01-08 14:28 UTC (permalink / raw)
  To: devel; +Cc: leif, Ard Biesheuvel

Now that we have gained support for resizable BARs in EDK2, there is no
longer a need for the OS to reallocate MMIO BAR resources. So let's
implement _DSM #5 properly to inform the OS that boot time allocations
may be preserved.

While at it, clean up the implementation of _DSM, and only retain the
methods that we actually need: #0 exposing the fact that #0 and #5 are
the only ones implemented, and #5 as explained above.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 82 +-------------------
 1 file changed, 2 insertions(+), 80 deletions(-)

diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
index 2ee6ea3b1eb1..53ad25ea9a2f 100644
--- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
+++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
@@ -434,92 +434,14 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3)
                   // Function 0: Return supported functions
                   //
                   case(0) {
-                    Return (Buffer() {0xFF})
-                  }
-
-                  //
-                  // Function 1: Return PCIe Slot Information
-                  //
-                  case(1) {
-                    Return (Package(2) {
-                      One, // Success
-                      Package(3) {
-                        0x1,  // x1 PCIe link
-                        0x1,  // PCI express card slot
-                        0x1   // WAKE# signal supported
-                      }
-                    })
-                  }
-
-                  //
-                  // Function 2: Return PCIe Slot Number.
-                  //
-                  case(2) {
-                    Return (Package(1) {
-                      Package(4) {
-                        2,  // Source ID
-                        4,  // Token ID: ID refers to a slot
-                        0,  // Start bit of the field to use.
-                        7   // End bit of the field to use.
-                      }
-                    })
-                  }
-
-                  //
-                  // Function 3: Return Vendor-specific Token ID Strings.
-                  //
-                  case(3) {
-                    Return (Package(0) {})
-                  }
-
-                  //
-                  // Function 4: Return PCI Bus Capabilities
-                  //
-                  case(4) {
-                    Return (Package(2) {
-                      One, // Success
-                      Buffer() {
-                        1,0,            // Version
-                        0,0,            // Status, 0:Success
-                        24,0,0,0,       // Length
-                        1,0,            // PCI
-                        16,0,           // Length
-                        0,              // Attributes
-                        0x0D,           // Current Speed/Mode
-                        0x3F,0,         // Supported Speeds/Modes
-                        0,              // Voltage
-                        0,0,0,0,0,0,0   // Reserved
-                      }
-                    })
+                    Return (Buffer() {0x21})
                   }
 
                   //
                   // Function 5: Return Ignore PCI Boot Configuration
                   //
                   case(5) {
-                    Return (Package(1) {1})
-                  }
-
-                  //
-                  // Function 6: Return LTR Maximum Latency
-                  //
-                  case(6) {
-                    Return (Package(4) {
-                      Package(1){0},  // Maximum Snoop Latency Scale
-                      Package(1){0},  // Maximum Snoop Latency Value
-                      Package(1){0},  // Maximum No-Snoop Latency Scale
-                      Package(1){0}   // Maximum No-Snoop Latency Value
-                    })
-                  }
-
-                  //
-                  // Function 7: Return PCI Express Naming
-                  //
-                  case(7) {
-                    Return (Package(2) {
-                      Package(1) {0},
-                      Package(1) {Unicode("PCI0")}
-                    })
+                    Return (0)
                   }
 
                   //
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH edk2-platforms 4/4] Platform/AMD/Styx: remove unused RP0 device
  2021-01-08 14:28 [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Ard Biesheuvel
  2021-01-08 14:28 ` [PATCH edk2-platforms 2/4] Platform/AMD/Styx: simplify PCIe root bus MMIO resources Ard Biesheuvel
  2021-01-08 14:28 ` [PATCH edk2-platforms 3/4] Platform/AMD/Styx: implement PCIe _DSM #5 to preserve boot allocations Ard Biesheuvel
@ 2021-01-08 14:28 ` Ard Biesheuvel
  2021-01-08 15:26 ` [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Leif Lindholm
  3 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2021-01-08 14:28 UTC (permalink / raw)
  To: devel; +Cc: leif, Ard Biesheuvel

The RP0 device has no _HID or _CID or any other identifying attribute,
and its use of _ADR within the scope of the PNP0A08 device object suggests
that _ADR carries a PCIe dev/fn identifier (like the EXPn device objects
earlier in the file), whereas in reality, the address it carries is the
MMIO address of the ECAM window.

So let's just drop it.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
index 53ad25ea9a2f..05f3efc40418 100644
--- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
+++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
@@ -453,15 +453,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3)
               }
               Return (Buffer(){0})
             } // Method(_DSM)
-
-            //
-            // Root-Complex 0
-            //
-            Device (RP0)
-            {
-                Name (_ADR, 0xF0000000)  // _ADR: Bus 0, Dev 0, Func 0
-            }
         }
     }
 }
-
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions
  2021-01-08 14:28 [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Ard Biesheuvel
                   ` (2 preceding siblings ...)
  2021-01-08 14:28 ` [PATCH edk2-platforms 4/4] Platform/AMD/Styx: remove unused RP0 device Ard Biesheuvel
@ 2021-01-08 15:26 ` Leif Lindholm
  2021-01-08 15:50   ` Ard Biesheuvel
  3 siblings, 1 reply; 6+ messages in thread
From: Leif Lindholm @ 2021-01-08 15:26 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: devel

For series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Thanks!

On Fri, Jan 08, 2021 at 15:28:47 +0100, Ard Biesheuvel wrote:
> Add the resolution for TimeBaseLib to the various Styx DSCs, which is
> now required to build the EmbeddedPkg RTC driver.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 1 +
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                  | 1 +
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index 73a679bee942..19102b2ef818 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -108,6 +108,7 @@ [LibraryClasses.common]
>    AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf
>    ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>    RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
> +  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>  
>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
>    DisplayUpdateProgressLib|MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf
> diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> index 3bf67adce680..d787f87c0b86 100644
> --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> @@ -114,6 +114,7 @@ [LibraryClasses.common]
>    AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf
>    ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>    RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
> +  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>  
>    VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> index e515aaade126..d5f75cbba5e5 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> @@ -116,6 +116,7 @@ [LibraryClasses.common]
>    AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf
>    ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>    RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
> +  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>  
>    VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions
  2021-01-08 15:26 ` [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Leif Lindholm
@ 2021-01-08 15:50   ` Ard Biesheuvel
  0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2021-01-08 15:50 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: devel

On 1/8/21 4:26 PM, Leif Lindholm wrote:
> For series:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> Thanks!
> 

Thanks

Pushed as dcb1fbff08bb..07512c67801f

> On Fri, Jan 08, 2021 at 15:28:47 +0100, Ard Biesheuvel wrote:
>> Add the resolution for TimeBaseLib to the various Styx DSCs, which is
>> now required to build the EmbeddedPkg RTC driver.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> ---
>>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 1 +
>>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                  | 1 +
>>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
>>  3 files changed, 3 insertions(+)
>>
>> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
>> index 73a679bee942..19102b2ef818 100644
>> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
>> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
>> @@ -108,6 +108,7 @@ [LibraryClasses.common]
>>    AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf
>>    ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>>    RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
>> +  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>>  
>>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
>>    DisplayUpdateProgressLib|MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf
>> diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
>> index 3bf67adce680..d787f87c0b86 100644
>> --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
>> +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
>> @@ -114,6 +114,7 @@ [LibraryClasses.common]
>>    AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf
>>    ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>>    RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
>> +  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>>  
>>    VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
>> index e515aaade126..d5f75cbba5e5 100644
>> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
>> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
>> @@ -116,6 +116,7 @@ [LibraryClasses.common]
>>    AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf
>>    ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>>    RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
>> +  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>>  
>>    VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>> -- 
>> 2.17.1
>>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-08 15:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-08 14:28 [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Ard Biesheuvel
2021-01-08 14:28 ` [PATCH edk2-platforms 2/4] Platform/AMD/Styx: simplify PCIe root bus MMIO resources Ard Biesheuvel
2021-01-08 14:28 ` [PATCH edk2-platforms 3/4] Platform/AMD/Styx: implement PCIe _DSM #5 to preserve boot allocations Ard Biesheuvel
2021-01-08 14:28 ` [PATCH edk2-platforms 4/4] Platform/AMD/Styx: remove unused RP0 device Ard Biesheuvel
2021-01-08 15:26 ` [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Leif Lindholm
2021-01-08 15:50   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox