From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.361.1610116141125264369 for ; Fri, 08 Jan 2021 06:29:01 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAC2C11FB; Fri, 8 Jan 2021 06:29:00 -0800 (PST) Received: from e123331-lin.nice.arm.com (unknown [10.37.8.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0422F3F70D; Fri, 8 Jan 2021 06:28:59 -0800 (PST) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: leif@nuviainc.com, Ard Biesheuvel Subject: [PATCH edk2-platforms 4/4] Platform/AMD/Styx: remove unused RP0 device Date: Fri, 8 Jan 2021 15:28:50 +0100 Message-Id: <20210108142850.14535-4-ard.biesheuvel@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210108142850.14535-1-ard.biesheuvel@arm.com> References: <20210108142850.14535-1-ard.biesheuvel@arm.com> The RP0 device has no _HID or _CID or any other identifying attribute, and its use of _ADR within the scope of the PNP0A08 device object suggests that _ADR carries a PCIe dev/fn identifier (like the EXPn device objects earlier in the file), whereas in reality, the address it carries is the MMIO address of the ECAM window. So let's just drop it. Signed-off-by: Ard Biesheuvel --- Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 9 --------- 1 file changed, 9 deletions(-) diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl index 53ad25ea9a2f..05f3efc40418 100644 --- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl +++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl @@ -453,15 +453,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3) } Return (Buffer(){0}) } // Method(_DSM) - - // - // Root-Complex 0 - // - Device (RP0) - { - Name (_ADR, 0xF0000000) // _ADR: Bus 0, Dev 0, Func 0 - } } } } - -- 2.17.1