From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web12.1266.1610119576919319360 for ; Fri, 08 Jan 2021 07:26:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=LO94Vqtr; spf=pass (domain: nuviainc.com, ip: 209.85.128.53, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f53.google.com with SMTP id q75so8757839wme.2 for ; Fri, 08 Jan 2021 07:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=47ba8kH4HBzR1Bke1td1nEEJd6odMf3NAPGzxSiAdRU=; b=LO94VqtrCi/fGFQnxUhXAiFcE88tWaby+zPjzHe6LWjJOs9ONVp2SzKjfi4fW0JvLw 9Pkd0+Sthb+DtZRvwDm9NphN4Q6PklksXKiwq8jEXc8X92lmWjQUkELHaP2EzqRdxWty 0XA+woK7ud1Jz7lIu4MUHSslL8OlggE5Lf3B2UCbl1YIUmVoaRJnHb5/6ZHJzPlvBCRw N1JUxOL2A2fyicfm0nLzoLPPhTDvsOi6tKbwhUOUQEPmejzxiNqTkRKKtGzwstb6Qffm qTdZS7n3lzL7WsvTEbm1QSg1ita6HQyD3hy5SpQzatVMt7J6KlB0qb03JHE5Ju/QQ7Ti UZYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=47ba8kH4HBzR1Bke1td1nEEJd6odMf3NAPGzxSiAdRU=; b=K7uWGoO3mMfAcnfTZAYSBG7mUqRbmJp5etWA3hOVGx0g8cvc59Fz6OF/ri1uHGa/pO kYxSLXjmEcZC5HMD6zebrxmK1N8llzi9UncXqxBvaIX61Kr5vIBuovEjO17GZbCsCTN9 gpkPKj/9DH0XsFftq8UrpR9pNv9nyrALa9taf+DjYxOtClLGpI/wQN1UjgNDpmR8ZSYc 7WcokuYpHGClo7qbXRm+V4XuojDZUa7mCNhPz0TzoDhtaGsGCkInmp+yi/IRqJqMze/4 ZBWWRo5FN0ErNvzeeCb40dPBP/GHnCz85VbdMlOrmWr8QT8k9cd8l/AX615nS89PsY4z U/Gg== X-Gm-Message-State: AOAM530VN5jWECsHKcMG+etmc0XhtZHPrrjXZD8vRQiI40wW95TbSxjF F5qlQSyEnZ6S3VkoDpZ8/imy9g== X-Google-Smtp-Source: ABdhPJwY9amYPq0H75M2ZDvklgbz6ETRTXj0pr2RMaEtOBESY1o2HepyAkbiGiNxJ1kR7mok3TsIsw== X-Received: by 2002:a1c:6a0e:: with SMTP id f14mr3427352wmc.102.1610119575517; Fri, 08 Jan 2021 07:26:15 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id n12sm14491649wrg.76.2021.01.08.07.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 07:26:15 -0800 (PST) Date: Fri, 8 Jan 2021 15:26:13 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 1/4] Platform/AMD/Styx: add missing TimeBaseLib resolutions Message-ID: <20210108152613.GR1664@vanye> References: <20210108142850.14535-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20210108142850.14535-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline For series: Reviewed-by: Leif Lindholm Thanks! On Fri, Jan 08, 2021 at 15:28:47 +0100, Ard Biesheuvel wrote: > Add the resolution for TimeBaseLib to the various Styx DSCs, which is > now required to build the EmbeddedPkg RTC driver. > > Signed-off-by: Ard Biesheuvel > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index 73a679bee942..19102b2ef818 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -108,6 +108,7 @@ [LibraryClasses.common] > AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf > DisplayUpdateProgressLib|MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf > diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > index 3bf67adce680..d787f87c0b86 100644 > --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc > +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > @@ -114,6 +114,7 @@ [LibraryClasses.common] > AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > index e515aaade126..d5f75cbba5e5 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > @@ -116,6 +116,7 @@ [LibraryClasses.common] > AmdSataInit|Silicon/AMD/Styx/AmdModulePkg/Library/AmdSataInitLib/AmdSataInitLib.inf > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > -- > 2.17.1 >