public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms 2/2] Platform/SynQuacerEvalBoard: add missing library class resolutions
Date: Fri, 8 Jan 2021 15:27:05 +0000	[thread overview]
Message-ID: <20210108152705.GS1664@vanye> (raw)
In-Reply-To: <20210108143540.21871-2-ard.biesheuvel@arm.com>

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Thanks!

On Fri, Jan 08, 2021 at 15:35:40 +0100, Ard Biesheuvel wrote:
> Catch up with changes in the EDK2 repository that have caused the build
> to break on missing resolution for library classes that were not being
> used before.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> index 968378d5ee5b..95643685e8aa 100644
> --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> @@ -27,6 +27,7 @@ [Defines]
>    #
>    DEFINE NETWORK_SNP_ENABLE             = FALSE
>    DEFINE NETWORK_TLS_ENABLE             = FALSE
> +  DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
>  
>  [BuildOptions]
>    RELEASE_*_*_CC_FLAGS  = -DMDEPKG_NDEBUG -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0
> @@ -82,6 +83,7 @@ [LibraryClasses.common]
>    UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
>    CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>  
>    UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
>    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> @@ -198,6 +200,8 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER]
>    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
>    ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> +  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> +
>  !if $(TARGET) != RELEASE
>    DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
>  !endif
> @@ -492,6 +496,8 @@ [Components.common]
>        NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
>        TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>        VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> +      VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> +      VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>    }
>  
>    #
> -- 
> 2.17.1
> 

  reply	other threads:[~2021-01-08 15:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 14:35 [PATCH edk2-platforms 1/2] Platform/DeveloperBox: add missing TimeBaseLib resolution Ard Biesheuvel
2021-01-08 14:35 ` [PATCH edk2-platforms 2/2] Platform/SynQuacerEvalBoard: add missing library class resolutions Ard Biesheuvel
2021-01-08 15:27   ` Leif Lindholm [this message]
2021-01-08 15:52     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108152705.GS1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox