From: "Leif Lindholm" <leif@nuviainc.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>,
Anthony Perard <anthony.perard@citrix.com>,
Julien Grall <julien@xen.org>
Subject: Re: [PATCH 1/1] OvmfPkg: add TimeBaseLib resolution for OvmfXen
Date: Fri, 8 Jan 2021 15:56:22 +0000 [thread overview]
Message-ID: <20210108155622.GT1664@vanye> (raw)
In-Reply-To: <aacbd5ab-8dcf-a7f8-a881-61e46de94894@redhat.com>
On Fri, Jan 08, 2021 at 15:47:28 +0100, Laszlo Ersek wrote:
> On 01/08/21 15:12, Leif Lindholm wrote:
> > Commit 55ee36b0c490
> > ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
> > added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
> > build of OvmfXen.dsc.
> >
> > Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
> >
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien@xen.org>
> > Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> > ---
> > OvmfPkg/OvmfXen.dsc | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> > index c13388ba5a05..7d31e88907ca 100644
> > --- a/OvmfPkg/OvmfXen.dsc
> > +++ b/OvmfPkg/OvmfXen.dsc
> > @@ -212,6 +212,7 @@ [LibraryClasses]
> > Tcg2PhysicalPresenceLib|OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf
> > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> > RealTimeClockLib|OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.inf
> > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> > !ifdef $(DEBUG_ON_HYPERVISOR_CONSOLE)
> > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPortNocheck.inf
> > !else
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks - pushed as 9783767fcfc2.
> Thank you!
> Laszlo
>
prev parent reply other threads:[~2021-01-08 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 14:12 [PATCH 1/1] OvmfPkg: add TimeBaseLib resolution for OvmfXen Leif Lindholm
2021-01-08 14:47 ` Laszlo Ersek
2021-01-08 15:56 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108155622.GT1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox