From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.groups.io with SMTP id smtpd.web10.1739.1610121386587228126 for ; Fri, 08 Jan 2021 07:56:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=UYL+gcSe; spf=pass (domain: nuviainc.com, ip: 209.85.128.54, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f54.google.com with SMTP id c124so8160834wma.5 for ; Fri, 08 Jan 2021 07:56:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BBfMn9SDIgg2Nddl+1VhBEHGScLc1AUe3ABgkxeGn1Q=; b=UYL+gcSeXvvzTIhmCq2YxgpE+ul8oNA5qE1+s2MzGb/c2V4m8CbtMWh9IKZrKqfAQ9 891VWAF70PbGI9juRUQ5UpQoNBhPCmOineCAmUS6DfrHf31vl5kZw4XiJwiGoVpNHa1b B4yva6xIaMdHmEhhzj+F0kw/tPBOG98++sKkJOCL6KFd2xnQGgmIij+uwCqlU3zCSSwe ECM2cMC6yRPT561YwuvHQu+EYRD/ypj1JvzkvZcSMdgrxYJeK0eAVpUZWCPadPX+/H/j Zs3nBuxNaffAqU80fOKLf8JLRB38pLZIKZYj+5FCGy6ZU4DYPboiZRzFrQHuTHKOWhHO lmQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BBfMn9SDIgg2Nddl+1VhBEHGScLc1AUe3ABgkxeGn1Q=; b=QFeErSYlgsfyD3l68YPFtMG/TngCf8F9fWWi1gW8EER01YJDbRB9xnOLEq8/jh34VW ze8F+7giHDz8d6pWya3HvmnEo0pUdVP5zjX02JHTYGaW2MYjbucJRHI5SRIhfKfLjIZ9 StlUQc6I0SMrZpKsdOLmQlRWSDOT4eUPw1r8pzpqDLBA5SxBzR6lZIoma+Ln/xtGjEJ6 dnunrDlgIgtrwtNZ4DjQNPe2g6s32e6Jp9ytnIyzI3Pr+78zudkfWs7VXvsb1JiCJcWK LlRjCy9PhRVs1ay5gfTZmKigwicKN2ZZEOy2W+6UkpcWkYTbpAqRVHDiPO1SsUdssKvV fc7A== X-Gm-Message-State: AOAM532aIXvvKd7xS/1kFoP729qVl7YANfM4G/ZVE+5wQgs1pcYEEOa7 nI6opIO2D00OKa/K33Q4y3nkKg== X-Google-Smtp-Source: ABdhPJw8Qozb8+q9M9urdjyUtyhW9TBbtoEUrBH2tTZQQKTtL4gj78oVcVzlBsg7rVv42Nw+5IV94Q== X-Received: by 2002:a1c:7213:: with SMTP id n19mr3633811wmc.14.1610121385233; Fri, 08 Jan 2021 07:56:25 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id u3sm15329032wre.54.2021.01.08.07.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 07:56:24 -0800 (PST) Date: Fri, 8 Jan 2021 15:56:22 +0000 From: "Leif Lindholm" To: Laszlo Ersek Cc: devel@edk2.groups.io, Ard Biesheuvel , Anthony Perard , Julien Grall Subject: Re: [PATCH 1/1] OvmfPkg: add TimeBaseLib resolution for OvmfXen Message-ID: <20210108155622.GT1664@vanye> References: <20210108141238.19911-1-leif@nuviainc.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 08, 2021 at 15:47:28 +0100, Laszlo Ersek wrote: > On 01/08/21 15:12, Leif Lindholm wrote: > > Commit 55ee36b0c490 > > ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib") > > added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks > > build of OvmfXen.dsc. > > > > Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf. > > > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Cc: Anthony Perard > > Cc: Julien Grall > > Signed-off-by: Leif Lindholm > > --- > > OvmfPkg/OvmfXen.dsc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > > index c13388ba5a05..7d31e88907ca 100644 > > --- a/OvmfPkg/OvmfXen.dsc > > +++ b/OvmfPkg/OvmfXen.dsc > > @@ -212,6 +212,7 @@ [LibraryClasses] > > Tcg2PhysicalPresenceLib|OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > > RealTimeClockLib|OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.inf > > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > > !ifdef $(DEBUG_ON_HYPERVISOR_CONSOLE) > > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPortNocheck.inf > > !else > > > > Reviewed-by: Laszlo Ersek Thanks - pushed as 9783767fcfc2. > Thank you! > Laszlo >