* [PATCH 1/1] OvmfPkg: add TimeBaseLib resolution for OvmfXen
@ 2021-01-08 14:12 Leif Lindholm
2021-01-08 14:47 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2021-01-08 14:12 UTC (permalink / raw)
To: devel; +Cc: Laszlo Ersek, Ard Biesheuvel, Anthony Perard, Julien Grall
Commit 55ee36b0c490
("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
build of OvmfXen.dsc.
Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
---
OvmfPkg/OvmfXen.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
index c13388ba5a05..7d31e88907ca 100644
--- a/OvmfPkg/OvmfXen.dsc
+++ b/OvmfPkg/OvmfXen.dsc
@@ -212,6 +212,7 @@ [LibraryClasses]
Tcg2PhysicalPresenceLib|OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
RealTimeClockLib|OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.inf
+ TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
!ifdef $(DEBUG_ON_HYPERVISOR_CONSOLE)
DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPortNocheck.inf
!else
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] OvmfPkg: add TimeBaseLib resolution for OvmfXen
2021-01-08 14:12 [PATCH 1/1] OvmfPkg: add TimeBaseLib resolution for OvmfXen Leif Lindholm
@ 2021-01-08 14:47 ` Laszlo Ersek
2021-01-08 15:56 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2021-01-08 14:47 UTC (permalink / raw)
To: Leif Lindholm, devel; +Cc: Ard Biesheuvel, Anthony Perard, Julien Grall
On 01/08/21 15:12, Leif Lindholm wrote:
> Commit 55ee36b0c490
> ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
> added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
> build of OvmfXen.dsc.
>
> Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> ---
> OvmfPkg/OvmfXen.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> index c13388ba5a05..7d31e88907ca 100644
> --- a/OvmfPkg/OvmfXen.dsc
> +++ b/OvmfPkg/OvmfXen.dsc
> @@ -212,6 +212,7 @@ [LibraryClasses]
> Tcg2PhysicalPresenceLib|OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> RealTimeClockLib|OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.inf
> + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> !ifdef $(DEBUG_ON_HYPERVISOR_CONSOLE)
> DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPortNocheck.inf
> !else
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thank you!
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] OvmfPkg: add TimeBaseLib resolution for OvmfXen
2021-01-08 14:47 ` Laszlo Ersek
@ 2021-01-08 15:56 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2021-01-08 15:56 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: devel, Ard Biesheuvel, Anthony Perard, Julien Grall
On Fri, Jan 08, 2021 at 15:47:28 +0100, Laszlo Ersek wrote:
> On 01/08/21 15:12, Leif Lindholm wrote:
> > Commit 55ee36b0c490
> > ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
> > added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
> > build of OvmfXen.dsc.
> >
> > Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
> >
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien@xen.org>
> > Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> > ---
> > OvmfPkg/OvmfXen.dsc | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> > index c13388ba5a05..7d31e88907ca 100644
> > --- a/OvmfPkg/OvmfXen.dsc
> > +++ b/OvmfPkg/OvmfXen.dsc
> > @@ -212,6 +212,7 @@ [LibraryClasses]
> > Tcg2PhysicalPresenceLib|OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf
> > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> > RealTimeClockLib|OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.inf
> > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> > !ifdef $(DEBUG_ON_HYPERVISOR_CONSOLE)
> > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPortNocheck.inf
> > !else
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks - pushed as 9783767fcfc2.
> Thank you!
> Laszlo
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-08 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-08 14:12 [PATCH 1/1] OvmfPkg: add TimeBaseLib resolution for OvmfXen Leif Lindholm
2021-01-08 14:47 ` Laszlo Ersek
2021-01-08 15:56 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox