From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48])
by mx.groups.io with SMTP id smtpd.web12.2523.1610124057233896677
for <devel@edk2.groups.io>;
Fri, 08 Jan 2021 08:40:57 -0800
Authentication-Results: mx.groups.io;
dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=tJ4uMKjm;
spf=pass (domain: nuviainc.com, ip: 209.85.128.48, mailfrom: leif@nuviainc.com)
Received: by mail-wm1-f48.google.com with SMTP id k10so8316059wmi.3
for <devel@edk2.groups.io>; Fri, 08 Jan 2021 08:40:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:in-reply-to:user-agent;
bh=bRpT05U7ZNY03PBpYWNlBvg6Jyrt64qlCOddRJ3eCgc=;
b=tJ4uMKjmYLGk2sgnP5GZIGf00gGneN34O0NwTlT3PPOK8+2do6aBTcfU+0HoRCGsbL
TahOb8lo4qF8oXXQk+/PVarT9W6ZSDJoD54NkQAzvOntncnsYxJum5WFCCbEKcePPf1U
BgLanDAi5xM6xmx8UwW82sIkK6VCB2eSIzdX/+KvoWaeEhqyKCDDCSHHuDm3LVPwVwc3
yDxyXf9W9u5saoc7KTXnk7+YL1P6GMvxpjFnzf4gJx1N9B+nKE2hxu3ggpUtUd8yDKEH
OTMBcXlds457uym9W4CVW3D0HniLxmXFeTYQMPAyEQ+tXhRhTk+ZGfcAHmBXdh5Olgl5
ZD1g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:in-reply-to:user-agent;
bh=bRpT05U7ZNY03PBpYWNlBvg6Jyrt64qlCOddRJ3eCgc=;
b=C6QgfeI6UJ9bBJ75BMtq2u3Rku1RmZM727BnlmSezUGFcYh9RMlqLxe0WKnSa7AcaY
0Knm8QhmOUhk4cpMkKcNThiVfcqMqrekTyyy28ZB0OB3crsk7ZoZoT5Qt7d+tu0eOy9J
Fh+lRXEyTgE1rryBVK3GDbVLGPExCf3Ps4mai/hEQiu2wH3RqdJATU+bpGPQYMi6Ohx+
1bAdlI9br4PZ+zhNftR45K/XHiiqn6RukJRlnUpNedQxkBYGTpAj8KUl03202R7iqqtl
Kjwjgb+sHFBLLaf4DtRzE6PHoFrL9htT0j5ijAzGb3Fsq2p0vvgnE700ntE4DU7p6l/G
diqw==
X-Gm-Message-State: AOAM532OcdsKxxNwakryRL9+AqVs97XYsPZIs/4LWgvu4gC4yRAqvwRG
jvcyGHMHaHNDMbho9YsYI+9ysA==
X-Google-Smtp-Source: ABdhPJwqG4tg2ML99cu/6iV2mEHlYX/fG9XKUSXYib3huKz6jpyz1AzB2cCKOf390YLicgLVZz2lIA==
X-Received: by 2002:a1c:6383:: with SMTP id x125mr3823936wmb.46.1610124055820;
Fri, 08 Jan 2021 08:40:55 -0800 (PST)
Return-Path: <leif@nuviainc.com>
Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148])
by smtp.gmail.com with ESMTPSA id v4sm15152904wrw.42.2021.01.08.08.40.54
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 08 Jan 2021 08:40:55 -0800 (PST)
Date: Fri, 8 Jan 2021 16:40:53 +0000
From: "Leif Lindholm" <leif@nuviainc.com>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
Sami Mujawar <Sami.Mujawar@arm.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH v5 00/23] ArmPkg,MdePkg: Add Universal/Smbios, and related changes
Message-ID: <20210108164053.GU1664@vanye>
References: <20210104225830.12606-1-rebecca@nuviainc.com>
<DB7PR08MB3260CC15FBBDFA9B848BA78290D10@DB7PR08MB3260.eurprd08.prod.outlook.com>
<1499c0a3-0e35-7678-e898-4c71226abb45@nuviainc.com>
MIME-Version: 1.0
In-Reply-To: <1499c0a3-0e35-7678-e898-4c71226abb45@nuviainc.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Fri, Jan 08, 2021 at 08:55:33 -0700, Rebecca Cran wrote:
> On 1/5/21 3:14 PM, Samer El-Haj-Mahmoud wrote:
>
> > I did quick review of parts of the patch, mostly compared against the RPi4 implementation which has been validated in the past.
> >
> > On the platform on which you are implementing this, are you able to run the FWTS SMBIOS tests and confirm that everything passes?
> >
> > Also, one question on the patch in general: Any reason why not to include the nuvia copyright header in these files?
>
>
> I haven't run the FWTS SMBIOS tests, but I'll make sure to run them before I
> submit the next version of the patch series.
>
> I'm never sure whether the changes I'm making are large enough to justify
> adding my own or NUVIA's copyright. Since I have now made quite a few
> changes to the original sources, I'll add it.
There are companies that require their employees to add their
copyright for fixing a typo in a comment. So in this project, there is
effectively no change too small.
With my experience from other projects, I tend to apply the "about
three lines of code" bar.
/
Leif