public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Nhi Pham <nhi@os.amperecomputing.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid
Date: Sun, 10 Jan 2021 01:20:05 +0000	[thread overview]
Message-ID: <20210110012005.GX1664@vanye> (raw)
In-Reply-To: <20210108134115.8011-1-nhi@os.amperecomputing.com>

On Fri, Jan 08, 2021 at 20:41:15 +0700, Nhi Pham wrote:
> The EfiGetVariable() is used in the entry of this module. So, the
> variable services are required to be ready before they are used. This
> patch adds the arch protocol gEfiVariableArchProtocolGuid to dependency
> expression to guarantee that this module will be started once the
> variable protocol is available.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 4ea3a6ded844.
Thanks!

> ---
>  EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> index fec53c79d335..0a4cd6dae703 100644
> --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> @@ -38,5 +38,5 @@ [Protocols]
>    gEfiRealTimeClockArchProtocolGuid
>  
>  [Depex]
> -  TRUE
> +  gEfiVariableArchProtocolGuid
>  
> -- 
> 2.17.1
> 

      parent reply	other threads:[~2021-01-10  1:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 13:41 [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid Nhi Pham
2021-01-08 14:02 ` [edk2-devel] " Laszlo Ersek
2021-01-08 14:07   ` Nhi Pham
2021-01-10  1:20 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210110012005.GX1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox