From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.groups.io with SMTP id smtpd.web11.12671.1610241608996081728 for ; Sat, 09 Jan 2021 17:20:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=PgtfdIo4; spf=pass (domain: nuviainc.com, ip: 209.85.221.54, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f54.google.com with SMTP id t30so12674300wrb.0 for ; Sat, 09 Jan 2021 17:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1pIPT0M8efohmzk6nG+8JyT41TkcPEADOM89v+Nn0nA=; b=PgtfdIo4/R6lwT7YC09Yi3CF7aofhnDZM3qH2LX1ghX6qGfmSIwJE+oD/ubjOSpGVx oO5RkjtQsIqghkdgk4f7DnSUpku54CQ6DSlZSmx00p+mkYX1G68pNZ5TerAFv13vozzV fpBdjNRLqYxuBibjLR8fvjz1wJp9Oyw4BmLP2GA7w/0r04B67dWRIJKXmPfuuzQ2zSeY zzdYtAXzHHlueTsKXIOjaMlQdAtA4jWIDtePmsuO1TtaqKd/KqU/irUIyHYjspxH1+Yq EamAkU3b8OqotUPR6hTW+aVS6CSQmHkZ64rYySq7YLVPkwdS/mTSyCN76EgzQZ3X3JfN O8eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1pIPT0M8efohmzk6nG+8JyT41TkcPEADOM89v+Nn0nA=; b=FsefoL285NxGRJz64myMFjuOUZPhI5shwtA7R1XkcoT6VjRA2fULNwVWI6XtczOS6u sOIZrF6kWnZrTSaGcO9hmZBD4imfWA3kctM9Gq66R9bXd/IoLLgjlpGSBoUUDyjJ7rmU DNeVK34RFPddWRyClgH8qtxtjXj1IOXKwowCT74UqfE7wFYMhrNPRfMpMXgZ9tNiqk96 5KKiAniIhwWn17zr0jCHnI8t7AlqDIVndHeMrKwtZ5KuL0yGMd8ukmNGjk8m6c/c869g SVbHVUnq8//WfS/TjtET+TCxZuF7I/MQKSTV5f5DHNAMdeMe+Xv1tJlJ2wUQnzt62OyW ymlw== X-Gm-Message-State: AOAM5303+GdGqBIa67XzCYF3YW0YYNhXxi9Oxadn9gS3nUW4HhZKqroT ZtT4uOe8uSvOmvlWUYqE7sNm0Q== X-Google-Smtp-Source: ABdhPJyYe9kGmnHAh4xXBy741HBXdEZMz5w5U/1Qgz5xFiCwkTwcYhgRuOFShzg3RroaMUKnGVlVQA== X-Received: by 2002:a5d:660b:: with SMTP id n11mr10109870wru.407.1610241607466; Sat, 09 Jan 2021 17:20:07 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id d187sm16796742wmd.8.2021.01.09.17.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jan 2021 17:20:07 -0800 (PST) Date: Sun, 10 Jan 2021 01:20:05 +0000 From: "Leif Lindholm" To: Nhi Pham Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid Message-ID: <20210110012005.GX1664@vanye> References: <20210108134115.8011-1-nhi@os.amperecomputing.com> MIME-Version: 1.0 In-Reply-To: <20210108134115.8011-1-nhi@os.amperecomputing.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 08, 2021 at 20:41:15 +0700, Nhi Pham wrote: > The EfiGetVariable() is used in the entry of this module. So, the > variable services are required to be ready before they are used. This > patch adds the arch protocol gEfiVariableArchProtocolGuid to dependency > expression to guarantee that this module will be started once the > variable protocol is available. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Nhi Pham Reviewed-by: Leif Lindholm Pushed as 4ea3a6ded844. Thanks! > --- > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > index fec53c79d335..0a4cd6dae703 100644 > --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > @@ -38,5 +38,5 @@ [Protocols] > gEfiRealTimeClockArchProtocolGuid > > [Depex] > - TRUE > + gEfiVariableArchProtocolGuid > > -- > 2.17.1 >