From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.groups.io with SMTP id smtpd.web09.12772.1610241826146643159 for ; Sat, 09 Jan 2021 17:23:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=TudOZAoO; spf=pass (domain: nuviainc.com, ip: 209.85.221.47, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f47.google.com with SMTP id d26so12613389wrb.12 for ; Sat, 09 Jan 2021 17:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=k1Kimkry1WQylgrPohPs4nH+OAj/jHaLDGobU+mo/h4=; b=TudOZAoO/ILXA2I5Ol84/mDe80sZ3nd56DKE3v14fzjEk+57CGJB/QKmNKxuRTJQla 04nH6bDbRJ6NZ9N3r7lNlyedhumcbJ2bHfHRWFp2hPCiHLhTUzK/hcKlA60A53KP++qg nNORRragA3CK1jsG8pknmYJW5/9lFWz8dZROlRiR9PJsLeMLzECSi7l3nVQ3q9a1klJk dNMw60zaSvNp79urfTqiD6oNezcd+kkBFZLS7RzN9s0/cpk2rccJQW7LTgQypNtfsdbw SyNJ4FFcCqcGybKte9QFR2r13z+KdLxSBskmZu7Xr31zgcPtzcCSKg7funPwe12VyJDw h2bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=k1Kimkry1WQylgrPohPs4nH+OAj/jHaLDGobU+mo/h4=; b=lX0tEaPcZXfWACJGnpQ78AIipDc5a4P7H0+J4mkIJ2Pp8MQ5NVsKKDp2X+oJDSgvuC piTcqC4Ks+eeTwpjdPYbBPD+8hta2lhk0GjP61TiActZP3X3d3jtgaf2qJ0HotmNLuID aR2zvO5LFOf/B3GVJ0+/rT+eZIMZ+B2+oWAf619GWJ18Z11xYY+hYQPbqTPjZP0bDC3J XIIZ5EGyyHR3sNFrsVOKdtnWWKLUYyr6NY/OnPShEkpqhrNJwGEfAXT6LvEZFcWkPrGX t7xjMKJpBbUWbXb/VSBpt61tN4vPxLh1Jw7x94OGceFpvXin0ozSyOldAB3lvLPYHQAl xn8w== X-Gm-Message-State: AOAM533k/+ApSIGizVtrSZHNx4yLrn2+do0eX+lWaC4wKeHRcnUR0xpu deBYEkKo+rajANv2NeKIXJ/EUg== X-Google-Smtp-Source: ABdhPJzM5mPx3o5oj+d1unv/SQduGJQaloR3UsTFMwLTAROP1M4QK3K6MPMs6qtJt7rg3cT2XvkPag== X-Received: by 2002:a5d:5181:: with SMTP id k1mr9811695wrv.226.1610241824832; Sat, 09 Jan 2021 17:23:44 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id s1sm17905130wrv.97.2021.01.09.17.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jan 2021 17:23:44 -0800 (PST) Date: Sun, 10 Jan 2021 01:23:42 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , "nd @ arm . com . Sami Mujawar" , Liming Gao , Michael D Kinney , Zhiguang Liu Subject: Re: [PATCH v5 04/23] ArmPkg: Add helper to read the Memory Model Features Register 2 Message-ID: <20210110012342.GY1664@vanye> References: <20210104225830.12606-1-rebecca@nuviainc.com> <20210104225830.12606-5-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210104225830.12606-5-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 04, 2021 at 15:58:11 -0700, Rebecca Cran wrote: > Add helper function to read the MMFR2 register. We will need this to > determine CCIDX support. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm > --- > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 11 +++++++++++ > ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 3 +++ > 2 files changed, 14 insertions(+) > > diff --git a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h b/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h > index 85bcecda730f..cfc0c878a415 100644 > --- a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h > +++ b/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h > @@ -41,5 +41,16 @@ EFIAPI > ArmReadIdAA64Pfr0 ( > VOID > ); > + > +/** Reads the ID_AA64MMFR2_EL1 register. > + > + @return The contents of the ID_AA64MMFR2_EL1 register. > +**/ > +UINTN > +EFIAPI > +ArmReadIdAA64Mmfr2 ( > + VOID > + ); > + > #endif // __AARCH64_LIB_H__ > > diff --git a/ArmPkg/Library/ArmLib/AArch64/AArch64Support.S b/ArmPkg/Library/ArmLib/AArch64/AArch64Support.S > index 129205d2ac27..d3cc1e86716b 100644 > --- a/ArmPkg/Library/ArmLib/AArch64/AArch64Support.S > +++ b/ArmPkg/Library/ArmLib/AArch64/AArch64Support.S > @@ -425,6 +425,9 @@ ASM_FUNC(ArmCallWFI) > wfi > ret > > +ASM_FUNC(ArmReadIdAA64Mmfr2) > + mrs x0, ID_AA64MMFR2_EL1 // read EL1 MMFR2 > + ret > > ASM_FUNC(ArmReadMpidr) > mrs x0, mpidr_el1 // read EL1 MPIDR > -- > 2.26.2 >