From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mx.groups.io with SMTP id smtpd.web08.13124.1610244719445546792 for ; Sat, 09 Jan 2021 18:11:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=MBPE+SOc; spf=pass (domain: nuviainc.com, ip: 209.85.221.48, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f48.google.com with SMTP id r7so12701369wrc.5 for ; Sat, 09 Jan 2021 18:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=F3JO2cLHzfxUEBhbFJ8q+nPc+e/1gXWXOzSQ/iJ1KzY=; b=MBPE+SOcHYKHO3Cd39uggmNe1ytx/omavFmr00NmzsA8n/KiZtGdxlaiOTNe71bZwV KLyopy6ItxQ4SoaORBL5gAwZmKuba9F3RezoXUqFtwQEiaIMRp3Z1hkXfKvXEuY8Jx8P 49x/U7vq6k+bSQa4pH/wTFOCp37sUYfzUAuyY6P3D6Jl6qNnOYAECHOVF6RzWxGSERSW yOqx9PFcO1sqJdCayGxbquEhQO6sOelgtXhyhr/lksD7AyDxaNTYByrNfKFQEWIq1wm7 2Ni+RsuOEbej9iuwYH9zTabuQahEKvsFJAfL4+iUTzV563YxlSd8Unu6pNHefg24R078 eueA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F3JO2cLHzfxUEBhbFJ8q+nPc+e/1gXWXOzSQ/iJ1KzY=; b=W6vPoXPrUdKmXbcomaTszr327ogZjjNEoH0UI8lkzmMPe8rQuuGDsXTb88WNNPYwwT 5hDlobtImZsqkNXfaKvlWiI4QY4+iXcV7OonJESpTb863mgg9rcCc9a30jFAwkKehkGP ErAMEYGvcnEw/mWMGeu2Xylb+dCxMyhebxWmdYSS5dgQg9Tv7UtNtRwEZGYhO4FOQS8O YfP9WU1vVpKg6AVm0z335l34hjo6xsAbD2H9bVNEHQ0Y2qkbt8gcaAT7kZ3SBe8r159M Dje0FlzJX7Yo7qC7GXYgQHYxLHL+Jb0lpKWihHodsTsh7hOU2XIW63wF5HOYfaRY5gO/ xB5g== X-Gm-Message-State: AOAM531VS2i+q0dH67V5+3W4VMV6TaMsgJn4HEeLpHe3A94AT1fDggnd Fe70m/5gqQDBJ35CDTNcMOLbpg== X-Google-Smtp-Source: ABdhPJzfkH/IuR2hNVOUC0fOXa5uLr4LEbD2oxRuE9v3YvZqwMUo6dFqpzSeNYshitKnMPN2ZpHmtw== X-Received: by 2002:a5d:6852:: with SMTP id o18mr9966534wrw.371.1610244718032; Sat, 09 Jan 2021 18:11:58 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id t188sm16796621wmf.9.2021.01.09.18.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jan 2021 18:11:57 -0800 (PST) Date: Sun, 10 Jan 2021 02:11:55 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , "nd @ arm . com . Sami Mujawar" , Liming Gao , Michael D Kinney , Zhiguang Liu Subject: Re: [PATCH v5 20/23] ArmPkg: Add Universal/Smbios/OemMiscLibNull Message-ID: <20210110021155.GF1664@vanye> References: <20210104225830.12606-1-rebecca@nuviainc.com> <20210104225830.12606-21-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210104225830.12606-21-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 04, 2021 at 15:58:27 -0700, Rebecca Cran wrote: > Add a Null implementation of OemMiscLib. > > OemMiscLib provides functions that platforms implement to fill in > SMBIOS information for the SmbiosMiscDxe and ProcessSubClassDxe drivers. Given that it would never be a useful thing to *use* this library at runtime, could you add ASSERT (FALSE) to all functions? / Leif > > Signed-off-by: Rebecca Cran > --- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 31 +++++ > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 140 ++++++++++++++++++++ > 2 files changed, 171 insertions(+) > > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > new file mode 100644 > index 000000000000..342290acdb53 > --- /dev/null > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > @@ -0,0 +1,31 @@ > +#/** @file > +# OemMiscLib.inf > +# > +# Copyright (c) 2020, NUVIA Inc. All rights reserved. > +# Copyright (c) 2018, Hisilicon Limited. All rights reserved. > +# Copyright (c) 2018, Linaro Limited. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +#**/ > + > +[Defines] > + INF_VERSION = 1.29 > + BASE_NAME = OemMiscLibNull > + FILE_GUID = e80b8e6b-fffb-4c39-b433-41de67c9d7b8 > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = OemMiscLib > + > +[Sources.common] > + OemMiscLib.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + > +[LibraryClasses] > + BaseMemoryLib > + > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > new file mode 100644 > index 000000000000..ceee45839746 > --- /dev/null > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > @@ -0,0 +1,140 @@ > +/** @file > +* OemMiscLib.c > +* > +* Copyright (c) 2018, Hisilicon Limited. All rights reserved. > +* Copyright (c) 2018, Linaro Limited. All rights reserved. > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +* > +**/ > + > +#include > +#include > +#include > + > +#include > + > + > +/** Gets the CPU frequency of the specified processor. > + > + @param ProcessorIndex Index of the processor to get the frequency for. > + > + @return CPU frequency in Hz > +**/ > +EFIAPI > +UINTN > +OemGetCpuFreq ( > + IN UINT8 ProcessorIndex > + ) > +{ > + return 0; > +} > + > +/** Gets information about the specified processor and stores it in > + the structures provided. > + > + @param ProcessorIndex Index of the processor to get the information for. > + @param ProcessorStatus Processor status. > + @param ProcessorCharacteristics Processor characteritics. > + @param MiscProcessorData Miscellaneous processor information. > + > + @return TRUE on success, FALSE on failure. > +**/ > +EFIAPI > +BOOLEAN > +OemGetProcessorInformation ( > + IN UINTN ProcessorIndex, > + IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus, > + IN OUT PROCESSOR_CHARACTERISTIC_FLAGS *ProcessorCharacteristics, > + IN OUT MISC_PROCESSOR_DATA *MiscProcessorData > + ) > +{ > + return TRUE; > +} > + > +/** Gets information about the cache at the specified cache level. > + > + @param ProcessorIndex The processor to get information for. > + @param CacheLevel The cache level to get information for. > + @param InstructionOrUnifiedCache Whether the cache is instruction or > + unified, not data. > + @param SmbiosCacheTable The SMBIOS Type7 cache information structure. > + > + @return TRUE on success, FALSE on failure. > +**/ > +EFIAPI > +BOOLEAN > +OemGetCacheInformation ( > + IN UINT8 ProcessorIndex, > + IN UINT8 CacheLevel, > + IN BOOLEAN InstructionOrUnifiedCache, > + IN OUT SMBIOS_TABLE_TYPE7 *SmbiosCacheTable > + ) > +{ > + return TRUE; > +} > + > +/** Gets the maximum number of sockets supported by the platform. > + > + @return The maximum number of sockets. > +**/ > +EFIAPI > +UINT8 > +OemGetProcessorMaxSockets ( > + VOID > + ) > +{ > + return 1; > +} > + > +/** Gets the type of chassis for the system. > + > + @param ChassisType The type of the chassis. > + > + @retval EFI_SUCCESS The chassis type was fetched successfully. > +**/ > +EFI_STATUS > +EFIAPI > +OemGetChassisType ( > + UINT8 *ChassisType > + ) > +{ > + *ChassisType = MiscChassisTypeUnknown; > + return EFI_SUCCESS; > +} > + > +/** Returns whether the specified processor is present or not. > + > + @param ProcessIndex The processor index to check. > + > + @return TRUE is the processor is present, FALSE otherwise. > +**/ > +EFIAPI > +BOOLEAN > +OemIsSocketPresent ( > + IN UINTN ProcessorIndex > + ) > +{ > + if (ProcessorIndex == 0) { > + return TRUE; > + } > + > + return FALSE; > +} > + > +/** Updates the HII string for the specified field. > + > + @param mHiiHandle The HII handle. > + @param TokenToUpdate The string to update. > + @param Offset The field to get information about. > +**/ > +EFIAPI > +VOID > +UpdateSmbiosInfo ( > + IN EFI_HII_HANDLE mHiiHandle, > + IN EFI_STRING_ID TokenToUpdate, > + IN SMBIOS_HII_STRING_FIELD Offset > + ) > +{ > + > +} > -- > 2.26.2 >