From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.groups.io with SMTP id smtpd.web11.13197.1610244841276412653 for ; Sat, 09 Jan 2021 18:14:01 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=AaHV9zor; spf=pass (domain: nuviainc.com, ip: 209.85.128.52, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f52.google.com with SMTP id k10so10835720wmi.3 for ; Sat, 09 Jan 2021 18:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HpIYW+AVVJi7i0vHIuqGOjwkpd0snd2RcEANSWnahJQ=; b=AaHV9zorn4sphXvD8QhPEdgHnXQ4HPogyrQCDCqTuQ6XD67C6OySefOSN7bNvSfQuz rSg5uIaAfYqIVfvjnEsh6Rbn3l498t29wUWhXiYZE3b18zYBSCgKjOZlkrwWB6PIXSDm hXnbHW8RClNP3Oj1iwhqtAsrpdJCArTwPpEyvNmBKA1xA6QMsA2D28XGzdUd6167ceHT YveddAOIkAaQb4N/KzCRZ5K70YEDE1UA4AslkfLoyVwRIYwHtTnSsIJncmNKhkWe4EWq 6qAximbk6OZ6PharCxfPYjqCEc9Hsv442XOioOa1M/qizZ65a14aOTf2I7y/sQKUHPQr QVJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HpIYW+AVVJi7i0vHIuqGOjwkpd0snd2RcEANSWnahJQ=; b=n1cKR7srWZMZO7KTZBYetgHzPtBg79VWvM06LcC0ItRyjfc8BATx631biOoP4qakPw LppQu2NpG0JvtQklcmutYbzk3NJHeDicMkTP/LB6LMgUWFzVx9F5IdtITrA2a2MRL3pD q3fkASZBUDcWOcvZVLsUNnw74U4TFB+JIG6scEFJ90M6FQ1+VjjEFwCHpoIxnvBwhfvf j9K3C5fj9t7R+Kh1sLqbCUy5GggX0PRVuf03URJblt3qsxH1jm6ZRvaPn5Hdtl57KJsM DoyscaRocggFwIXfkP8fklBx20SMQr0pDceJjvEC1RX4zuOPdaQ+/8GF2ldDa7hunfiI rqMQ== X-Gm-Message-State: AOAM533vVMR4OMjauR6QSn2notqFkgLnvmMK45KnKPNEPnUCGtDfeYtc kHmsMCSM2fHD1UXWQBl+khLSOw== X-Google-Smtp-Source: ABdhPJxvwOFul+KblzkghlipyJ00AxK9TTPXni+d+LK4tXCNBdjO0owQBDEKvn1R0ONsVKxLMCFP7Q== X-Received: by 2002:a05:600c:410d:: with SMTP id j13mr9037737wmi.95.1610244839824; Sat, 09 Jan 2021 18:13:59 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id h16sm17004013wmb.41.2021.01.09.18.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jan 2021 18:13:59 -0800 (PST) Date: Sun, 10 Jan 2021 02:13:57 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , "nd @ arm . com . Sami Mujawar" , Liming Gao , Michael D Kinney , Zhiguang Liu Subject: Re: [PATCH v5 22/23] ArmPkg: Add SMBIOS PCDs to ArmPkg.dec Message-ID: <20210110021357.GH1664@vanye> References: <20210104225830.12606-1-rebecca@nuviainc.com> <20210104225830.12606-23-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210104225830.12606-23-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 04, 2021 at 15:58:29 -0700, Rebecca Cran wrote: > Platforms are expected to override these PCDs to provide relevant > information to SMBIOS. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm > --- > ArmPkg/ArmPkg.dec | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > index eaf1072d9ef3..62683146ed40 100644 > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -115,6 +115,20 @@ [PcdsFixedAtBuild.common] > # The Primary Core is ClusterId[0] & CoreId[0] > gArmTokenSpaceGuid.PcdArmPrimaryCore|0|UINT32|0x00000037 > > + # > + # SMBIOS PCDs > + # > + gArmTokenSpaceGuid.PcdSystemProductName|L""|VOID*|0x30000053 > + gArmTokenSpaceGuid.PcdSystemVersion|L""|VOID*|0x30000054 > + gArmTokenSpaceGuid.PcdBaseBoardManufacturer|L""|VOID*|0x30000055 > + gArmTokenSpaceGuid.PcdBaseBoardProductName|L""|VOID*|0x30000056 > + gArmTokenSpaceGuid.PcdBaseBoardVersion|L""|VOID*|0x30000057 > + gArmTokenSpaceGuid.PcdProcessorManufacturer|L""|VOID*|0x30000071 > + gArmTokenSpaceGuid.PcdProcessorVersion|L""|VOID*|0x30000072 > + gArmTokenSpaceGuid.PcdProcessorSerialNumber|L""|VOID*|0x30000073 > + gArmTokenSpaceGuid.PcdProcessorAssetTag|L""|VOID*|0x30000074 > + gArmTokenSpaceGuid.PcdProcessorPartNumber|L""|VOID*|0x30000075 > + > # > # ARM L2x0 PCDs > # > -- > 2.26.2 >